Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-19 Thread Tom Rini
On Fri, Jul 19, 2013 at 12:25:10PM +0200, Sascha Silbe wrote: > Subject: [PATCH] phy: fix 10/100Mbps operation on 1Gbps-capable links > > de1d786 [add support for Xilinx 1000BASE-X phy (GTX)] introduced a > check for the extended status register in order to support > 1Gbps-capable PHYs that don't

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-19 Thread Joe Hershberger
On Fri, Jul 19, 2013 at 5:25 AM, Sascha Silbe wrote: > From: Sascha Silbe > Date: Fri, 19 Jul 2013 11:37:54 +0200 > Subject: [PATCH] phy: fix 10/100Mbps operation on 1Gbps-capable links > > de1d786 [add support for Xilinx 1000BASE-X phy (GTX)] introduced a > check for the extended status register

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-19 Thread Charles Coldwell
It's difficult. The board has been taken away from me. It was a Virtex 6 FPGA running Microblaze Linux; I might be able to test on a Virtex 7 but not for several days. Sascha Silbe's fix looks good to me, however. On Fri, Jul 19, 2013 at 8:42 AM, Tom Rini wrote: > On Fri, Jul 19, 2013 at 09:38

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-19 Thread Tom Rini
On Fri, Jul 19, 2013 at 09:38:42AM -0300, Fabio Estevam wrote: > On Fri, Jul 19, 2013 at 7:25 AM, Sascha Silbe wrote: > > Hello Charles, > > > > [CC += a few people that were CC'ed on the revert of Charles' patch] > > > > Charles Coldwell writes: > > > >> I've never heard of the Wandboard Quad, s

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-19 Thread Fabio Estevam
On Fri, Jul 19, 2013 at 7:25 AM, Sascha Silbe wrote: > Hello Charles, > > [CC += a few people that were CC'ed on the revert of Charles' patch] > > Charles Coldwell writes: > >> I've never heard of the Wandboard Quad, so I suppose the short answer >> is "no". However, the philosophy of the patch

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-19 Thread Sascha Silbe
Hello Charles, [CC += a few people that were CC'ed on the revert of Charles' patch] Charles Coldwell writes: > I've never heard of the Wandboard Quad, so I suppose the short answer > is "no". However, the philosophy of the patch I submitted was: [...] Thanks for the description and the pointe

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Fabio Estevam
On Thu, Jul 18, 2013 at 9:31 AM, Charles Coldwell wrote: > On Thu, Jul 18, 2013 at 5:07 AM, Sascha Silbe wrote: >> >> >> Charles, do you have any idea why your commit breaks ethernet support on >> Wandboard Quad? > > I've never heard of the Wandboard Quad, so I suppose the short answer > is "no".

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Fabio Estevam
On Thu, Jul 18, 2013 at 9:31 AM, Charles Coldwell wrote: > Can somebody look up the phy register maps for the i.MX6 phy (if it's > built in) or whatever the Wandboard is using? mx6qsabresd and wandboard both use AR8031 PHY. ___ U-Boot mailing list U-Bo

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Fabio Estevam
On Thu, Jul 18, 2013 at 12:49 PM, Charles Coldwell wrote: > What happens if you just remove the line that assigns phydev->speed in > the previous version? It works fine if I do: --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -339,7 +339,6 @@ int genphy_parse_link(struct phy_device *

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Charles Coldwell
On Thu, Jul 18, 2013 at 11:44 AM, Fabio Estevam wrote: > > The following patch fixes it: > > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -337,12 +337,8 @@ int genphy_parse_link(struct phy_device *phydev) > estatus = phy_read(phydev, MDIO_DEVAD_NONE, >

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Charles Coldwell
On Thu, Jul 18, 2013 at 5:07 AM, Sascha Silbe wrote: > > > Charles, do you have any idea why your commit breaks ethernet support on > Wandboard Quad? I've never heard of the Wandboard Quad, so I suppose the short answer is "no". However, the philosophy of the patch I submitted was: 1. Check the

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Fabio Estevam
Joe, On Thu, Jul 18, 2013 at 8:41 AM, Fabio Estevam wrote: > I have tried: > > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -404,7 +404,7 @@ int genphy_config(struct phy_device *phydev) > if (val & ESTATUS_1000_XFULL) > features |= SUPPOR

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Fabio Estevam
On Thu, Jul 18, 2013 at 8:31 AM, Fabio Estevam wrote: > Hi Sascha, > > On Thu, Jul 18, 2013 at 6:07 AM, Sascha Silbe wrote: >> Sascha Silbe writes: >> >>> I've started a git bisect run (booting via USB OTG), but it's going to >>> take a while as git bisect is throwing lots of commits without Wan

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Fabio Estevam
Hi Sascha, On Thu, Jul 18, 2013 at 6:07 AM, Sascha Silbe wrote: > Sascha Silbe writes: > >> I've started a git bisect run (booting via USB OTG), but it's going to >> take a while as git bisect is throwing lots of commits without Wandboard >> Quad support at me and seems to be only narrowing down

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Sascha Silbe
Sascha Silbe writes: > I've started a git bisect run (booting via USB OTG), but it's going to > take a while as git bisect is throwing lots of commits without Wandboard > Quad support at me and seems to be only narrowing down the commits one > by one rather than on a log-2 basis. A slightly more

[U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Sascha Silbe
Hello, ethernet support for Wandboard Quad seems to be broken on current master (576aacdb): U-Boot 2013.07-rc3-00021-g576aacd (Jul 18 2013 - 08:34:32)