Re: [U-Boot] Inefficient code in NetLoop() ?

2008-09-26 Thread Rafal Jaworowski
Stefan Roese wrote: > On Friday 26 September 2008, Wolfgang Denk wrote: Am I reading this correctly that we eth_halt() and eth_init() the network interface for each and every call to NetLoop? >>> Yes, it looks that way. Ripe for gutting. >> I didn't have much time to look into the co

Re: [U-Boot] Inefficient code in NetLoop() ?

2008-09-26 Thread Wolfgang Denk
Dear Stefan, in message <[EMAIL PROTECTED]> you wrote: > > > > > Am I reading this correctly that we eth_halt() and eth_init() the > > > > network interface for each and every call to NetLoop? > > > > > > Yes, it looks that way. Ripe for gutting. > > > > I didn't have much time to look into

Re: [U-Boot] Inefficient code in NetLoop() ?

2008-09-26 Thread Stefan Roese
On Friday 26 September 2008, Wolfgang Denk wrote: > > > Am I reading this correctly that we eth_halt() and eth_init() the > > > network interface for each and every call to NetLoop? > > > > Yes, it looks that way. Ripe for gutting. > > I didn't have much time to look into the code, so I'm just

Re: [U-Boot] Inefficient code in NetLoop() ?

2008-09-26 Thread Wolfgang Denk
Dear Ben Warren, In message <[EMAIL PROTECTED]> you wrote: > > > Am I reading this correctly that we eth_halt() and eth_init() the > > network interface for each and every call to NetLoop? > > Yes, it looks that way. Ripe for gutting. I didn't have much time to look into the code, so I'm jus

Re: [U-Boot] Inefficient code in NetLoop() ?

2008-09-25 Thread Ben Warren
Wolfgang Denk wrote: > Dear Ben, > > I just ran over this piece of code in NetLoop() [see "net/net.c"]: > > 286 int > 287 NetLoop(proto_t protocol) > 288 { > ... > 322 eth_halt(); > 323 #ifdef CONFIG_NET_MULTI > 324 eth_set_current(); > 325 #endif > 326 if (eth_init

[U-Boot] Inefficient code in NetLoop() ?

2008-09-12 Thread Wolfgang Denk
Dear Ben, I just ran over this piece of code in NetLoop() [see "net/net.c"]: 286 int 287 NetLoop(proto_t protocol) 288 { ... 322 eth_halt(); 323 #ifdef CONFIG_NET_MULTI 324 eth_set_current(); 325 #endif 326 if (eth_init(bd) < 0) { 327 eth_halt();