Re: [U-Boot] Question about Coding-Style

2014-02-12 Thread Fabio Estevam
On Tue, Feb 4, 2014 at 8:03 PM, Scott Wood wrote: > Plus, horizontal scrolling is still a pain[1], and excessively long > lines can be harder to read even if they fit on the screen (this is why > newspapers and other documents often format text in columns). > > -Scott > > [1] I'm looking at you,

Re: [U-Boot] Question about Coding-Style

2014-02-10 Thread Wolfgang Denk
Dear Chris, In message <52f8a706.7030...@free.fr> you wrote: > > > "abc" > > "def" > > > > Is a valid C string, and does not require a backslash. Do I miss > > something? > > Yes, you are of course correct: the result is the C string "abcdef" and = > > the backslash in the original is su

Re: [U-Boot] Question about Coding-Style

2014-02-10 Thread Albert ARIBAUD
Hi Chris, > > Hmm... Last time I checked, > > > > "abc" > > "def" > > > > Is a valid C string, and does not require a backslash. Do I miss > > something? > > Yes, you are of course correct: the result is the C string "abcdef" and > the backslash in the original is superfluous. > However

Re: [U-Boot] Question about Coding-Style

2014-02-10 Thread Chris Moore
Hi Albert, Le 10/02/2014 10:58, Albert ARIBAUD a écrit : Hi Tom, On Tue, 4 Feb 2014 10:07:32 -0500, Tom Rini wrote: On Tue, Feb 04, 2014 at 04:02:56PM +0100, Stefano Babic wrote: Hi Hannes, On 04/02/2014 15:50, Hannes Petermaier wrote: [snip] Another thing is linewrapping of output string

Re: [U-Boot] Question about Coding-Style

2014-02-10 Thread Albert ARIBAUD
Hi Tom, On Tue, 4 Feb 2014 10:07:32 -0500, Tom Rini wrote: > On Tue, Feb 04, 2014 at 04:02:56PM +0100, Stefano Babic wrote: > > Hi Hannes, > > > > On 04/02/2014 15:50, Hannes Petermaier wrote: > [snip] > > > Another thing is linewrapping of output strings, to obey to the rules i > > > have to f

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Scott Wood
On Tue, 2014-02-04 at 12:50 +, Hannes Petermaier wrote: > 2) > a line ist limited to 80 characters (maybe thus comes from very old days > where displays couldn't show more than this and scrolling was very > expensive). is this state of the art ? Even on a fairly nice, modern screen, I find 80

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Wolfgang Denk
Dear Hannes, In message <29703.213.33.116.113.1391525447.squir...@petermaier.org> you wrote: > > The 80 character thing is reported from checkpatch.pl as WARNING, not as > ERROR - so there will be a chance of the patch to become accepted by a > custodian. It is better for your reputation ere on

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Wolfgang Denk
Dear Hannes, In message <11685.213.33.116.116.1391518218.squir...@petermaier.org> you wrote: > > I've read on the U-Boot website about coding style. They say 'All > contributions to U-Boot should conform to the Linux kernel coding style'. > Further i've read this link and there are at least 2 thi

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Tom Rini
On Tue, Feb 04, 2014 at 04:02:56PM +0100, Stefano Babic wrote: > Hi Hannes, > > On 04/02/2014 15:50, Hannes Petermaier wrote: [snip] > > Another thing is linewrapping of output strings, to obey to the rules i > > have to format the string as following: > > > > if (i2c_probe(TPS65217_CHIP_PM)) { >

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Stefano Babic
Hi Hannes, On 04/02/2014 15:50, Hannes Petermaier wrote: > The 80 character thing is reported from checkpatch.pl as WARNING, not as > ERROR - so there will be a chance of the patch to become accepted by a > custodian. No, it will *not* be accepted. There must be a very good reason to accept it.

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Tom Rini
On Tue, Feb 04, 2014 at 12:50:18PM -, Hannes Petermaier wrote: > Hello, > > I've read on the U-Boot website about coding style. They say 'All > contributions to U-Boot should conform to the Linux kernel coding style'. > Further i've read this link and there are at least 2 things which i have >

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Hannes Petermaier
Stefano, many thanks. This will be a hard challenge for me to obey to the rules :-) The 80 character thing is reported from checkpatch.pl as WARNING, not as ERROR - so there will be a chance of the patch to become accepted by a custodian. In between i tried to reformat by Code to obey to these r

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Michael Trimarchi
Hi Il 04/feb/2014 15:15 "Stefano Babic" ha scritto: > > Hi Hannes, > > On 04/02/2014 13:50, Hannes Petermaier wrote: > > Hello, > > > > I've read on the U-Boot website about coding style. They say 'All > > contributions to U-Boot should conform to the Linux kernel coding style'. > > Further i've

Re: [U-Boot] Question about Coding-Style

2014-02-04 Thread Stefano Babic
Hi Hannes, On 04/02/2014 13:50, Hannes Petermaier wrote: > Hello, > > I've read on the U-Boot website about coding style. They say 'All > contributions to U-Boot should conform to the Linux kernel coding style'. > Further i've read this link and there are at least 2 things which i have > troubles

[U-Boot] Question about Coding-Style

2014-02-04 Thread Hannes Petermaier
Hello, I've read on the U-Boot website about coding style. They say 'All contributions to U-Boot should conform to the Linux kernel coding style'. Further i've read this link and there are at least 2 things which i have troubles with. 1) a tab-ident is 8 spaces (in eclipse for example with the bu