Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-23 Thread Wolfgang Denk
on replies. > > > > What exactly do you mean > git am does not like it > and v2 will be better What are you talking about? "git am" on the patch with "Subject: Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU"

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 00:45 Fri 24 Jul , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090723223518.gd24...@game.jcrosoft.org> you wrote: > > On 17:30 Wed 22 Jul , Thomas Petazzoni wrote: > > > The Calao USB A9263 board is a board manufactured and sold by Calao > > > Systems

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-23 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090723223518.gd24...@game.jcrosoft.org> you wrote: > On 17:30 Wed 22 Jul , Thomas Petazzoni wrote: > > The Calao USB A9263 board is a board manufactured and sold by Calao > > Systems . Its components are very >

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:30 Wed 22 Jul , Thomas Petazzoni wrote: > The Calao USB A9263 board is a board manufactured and sold by Calao > Systems . Its components are very > similar to the AT91SAM9263EK board, so its configuration is based on > the configuration of this board. There a

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-22 Thread Peter Tyser
On Wed, 2009-07-22 at 18:04 +0200, Thomas Petazzoni wrote: > Hi, > > Le Wed, 22 Jul 2009 10:57:09 -0500, > Peter Tyser a écrit : > > > Hi Thomas, > > > > Just a note, but its nice when you resend patches to include the > > string [PATCH vX] where X=2, 3, etc. That way whoever applies your > >

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-22 Thread Albin Tonnerre
On Wed, Jul 22, 2009 at 10:57:09AM -0500, Peter Tyser wrote : > Hi Thomas, > > Just a note, but its nice when you resend patches to include the string > [PATCH vX] where X=2, 3, etc. That way whoever applies your patch can > tell which email contains the latest iteration of it. > > > This new ve

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-22 Thread Thomas Petazzoni
Hi, Le Wed, 22 Jul 2009 10:57:09 -0500, Peter Tyser a écrit : > Hi Thomas, > > Just a note, but its nice when you resend patches to include the > string [PATCH vX] where X=2, 3, etc. That way whoever applies your > patch can tell which email contains the latest iteration of it. Ok. > That's

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-22 Thread Peter Tyser
Hi Thomas, Just a note, but its nice when you resend patches to include the string [PATCH vX] where X=2, 3, etc. That way whoever applies your patch can tell which email contains the latest iteration of it. > This new version includes the following changes : > > * Copyright header on config.mk

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-22 Thread Thomas Petazzoni
The Calao USB A9263 board is a board manufactured and sold by Calao Systems . Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences: different clocks, no LCD, etc

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-20 Thread Wolfgang Denk
Dear Thomas Petazzoni, In message <20090720174220.1800d...@surf> you wrote: > > > Any specific reason for not using autosizing and testing via > > get_ram_size() ? > > The initial reason is that the code for this board is taken from the > Atmel boards code, which doesn't use get_ram_size(). Howev

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-20 Thread Peter Tyser
On Mon, 2009-07-20 at 17:40 +0200, Thomas Petazzoni wrote: > Le Thu, 16 Jul 2009 09:52:43 -0500, > Peter Tyser a écrit : > > > I don't have the final say here, I'm just giving my opinion. If it > > was possible to clean up, the best way in my would be to fix your > > board (ie this patch), then

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-20 Thread Thomas Petazzoni
Le Fri, 17 Jul 2009 21:41:43 +0200, Wolfgang Denk a écrit : > Entries to maintainers is missing. Yes, it was missing in the initial version of my patch, but further versions got it added, thanks to other people review. > > +int dram_init(void) > > +{ > > + gd->bd->bi_dram[0].start = PHYS_SDRA

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-20 Thread Thomas Petazzoni
Le Thu, 16 Jul 2009 09:52:43 -0500, Peter Tyser a écrit : > I don't have the final say here, I'm just giving my opinion. If it > was possible to clean up, the best way in my would be to fix your > board (ie this patch), then send a separate follow-up patch fixing > other boards. I don't think it

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-17 Thread Wolfgang Denk
Dear Thomas Petazzoni, In message <20090715163557.08b58...@surf> you wrote: > Support for the Calao USB A9263 board > > The Calao USB A9263 board is a board manufactured and sold by Calao > Systems . Its components are very > similar to the AT91SAM9263EK board, so i

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-16 Thread Peter Tyser
Hi Thomas, > > > +#define ROUND(A, B) (((A) + (B)) & ~((B) - 1)) > > > > I'd try and use the round functions already in include/common.h if > > possible. Maybe its not possible if this file is included prior to > > common.h though, I'm not sure. > > Not sure about this one. All at9

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-16 Thread Thomas Petazzoni
Le Wed, 15 Jul 2009 09:51:27 -0500, Peter Tyser a écrit : > You can get rid of the line above. It is nearly identical to the > patch subject and doesn't add any useful info. Ok. > > MAKEALL |1 > > Makefile |3 > > You should add an

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-15 Thread Peter Tyser
On Wed, 2009-07-15 at 16:35 +0200, Thomas Petazzoni wrote: > Support for the Calao USB A9263 board You can get rid of the line above. It is nearly identical to the patch subject and doesn't add any useful info. > > MAKEALL |1 > Makefile

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-15 Thread Thomas Petazzoni
Support for the Calao USB A9263 board The Calao USB A9263 board is a board manufactured and sold by Calao Systems . Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some di

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:07 Wed 01 Jul , Thomas Petazzoni wrote: > Hello, > > Here is a patch that adds the support for the Calao USB A9263 board. > This is my first board support contribution to U-Boot, so don't > hesitate to comment and suggest improvements. > > Thanks, > > Thomas this need to move after ---

[U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-01 Thread Thomas Petazzoni
Hello, Here is a patch that adds the support for the Calao USB A9263 board. This is my first board support contribution to U-Boot, so don't hesitate to comment and suggest improvements. Thanks, Thomas --- Support for the Calao USB A9263 board The Calao USB A9263 board is a board manufactured