Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-08 Thread Harvey Chapman
On Feb 7, 2013, at 5:22 PM, Scott Wood scottw...@freescale.com wrote: It's fine until you get a bad block in the partition, and you end up accessing the first block of the next partition (or getting Attempt to read/write outside the flash area if it's the last partition). Of course,

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-08 Thread Harvey Chapman
Eh, I shouldn't post code that quickly… Try this: diff --git a/common/cmd_nand.c b/common/cmd_nand.c --- a/common/cmd_nand.c +++ b/common/cmd_nand.c @@ -621,60 +621,80 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, nand = nand_info[dev]; s = strchr(cmd, '.');

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-08 Thread Scott Wood
On 02/08/2013 10:44:30 AM, Harvey Chapman wrote: Eh, I shouldn't post code that quickly… Try this: diff --git a/common/cmd_nand.c b/common/cmd_nand.c --- a/common/cmd_nand.c +++ b/common/cmd_nand.c @@ -621,60 +621,80 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, nand =

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-08 Thread Harvey Chapman
On Feb 8, 2013, at 6:34 PM, Scott Wood scottw...@freescale.com wrote: On 02/08/2013 10:44:30 AM, Harvey Chapman wrote: This should go inside the not raw path of the previous if statement. Please use tabs to indent. We already have nand in this context. We already have size -- and you don't

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-07 Thread Scott Wood
On 02/07/2013 04:13:55 PM, Harvey Chapman wrote: [ I started this conversation off-list before I joined the list. ] The idea is to add .part as a valid command suffix to nand read/write so it would match nand erase.part. The code to implement it makes nand read.part act identically to nand

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-07 Thread Harvey Chapman
[ I started this conversation off-list before I joined the list. ] The idea is to add .part as a valid command suffix to nand read/write so it would match nand erase.part. The code to implement it makes nand read.part act identically to nand read. On Feb 7, 2013, at 4:59 PM, Scott Wood