On Wed, Oct 11, 2017 at 03:34:33PM -0400, Tom Rini wrote: > As the code currently stands, we first check that the length of the > given command line, along with ip_str/mac_str along with an additional 1 > for the NULL termination will fit within the buffer we have, and if not, > we return an error. The way this code was originally written however > left Coverity "unhappy" due to using strcat rather than strncat. > Switching this to strncat however causes clang to be unhappy that we > aren't enforcing the "1" portion within strncat. Rather than further > re-work the code to include a "- 1" in this case as well, make the > strcat code only be done within the else side of the length test. This > keeps both clang and Coverity happy. > > Fixes: 48ee0a87bc46 ("cmd/pxe.c: Rework initrd and bootargs handling > slightly") > Signed-off-by: Tom Rini <tr...@konsulko.com>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot