Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-24 Thread Tom Rini
On Tue, Oct 24, 2023 at 02:39:49PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 24 Oct 2023 at 11:07, Tom Rini wrote: > > > > On Tue, Oct 24, 2023 at 11:02:06AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 23 Oct 2023 at 10:28, Tom Rini wrote: > > > > > > > > On Mon, Oct 23, 20

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-24 Thread Simon Glass
Hi Tom, On Tue, 24 Oct 2023 at 11:07, Tom Rini wrote: > > On Tue, Oct 24, 2023 at 11:02:06AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 23 Oct 2023 at 10:28, Tom Rini wrote: > > > > > > On Mon, Oct 23, 2023 at 10:13:52AM -0700, Simon Glass wrote: > > > > > > [snip] > > > > BTW buildma

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-24 Thread Tom Rini
On Tue, Oct 24, 2023 at 11:02:06AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 23 Oct 2023 at 10:28, Tom Rini wrote: > > > > On Mon, Oct 23, 2023 at 10:13:52AM -0700, Simon Glass wrote: > > > > [snip] > > > BTW buildman supports -L which disabled LTO using the NO_LTO=1 option > > > > I worry

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-24 Thread Simon Glass
Hi Tom, On Mon, 23 Oct 2023 at 10:28, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 10:13:52AM -0700, Simon Glass wrote: > > [snip] > > BTW buildman supports -L which disabled LTO using the NO_LTO=1 option > > I worry about putting sandbox-specific flags in buildman. Outside of > sandbox, targets

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-23 Thread Tom Rini
On Mon, Oct 23, 2023 at 10:13:52AM -0700, Simon Glass wrote: [snip] > BTW buildman supports -L which disabled LTO using the NO_LTO=1 option I worry about putting sandbox-specific flags in buildman. Outside of sandbox, targets that enable LTO require LTO, just like any other CONFIG option. -- T

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-23 Thread Simon Glass
Hi Tom, On Mon, 23 Oct 2023 at 06:37, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 12:05:34AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 21 Oct 2023 at 11:34, Tom Rini wrote: > > > > > > On Sat, Oct 21, 2023 at 08:43:00AM -0700, Simon Glass wrote: > > > > On Fri, 20 Oct 2023 at 14:53,

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-23 Thread Tom Rini
On Mon, Oct 23, 2023 at 12:05:34AM -0700, Simon Glass wrote: > Hi Tom, > > On Sat, 21 Oct 2023 at 11:34, Tom Rini wrote: > > > > On Sat, Oct 21, 2023 at 08:43:00AM -0700, Simon Glass wrote: > > > On Fri, 20 Oct 2023 at 14:53, Tom Rini wrote: > > > > > > > > The primary motivation for having a sa

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-23 Thread Simon Glass
Hi Tom, On Sat, 21 Oct 2023 at 11:34, Tom Rini wrote: > > On Sat, Oct 21, 2023 at 08:43:00AM -0700, Simon Glass wrote: > > On Fri, 20 Oct 2023 at 14:53, Tom Rini wrote: > > > > > > The primary motivation for having a sandbox without LTO build in CI is > > > to ensure that we don't have that opti

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-21 Thread Tom Rini
On Sat, Oct 21, 2023 at 08:43:00AM -0700, Simon Glass wrote: > On Fri, 20 Oct 2023 at 14:53, Tom Rini wrote: > > > > The primary motivation for having a sandbox without LTO build in CI is > > to ensure that we don't have that option break. We now have the ability > > to run tests of specific optio

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-21 Thread Simon Glass
On Fri, 20 Oct 2023 at 14:53, Tom Rini wrote: > > The primary motivation for having a sandbox without LTO build in CI is > to ensure that we don't have that option break. We now have the ability > to run tests of specific options being enabled/disabled, so drop the > parts of CI that build and tes

[v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-20 Thread Tom Rini
The primary motivation for having a sandbox without LTO build in CI is to ensure that we don't have that option break. We now have the ability to run tests of specific options being enabled/disabled, so drop the parts of CI that build and test that configuration specifically and add a build test in