Re: ECDSA related PRs

2024-03-07 Thread Igor Opaniuk
Hi Bob, On Thu, Mar 7, 2024 at 12:49 AM Bob Wolff wrote: > Hey all, > I'm not opposed to using the kernel ecdsa.c and have taken a quick look at > `ecdsa_verify()` - but I'd love if someone could point me in the right > direction for how to set up the context and public key. The >

Re: ECDSA related PRs

2024-03-06 Thread Bob Wolff
Hey all, I'm not opposed to using the kernel ecdsa.c and have taken a quick look at `ecdsa_verify()` - but I'd love if someone could point me in the right direction for how to set up the context and public key. The akcipher_request structure seems to address both the signature and the digest, but

Re: ECDSA related PRs

2024-02-28 Thread Dan Carpenter
On Thu, Feb 22, 2024 at 03:07:01PM -0800, Bob Wolff wrote: > Peter, > Thanks for helping lead me down the right path here. > > WRT tinycrypt, the license is quite permissive. > https://github.com/intel/tinycrypt > > Also, I'd like your advice - I was thinking for the larger patch that I'd > do

Re: ECDSA related PRs

2024-02-28 Thread Igor Opaniuk
Hi Bob, On Wed, Feb 28, 2024 at 7:14 PM Bob Wolff wrote: > > Any thoughts on how to proceed with the issue mentioned about tinycrypt > warnings/checks? > > Also, I'd like your advice - I was thinking for the larger patch that I'd > do it in two commits. The first would be the addition of the

Re: ECDSA related PRs

2024-02-28 Thread Bob Wolff
Any thoughts on how to proceed with the issue mentioned about tinycrypt warnings/checks? Also, I'd like your advice - I was thinking for the larger patch that I'd do it in two commits. The first would be the addition of the tinycrypt files and the second is the actual changes and additions to

Re: ECDSA related PRs

2024-02-22 Thread Bob Wolff
Peter, Thanks for helping lead me down the right path here. WRT tinycrypt, the license is quite permissive. https://github.com/intel/tinycrypt Also, I'd like your advice - I was thinking for the larger patch that I'd do it in two commits. The first would be the addition of the tinycrypt files

Re: ECDSA related PRs

2024-02-21 Thread Peter Robinson
On Wed, 21 Feb 2024, 11:30 Bob Wolff, wrote: > Hi there, > I have two separate but related pull requests I'd like to contribute. They > both have to do with ECDSA support. > - The simple one is a lack of null-pointer check that can cause a crash in > certain situations. Easy peasy. > Just send

Re: ECDSA related PRs

2024-02-21 Thread Fabio Estevam
Hi Bob, On Wed, Feb 21, 2024 at 8:30 AM Bob Wolff wrote: > > Hi there, > I have two separate but related pull requests I'd like to contribute. They > both have to do with ECDSA support. > - The simple one is a lack of null-pointer check that can cause a crash in > certain situations. Easy peasy.

ECDSA related PRs

2024-02-21 Thread Bob Wolff
Hi there, I have two separate but related pull requests I'd like to contribute. They both have to do with ECDSA support. - The simple one is a lack of null-pointer check that can cause a crash in certain situations. Easy peasy. - The less simple one (and hopefully not too controversial) adds an