Re: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-31 Thread Michal Simek
On 8/31/23 04:21, Chanho Park wrote: On 8/16/23 08:54, Chanho Park wrote: This fixes below build error when CC_OPTIMIZE_FOR_DEBUG is enabled and CONFIG_SPL_FPGA is not enabled. I would rewrite this because the connection to SPL_FPGA is just one part of it. It is also taken when CONFIG_FPGA

RE: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-30 Thread Chanho Park
> On 8/16/23 08:54, Chanho Park wrote: > > This fixes below build error when CC_OPTIMIZE_FOR_DEBUG is enabled and > > CONFIG_SPL_FPGA is not enabled. > > I would rewrite this because the connection to SPL_FPGA is just one part > of it. > It is also taken when CONFIG_FPGA is not enabled. Sure.

Re: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-29 Thread Michal Simek
On 8/16/23 08:54, Chanho Park wrote: This fixes below build error when CC_OPTIMIZE_FOR_DEBUG is enabled and CONFIG_SPL_FPGA is not enabled. I would rewrite this because the connection to SPL_FPGA is just one part of it. It is also taken when CONFIG_FPGA is not enabled.

Re: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-28 Thread Michal Simek
Hi, On 8/28/23 12:00, Chanho Park wrote: Hi, -Original Message- From: Eugen Hristev Sent: Monday, August 28, 2023 5:47 PM To: Chanho Park ; 'Michal Simek' ; u-boot@lists.denx.de Cc: Simon Glass Subject: Re: [PATCH] fpga: define dummy fpga_load function for debug build On 8/28/23 03

RE: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-28 Thread Chanho Park
Hi, > -Original Message- > From: Eugen Hristev > Sent: Monday, August 28, 2023 5:47 PM > To: Chanho Park ; 'Michal Simek' > ; u-boot@lists.denx.de > Cc: Simon Glass > Subject: Re: [PATCH] fpga: define dummy fpga_load function for debug build > > On 8/28/

Re: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-28 Thread Eugen Hristev
On 8/28/23 03:21, Chanho Park wrote: Hi, -Original Message- From: Michal Simek Sent: Friday, August 25, 2023 4:23 PM To: Chanho Park ; u-boot@lists.denx.de Subject: Re: [PATCH] fpga: define dummy fpga_load function for debug build Hi, On 8/16/23 08:54, Chanho Park wrote: This fixes

RE: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-27 Thread Chanho Park
Hi, > -Original Message- > From: Michal Simek > Sent: Friday, August 25, 2023 4:23 PM > To: Chanho Park ; u-boot@lists.denx.de > Subject: Re: [PATCH] fpga: define dummy fpga_load function for debug build > > Hi, > > On 8/16/23 08:54, Chanho Park wrote: >

Re: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-25 Thread Michal Simek
Hi, On 8/16/23 08:54, Chanho Park wrote: This fixes below build error when CC_OPTIMIZE_FOR_DEBUG is enabled and CONFIG_SPL_FPGA is not enabled. ../common/spl/spl_fit.c:591: undefined reference to `fpga_load' collect2: error: ld returned 1 exit status Signed-off-by: Chanho Park ---