RE: [PATCH u-boot v2 1/2] eth/r8152: fix assigning the wrong endpoint

Marek Vasut [mailto:ma...@denx.de] > Sent: Monday, May 25, 2020 9:01 PM [...] > > Excuse me. I test v1 only. > > Do I have to resend v1 for patch #1? > > I'll pick V1, no worries. Thanks. Best Regards, Hayes

Re: [PATCH u-boot v2 1/2] eth/r8152: fix assigning the wrong endpoint

On 5/25/20 2:52 PM, Hayes Wang wrote: > Marek Vasut [mailto:ma...@denx.de] >> Sent: Monday, May 25, 2020 8:03 PM > [...] > ep_out_found = 1; >>> - } >>> + } else if ((ep_addr & USB_DIR_OUT) && !ep_out_found) { >> >> >> Sorry,

RE: [PATCH u-boot v2 1/2] eth/r8152: fix assigning the wrong endpoint

Marek Vasut [mailto:ma...@denx.de] > Sent: Monday, May 25, 2020 8:03 PM [...] ep_out_found = 1; > > - } > > + } else if ((ep_addr & USB_DIR_OUT) && !ep_out_found) { > > > Sorry, I was wrong in my previous suggestion, the

Re: [PATCH u-boot v2 1/2] eth/r8152: fix assigning the wrong endpoint

On 5/25/20 9:47 AM, Hayes Wang wrote: > Although I think it never occurs, the code doesn't make sense, because > it may allow to assign an IN endpoint to ss->ep_out. > > Signed-off-by: Hayes Wang > --- > drivers/usb/eth/r8152.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(