> -----Original Message----- > From: Ovidiu Panait <ovpan...@gmail.com> > Sent: 2022年8月30日 1:02 > To: u-boot@lists.denx.de > Cc: Ovidiu Panait <ovpan...@gmail.com>; Simon Glass <s...@chromium.org>; > Andy Shevchenko <andriy.shevche...@linux.intel.com>; Dzmitry Sankouski > <dsankou...@gmail.com>; Heinrich Schuchardt <xypron.g...@gmx.de>; Jason > Liu <jason.hui....@nxp.com> > Subject: [PATCH v2 3/4] cmd: bdinfo: introduce bdinfo_print_size() helper > > Add bdinfo_print_size() helper to display size variables (such as cache > sizes) in bdinfo format. The size is printed as "xxx Bytes", "xxx KiB", "xxx MiB", > "xxx GiB", etc as needed; > > Reviewed-by: Simon Glass <s...@chromium.org> > Signed-off-by: Ovidiu Panait <ovpan...@gmail.com> > --- > > Changes in v2: > Added "Reviewed-by" tag from Simon. > > cmd/bdinfo.c | 7 +++++++ > include/init.h | 13 +++++++++++++ > 2 files changed, 20 insertions(+) > The patch looks good to me.
Reviewed-by: Jason Liu <jason.hui....@nxp.com>
> diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 37cd8a57eb..9e23c4dd8f
> 100644
> --- a/cmd/bdinfo.c
> +++ b/cmd/bdinfo.c
> @@ -16,9 +16,16 @@
> #include <vsprintf.h>
> #include <asm/cache.h>
> #include <asm/global_data.h>
> +#include <display_options.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> +void bdinfo_print_size(const char *name, uint64_t size) {
> + printf("%-12s= ", name);
> + print_size(size, "\n");
> +}
> +
> void bdinfo_print_num_l(const char *name, ulong value) {
> printf("%-12s= 0x%0*lx\n", name, 2 * (int)sizeof(value), value);
diff --git
> a/include/init.h b/include/init.h index 7b8f62c121..02bb4ce13e 100644
> --- a/include/init.h
> +++ b/include/init.h
> @@ -343,6 +343,19 @@ void bdinfo_print_num_ll(const char *name,
> unsigned long long value);
> /* Print a clock speed in MHz */
> void bdinfo_print_mhz(const char *name, unsigned long hz);
>
> +/**
> + * bdinfo_print_size - print size variables in bdinfo format
> + * @name: string to print before the size
> + * @size: size to print
> + *
> + * Helper function for displaying size variables as properly formatted
> +bdinfo
> + * entries. The size is printed as "xxx Bytes", "xxx KiB", "xxx MiB",
> + * "xxx GiB", etc. as needed;
> + *
> + * For use in arch_print_bdinfo().
> + */
> +void bdinfo_print_size(const char *name, uint64_t size);
> +
> /* Show arch-specific information for the 'bd' command */ void
> arch_print_bdinfo(void);
>
> --
> 2.25.1
smime.p7s
Description: S/MIME cryptographic signature
