Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
On Fri, Nov 5, 2021 at 3:04 PM Pali Rohár wrote: > > On Friday 05 November 2021 22:09:47 Pali Rohár wrote: > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > > + pci_read_word16(bp->pdev, > > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > > +

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 22:09:47 Pali Rohár wrote: > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > + pci_read_word16(bp->pdev, > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > + &bp->subsystem_vendor); > > > > + pci_read_word16(b

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 14:41:44 Roman Bacik wrote: > On Fri, Nov 5, 2021 at 2:29 PM Pali Rohár wrote: > > > > On Friday 05 November 2021 14:19:46 Roman Bacik wrote: > > > Hi Pali, > > > > > > On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > > > > > > > On Friday 05 November 2021 12:54:24

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
On Fri, Nov 5, 2021 at 2:29 PM Pali Rohár wrote: > > On Friday 05 November 2021 14:19:46 Roman Bacik wrote: > > Hi Pali, > > > > On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > > > > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > > > + pci_read_word16(bp->pdev, > > > > > >

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 14:19:46 Roman Bacik wrote: > Hi Pali, > > On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > > + pci_read_word16(bp->pdev, > > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > > +

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
Hi Pali, On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > + pci_read_word16(bp->pdev, > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > + &bp->subsystem_vendor); > > > > + pci_read_word16(bp->pdev, PCI_SUB

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > + pci_read_word16(bp->pdev, > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > + &bp->subsystem_vendor); > > > + pci_read_word16(bp->pdev, PCI_SUBSYSTEM_ID, &bp- > > >subsystem_device); > > > + pci_read_word16(bp->pdev

RE: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
Hi Pali, > -Original Message- > From: Pali Rohár > Sent: Wednesday, November 3, 2021 4:14 PM > To: Roman Bacik > Cc: U-Boot Mailing List ; Bharat Gooty > ; Joe Hershberger > ; Ramon Fried > Subject: Re: [PATCH v6 1/2] net: brcm: netXtreme driver > > He

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-03 Thread Pali Rohár
Hello! See inline comments below. On Tuesday 02 November 2021 11:18:10 Roman Bacik wrote: > From: Bharat Gooty > > Broadcom bnxt L2 driver support. Used by the Broadcom > iproc platforms. > > Signed-off-by: Bharat Gooty > Reviewed-by: Ramon Fried > > Signed-off-by: Roman Bacik > --- > > Ch