Re: [PATCH] efi_loader: fix an IS_ERR() vs NULL check

2023-07-27 Thread Dan Carpenter
On Thu, Jul 27, 2023 at 11:28:52AM +0300, Ilias Apalodimas wrote: > Hi Dan, Heinrich > > On Thu, 27 Jul 2023 at 11:25, Heinrich Schuchardt wrote: > > > > On 7/27/23 09:16, Dan Carpenter wrote: > > > The efi_parse_pkcs7_header() function returns NULL on error so the check > > > for IS_ERR() should

Re: [PATCH] efi_loader: fix an IS_ERR() vs NULL check

2023-07-27 Thread Dan Carpenter
On Thu, Jul 27, 2023 at 10:25:55AM +0200, Heinrich Schuchardt wrote: > On 7/27/23 09:16, Dan Carpenter wrote: > > The efi_parse_pkcs7_header() function returns NULL on error so the check > > for IS_ERR() should be changed to a NULL check. > > > > Signed-off-by: Dan Carpenter > > --- > > lib/efi

Re: [PATCH] efi_loader: fix an IS_ERR() vs NULL check

2023-07-27 Thread Ilias Apalodimas
On Thu, 27 Jul 2023 at 12:24, Dan Carpenter wrote: > > On Thu, Jul 27, 2023 at 11:28:52AM +0300, Ilias Apalodimas wrote: > > Hi Dan, Heinrich > > > > On Thu, 27 Jul 2023 at 11:25, Heinrich Schuchardt > > wrote: > > > > > > On 7/27/23 09:16, Dan Carpenter wrote: > > > > The efi_parse_pkcs7_header

Re: [PATCH] efi_loader: fix an IS_ERR() vs NULL check

2023-07-27 Thread Ilias Apalodimas
Hi Dan, Heinrich On Thu, 27 Jul 2023 at 11:25, Heinrich Schuchardt wrote: > > On 7/27/23 09:16, Dan Carpenter wrote: > > The efi_parse_pkcs7_header() function returns NULL on error so the check > > for IS_ERR() should be changed to a NULL check. > > > > Signed-off-by: Dan Carpenter > > --- > >

Re: [PATCH] efi_loader: fix an IS_ERR() vs NULL check

2023-07-27 Thread Heinrich Schuchardt
On 7/27/23 09:16, Dan Carpenter wrote: The efi_parse_pkcs7_header() function returns NULL on error so the check for IS_ERR() should be changed to a NULL check. Signed-off-by: Dan Carpenter --- lib/efi_loader/efi_capsule.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/