Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-28 Thread Marek Vasut
On 6/28/24 9:32 AM, Simon Glass wrote: Hi Marek, Hi, [...] @@ -473,8 +483,6 @@ static int regulator_pre_probe(struct udevice *dev) -ENODATA); uc_pdata->max_uA = dev_read_u32_default(dev, "regulator-max-microamp",

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-28 Thread Caleb Connolly
Hi Simon, This is reading a lot of DT stuff very early, which may be slow. It is also reading from the DT in the bind() step which we sometimes have to do, but try to avoid. Could we set up the livetree pre-bind? What about MMU? On armv8 at least this would have a huge impact on performance.

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-28 Thread Simon Glass
Hi Marek, On Thu, 27 Jun 2024 at 17:05, Marek Vasut wrote: > > On 6/27/24 10:37 AM, Simon Glass wrote: > > Hi Marek, > > Hi, > > [...] > > >> --- > >> drivers/power/regulator/regulator-uclass.c | 22 +++--- > >> 1 file changed, 15 insertions(+), 7 deletions(-) > >> > >> diff

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-28 Thread Simon Glass
Hi Caleb, On Fri, 28 Jun 2024 at 01:09, Caleb Connolly wrote: > > > > On 27/06/2024 11:26, Simon Glass wrote: > > Hi Caleb, > > > > On Thu, 27 Jun 2024 at 09:48, Caleb Connolly > > wrote: > >> > >> > >> > >> On 27/06/2024 10:37, Simon Glass wrote: > >>> Hi Marek, > >>> > >>> On Thu, 27 Jun

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Caleb Connolly
On 27/06/2024 11:26, Simon Glass wrote: Hi Caleb, On Thu, 27 Jun 2024 at 09:48, Caleb Connolly wrote: On 27/06/2024 10:37, Simon Glass wrote: Hi Marek, On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: In case a regulator DT node contains regulator-always-on or regulator-boot-on

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Marek Vasut
On 6/27/24 10:37 AM, Simon Glass wrote: Hi Marek, Hi, [...] --- drivers/power/regulator/regulator-uclass.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Svyatoslav, On Thu, 27 Jun 2024 at 11:34, Svyatoslav Ryhel wrote: > > чт, 27 черв. 2024 р. о 12:26 Simon Glass пише: > > > > Hi Svyatoslav, > > > > On Thu, 27 Jun 2024 at 10:09, Svyatoslav wrote: > > > > > > > > > > > > 27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly > > >

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Svyatoslav Ryhel
чт, 27 черв. 2024 р. о 12:26 Simon Glass пише: > > Hi Svyatoslav, > > On Thu, 27 Jun 2024 at 10:09, Svyatoslav wrote: > > > > > > > > 27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly > > написав(-ла): > > > > > > > > >On 27/06/2024 10:37, Simon Glass wrote: > > >> Hi Marek, > > >> > > >>

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Caleb, On Thu, 27 Jun 2024 at 09:48, Caleb Connolly wrote: > > > > On 27/06/2024 10:37, Simon Glass wrote: > > Hi Marek, > > > > On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: > >> > >> In case a regulator DT node contains regulator-always-on or > >> regulator-boot-on > >> property, make

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Svyatoslav, On Thu, 27 Jun 2024 at 10:09, Svyatoslav wrote: > > > > 27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly > написав(-ла): > > > > > >On 27/06/2024 10:37, Simon Glass wrote: > >> Hi Marek, > >> > >> On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: > >>> > >>> In case a

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Svyatoslav
27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly написав(-ла): > > >On 27/06/2024 10:37, Simon Glass wrote: >> Hi Marek, >> >> On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: >>> >>> In case a regulator DT node contains regulator-always-on or >>> regulator-boot-on >>> property, make

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Caleb Connolly
On 27/06/2024 10:37, Simon Glass wrote: Hi Marek, On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: In case a regulator DT node contains regulator-always-on or regulator-boot-on property, make sure the regulator gets correctly configured by U-Boot on start up. Unconditionally probe such

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Marek, On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: > > In case a regulator DT node contains regulator-always-on or regulator-boot-on > property, make sure the regulator gets correctly configured by U-Boot on start > up. Unconditionally probe such regulator drivers. This is a preparatory