Re: [PATCH v2 2/3] mmc: rockchip_sdhci: Add support for RK3568

Hi, On 6/29/21 11:07 AM, 赵仪峰 wrote: > > > The variable types are different, IS_ERR_VALUE(host->max_clk) will not got > the right results. > > unsigned int max_clk; > > #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) Thanks for kindly explanation. I didn't check its type.

Re: Re: [PATCH v2 2/3] mmc: rockchip_sdhci: Add support for RK3568

Hi Jeahoon, >On 6/28/21 6:19 PM, Yifeng Zhao wrote: >> This patch adds support for the RK3568 platform to this driver. >> >> Signed-off-by: Yifeng Zhao >> --- >> >> Changes in v2: >> - Used sdhci_set_clock api to set clock. >> - Used read_poll_timeout api to check dll s

Re: [PATCH v2 2/3] mmc: rockchip_sdhci: Add support for RK3568

On 6/28/21 6:19 PM, Yifeng Zhao wrote: > This patch adds support for the RK3568 platform to this driver. > > Signed-off-by: Yifeng Zhao > --- > > Changes in v2: > - Used sdhci_set_clock api to set clock. > - Used read_poll_timeout api to check dll status. > > drivers/mmc/rockchip_sdhci.c | 117