Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2024-05-28 Thread Gao Xiang
On 2024/5/28 21:28, Jonathan Liu wrote: Hi Jianan, Here are the LZ4 decompression times I got running "time unlz4 ..." on Rock 4 SE with RK3399 CPU. v2024.04: 1.329 seconds v2024.04 with 26c7fdadcb7 ("lib/lz4: update LZ4 decompressor module") reverted: 0.665 seconds v2024.04 with your

Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2024-05-28 Thread Jonathan Liu
Hi Jianan, Here are the LZ4 decompression times I got running "time unlz4 ..." on Rock 4 SE with RK3399 CPU. v2024.04: 1.329 seconds v2024.04 with 26c7fdadcb7 ("lib/lz4: update LZ4 decompressor module") reverted: 0.665 seconds v2024.04 with your patch: 1.216 seconds I managed to get better

Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2024-05-26 Thread Jianan Huang
Hi Jonathan, Could you please try the following patch ? It replaces all memcpy() calls in lz4 with __builtin_memcpy(). diff --git a/lib/lz4.c b/lib/lz4.c index d365dc727c..2afe31c1c3 100644 --- a/lib/lz4.c +++ b/lib/lz4.c @@ -34,6 +34,8 @@ #include #include +#define LZ4_memcpy(dst, src,

Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2024-05-26 Thread Jonathan Liu
Hi Gao, On Sat, 25 May 2024 at 02:52, Gao Xiang wrote: > > Hi, > > On 2024/5/24 22:26, Jonathan Liu wrote: > > Hi Jianan, > > > > On Sat, 26 Feb 2022 at 18:05, Huang Jianan wrote: > >> > >> Update the LZ4 compression module based on LZ4 v1.8.3 in order to > >> use the newest

Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2024-05-24 Thread Jonathan Liu
Hi Jianan, On Sat, 26 Feb 2022 at 18:05, Huang Jianan wrote: > > Update the LZ4 compression module based on LZ4 v1.8.3 in order to > use the newest LZ4_decompress_safe_partial() which can now decode > exactly the nb of bytes requested. > > Signed-off-by: Huang Jianan I noticed after this

Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2024-05-24 Thread Gao Xiang
Hi, On 2024/5/24 22:26, Jonathan Liu wrote: Hi Jianan, On Sat, 26 Feb 2022 at 18:05, Huang Jianan wrote: Update the LZ4 compression module based on LZ4 v1.8.3 in order to use the newest LZ4_decompress_safe_partial() which can now decode exactly the nb of bytes requested. Signed-off-by:

Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2022-03-16 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:05:48PM +0800, Huang Jianan wrote: > Update the LZ4 compression module based on LZ4 v1.8.3 in order to > use the newest LZ4_decompress_safe_partial() which can now decode > exactly the nb of bytes requested. > > Signed-off-by: Huang Jianan Applied to u-boot/next,