Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-12-05 Thread Doug Anderson
Hi, On Tue, Dec 5, 2023 at 3:16 AM Ahmad Fatoum wrote: > > Hello, > > On 04.12.23 18:52, Doug Anderson wrote:> On Sat, Dec 2, 2023 at 8:37 AM Simon > Glass wrote: > >> On Thu, 30 Nov 2023 at 19:04, Ahmad Fatoum wrote: > >>> On 30.11.23 21:30, Simon Glass wrote: > On Wed, 29 Nov 2023 at 12

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-12-05 Thread Ahmad Fatoum
Hello, On 04.12.23 18:52, Doug Anderson wrote:> On Sat, Dec 2, 2023 at 8:37 AM Simon Glass wrote: >> On Thu, 30 Nov 2023 at 19:04, Ahmad Fatoum wrote: >>> On 30.11.23 21:30, Simon Glass wrote: On Wed, 29 Nov 2023 at 12:54, Ahmad Fatoum wrote: > On 29.11.23 20:44, Simon Glass wrote: >>

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-12-04 Thread Doug Anderson
Hi, On Sat, Dec 2, 2023 at 8:37 AM Simon Glass wrote: > > Hi Ahmad, > > On Thu, 30 Nov 2023 at 19:04, Ahmad Fatoum wrote: > > > > Hello Simon, > > > > On 30.11.23 21:30, Simon Glass wrote: > > > On Wed, 29 Nov 2023 at 12:54, Ahmad Fatoum > > > wrote: > > >> On 29.11.23 20:44, Simon Glass wrote

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-12-02 Thread Simon Glass
Hi Ahmad, On Thu, 30 Nov 2023 at 19:04, Ahmad Fatoum wrote: > > Hello Simon, > > On 30.11.23 21:30, Simon Glass wrote: > > On Wed, 29 Nov 2023 at 12:54, Ahmad Fatoum wrote: > >> On 29.11.23 20:44, Simon Glass wrote: > >>> On Wed, 29 Nov 2023 at 12:33, Ahmad Fatoum > >>> wrote: > > On

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-30 Thread Ahmad Fatoum
Hello Simon, On 30.11.23 21:30, Simon Glass wrote: > On Wed, 29 Nov 2023 at 12:54, Ahmad Fatoum wrote: >> On 29.11.23 20:44, Simon Glass wrote: >>> On Wed, 29 Nov 2023 at 12:33, Ahmad Fatoum wrote: On 29.11.23 20:27, Simon Glass wrote: > On Wed, 29 Nov 2023 at 12:15, Ahmad Fatoum

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-30 Thread Simon Glass
Hi Masahiro, On Thu, 30 Nov 2023 at 08:39, Masahiro Yamada wrote: > > On Thu, Nov 30, 2023 at 2:22 AM Simon Glass wrote: > > > > Add a script which produces a Flat Image Tree (FIT), a single file > > containing the built kernel and associated devicetree files. > > Compression defaults to gzip wh

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-30 Thread Simon Glass
Hi Ahmad, On Wed, 29 Nov 2023 at 12:54, Ahmad Fatoum wrote: > > Hello Simon, > > On 29.11.23 20:44, Simon Glass wrote: > > Hi Ahmad, > > > > On Wed, 29 Nov 2023 at 12:33, Ahmad Fatoum wrote: > >> > >> On 29.11.23 20:27, Simon Glass wrote: > >>> On Wed, 29 Nov 2023 at 12:15, Ahmad Fatoum > >>>

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-30 Thread Simon Glass
Hi Ahmad, On Wed, 29 Nov 2023 at 11:35, Ahmad Fatoum wrote: > > Hello Simon, > > On 29.11.23 18:21, Simon Glass wrote: > > Add a script which produces a Flat Image Tree (FIT), a single file > > containing the built kernel and associated devicetree files. > > Compression defaults to gzip which giv

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-30 Thread Masahiro Yamada
On Thu, Nov 30, 2023 at 2:22 AM Simon Glass wrote: > > Add a script which produces a Flat Image Tree (FIT), a single file > containing the built kernel and associated devicetree files. > Compression defaults to gzip which gives a good balance of size and > performance. > > The files compress from

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-30 Thread Masahiro Yamada
On Thu, Nov 30, 2023 at 5:26 PM Nicolas Schier wrote: > > Simon, > > thanks for the patch! Below are some nitpicks and bike-shedding > questions. > > On Wed 29 Nov 2023 10:21:53 GMT, Simon Glass wrote: > > Add a script which produces a Flat Image Tree (FIT), a single file > > containing the built

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-30 Thread Nicolas Schier
Simon, thanks for the patch! Below are some nitpicks and bike-shedding questions. On Wed 29 Nov 2023 10:21:53 GMT, Simon Glass wrote: > Add a script which produces a Flat Image Tree (FIT), a single file > containing the built kernel and associated devicetree files. > Compression defaults to gzi

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Ahmad Fatoum
Hi Simon, On 29.11.23 20:00, Simon Glass wrote: > On Wed, 29 Nov 2023 at 11:35, Ahmad Fatoum wrote: >> Doesn't hardcoding a load address and entry address here defeat the point >> of having FIT as generic portable image format? >> >> At least barebox will try to place the kernel image at physical

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Tom Rini
On Wed, Nov 29, 2023 at 08:16:20PM +0100, Ahmad Fatoum wrote: > Hello Tom, > > On 29.11.23 20:02, Tom Rini wrote: > > On Wed, Nov 29, 2023 at 07:59:00PM +0100, Ahmad Fatoum wrote: > >> Hi, > >> > >> a few more comments after decompiling the FIT image: > >> > >> On 29.11.23 18:21, Simon Glass wrote

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Ahmad Fatoum
Hello Simon, On 29.11.23 20:44, Simon Glass wrote: > Hi Ahmad, > > On Wed, 29 Nov 2023 at 12:33, Ahmad Fatoum wrote: >> >> On 29.11.23 20:27, Simon Glass wrote: >>> On Wed, 29 Nov 2023 at 12:15, Ahmad Fatoum wrote: On 29.11.23 20:02, Simon Glass wrote: > On Wed, 29 Nov 2023 at 11:59, A

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Simon Glass
Hi Ahmad, On Wed, 29 Nov 2023 at 12:33, Ahmad Fatoum wrote: > > On 29.11.23 20:27, Simon Glass wrote: > > On Wed, 29 Nov 2023 at 12:15, Ahmad Fatoum wrote: > >> On 29.11.23 20:02, Simon Glass wrote: > >>> On Wed, 29 Nov 2023 at 11:59, Ahmad Fatoum > >>> wrote: > The specification says tha

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Ahmad Fatoum
On 29.11.23 20:27, Simon Glass wrote: > On Wed, 29 Nov 2023 at 12:15, Ahmad Fatoum wrote: >> On 29.11.23 20:02, Simon Glass wrote: >>> On Wed, 29 Nov 2023 at 11:59, Ahmad Fatoum wrote: The specification says that this is the root U-Boot compatible, which I presume to mean the top-level

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Simon Glass
Hi Ahmad, On Wed, 29 Nov 2023 at 12:15, Ahmad Fatoum wrote: > > Hello Simon, > > On 29.11.23 20:02, Simon Glass wrote: > > Hi Ahmad, > > > > On Wed, 29 Nov 2023 at 11:59, Ahmad Fatoum wrote: > >> > >> Hi, > >> > >> a few more comments after decompiling the FIT image: > >> > >> On 29.11.23 18:21,

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Ahmad Fatoum
Hello Tom, On 29.11.23 20:02, Tom Rini wrote: > On Wed, Nov 29, 2023 at 07:59:00PM +0100, Ahmad Fatoum wrote: >> Hi, >> >> a few more comments after decompiling the FIT image: >> >> On 29.11.23 18:21, Simon Glass wrote: >>> +with fsw.add_node('kernel'): >>> +fsw.property_string('descri

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Ahmad Fatoum
Hello Simon, On 29.11.23 20:02, Simon Glass wrote: > Hi Ahmad, > > On Wed, 29 Nov 2023 at 11:59, Ahmad Fatoum wrote: >> >> Hi, >> >> a few more comments after decompiling the FIT image: >> >> On 29.11.23 18:21, Simon Glass wrote: >>> +with fsw.add_node('kernel'): >>> +fsw.property_st

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Simon Glass
Hi Ahmad, On Wed, 29 Nov 2023 at 11:59, Ahmad Fatoum wrote: > > Hi, > > a few more comments after decompiling the FIT image: > > On 29.11.23 18:21, Simon Glass wrote: > > +with fsw.add_node('kernel'): > > +fsw.property_string('description', args.name) > > +fsw.property_string(

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Tom Rini
On Wed, Nov 29, 2023 at 07:59:00PM +0100, Ahmad Fatoum wrote: > Hi, > > a few more comments after decompiling the FIT image: > > On 29.11.23 18:21, Simon Glass wrote: > > +with fsw.add_node('kernel'): > > +fsw.property_string('description', args.name) > > +fsw.property_string(

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Simon Glass
Hi Ahmad, On Wed, 29 Nov 2023 at 11:35, Ahmad Fatoum wrote: > > Hello Simon, > > On 29.11.23 18:21, Simon Glass wrote: > > Add a script which produces a Flat Image Tree (FIT), a single file > > containing the built kernel and associated devicetree files. > > Compression defaults to gzip which giv

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Ahmad Fatoum
Hi, a few more comments after decompiling the FIT image: On 29.11.23 18:21, Simon Glass wrote: > +with fsw.add_node('kernel'): > +fsw.property_string('description', args.name) > +fsw.property_string('type', 'kernel_noload') The specification only says no loading done, but doe

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

2023-11-29 Thread Ahmad Fatoum
Hello Simon, On 29.11.23 18:21, Simon Glass wrote: > Add a script which produces a Flat Image Tree (FIT), a single file > containing the built kernel and associated devicetree files. > Compression defaults to gzip which gives a good balance of size and > performance. Thanks for working on this. I