Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-06 Thread Markus Hubig
On Mon, Aug 06, 2012 at 02:49:51PM +0200, Andreas Bießmann wrote: > On 02.08.2012 16:14, Markus Hubig wrote: > > On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießmann wrote: > >> On 30.07.12 20:01, Markus Hubig wrote: > > > > PC9 is somewhat strange. If I set it to 0 I don't have a console! >

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-06 Thread Andreas Bießmann
Dear Markus Hubig, On 02.08.2012 16:14, Markus Hubig wrote: > On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießmann wrote: >> On 30.07.12 20:01, Markus Hubig wrote: >>> > > > >>> +int board_early_init_f(void) >>> +{ >>> + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; >>> + >>

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-06 Thread Andreas Bießmann
Dear Markus Hubig, On 03.08.2012 14:05, Markus Hubig wrote: > On Thu, Aug 02, 2012 at 03:28:30PM +0200, Markus Hubig wrote: >> On Wed, Aug 01, 2012 at 10:21:04PM +0200, Andreas Bießmann wrote: >>> On 01.08.12 21:28, Markus Hubig wrote: On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießman

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-06 Thread Markus Hubig
On Mon, Aug 06, 2012 at 11:05:03AM +0200, Markus Hubig wrote: > This adds support for the AT91SAM9G20 boards by taskit GmbH. > Both boards, Stamp9G20 and PortuxG20, are integrated in one > file. PortuxG20 is basically a SBC built around the Stamp9G20. Ignore this. I started a new thread with [PATC

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-03 Thread Markus Hubig
On Thu, Aug 02, 2012 at 03:28:30PM +0200, Markus Hubig wrote: > On Wed, Aug 01, 2012 at 10:21:04PM +0200, Andreas Bießmann wrote: > > On 01.08.12 21:28, Markus Hubig wrote: > > > On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießmann wrote: > > >>> + /* Need to reset PHY -> 500ms reset */

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-02 Thread Markus Hubig
On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießmann wrote: > On 30.07.12 20:01, Markus Hubig wrote: > > > > +int board_early_init_f(void) > > +{ > > + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; > > + > > + /* Enable clocks for all PIOs */ > > + writel((1 << ATMEL_ID_P

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-02 Thread Markus Hubig
On Wed, Aug 01, 2012 at 10:21:04PM +0200, Andreas Bießmann wrote: > On 01.08.12 21:28, Markus Hubig wrote: > > On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießmann wrote: > >>> + /* Need to reset PHY -> 500ms reset */ > >>> + writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | > >>> + AT9

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-01 Thread Andreas Bießmann
Hi Markus, On 01.08.12 21:28, Markus Hubig wrote: > Hello Andreas, > > thanks for your responce. I will provide an updated patch based on > your comments! > > On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießmann wrote: >> ---8<--- >> andreas@andreas-mbp % ./tools/checkpatch.pl >> U-Boot-at

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-01 Thread Markus Hubig
Hello Andreas, thanks for your responce. I will provide an updated patch based on your comments! On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bießmann wrote: > ---8<--- > andreas@andreas-mbp % ./tools/checkpatch.pl > U-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch > WARNING: Whi

Re: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.

2012-08-01 Thread Andreas Bießmann
Dear Markus Hubig, first of all: ---8<--- andreas@andreas-mbp % ./tools/checkpatch.pl U-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch WARNING: Whitespace before semicolon #214: FILE: board/taskit/stamp9g20/stamp9g20.c:123: + ; total: 0 errors, 1 warnings, 484 lines che