Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-07-26 Thread Carlo Caione
On Tue, 2018-07-24 at 10:07 +0200, Dr. Philipp Tomsich wrote: > > I have a patchset for changing the relevant fields in U-Boot to allow > for 33bits (i.e. using u64) for the RAM size and it finally passes > Travis cleanly. > It will be another round or two of cleanup before I can submit the >

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-07-24 Thread Dr. Philipp Tomsich
Marty, > On 6 Jul 2018, at 05:11, Marty E. Plummer wrote: > > On Sat, May 19, 2018 at 02:08:53PM +0200, Dr. Philipp Tomsich wrote: >> Marty, >> >>> On 19 May 2018, at 12:40, Marty E. Plummer wrote: >>> >>> So explain to me what you'd like me to do here, if you would. What I >>> gather from

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-07-10 Thread Dr. Philipp Tomsich
> On 10 Jul 2018, at 16:41, Simon Glass wrote: > > Hi, > > On 8 May 2018 at 04:21, Dr. Philipp Tomsich > > wrote: >> Marty, >> >>> On 8 May 2018, at 02:52, Marty E. Plummer wrote: >>> >>> On Mon, May 07, 2018 at 11:16:28AM +0200, Dr. Philipp

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-07-10 Thread Simon Glass
Hi, On 8 May 2018 at 04:21, Dr. Philipp Tomsich wrote: > Marty, > >> On 8 May 2018, at 02:52, Marty E. Plummer wrote: >> >> On Mon, May 07, 2018 at 11:16:28AM +0200, Dr. Philipp Tomsich wrote: >>> On 7 May 2018, at 04:34, Marty E. Plummer wrote: On Mon, May 07, 2018 at

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-07-05 Thread Marty E. Plummer
On Sat, May 19, 2018 at 02:08:53PM +0200, Dr. Philipp Tomsich wrote: > Marty, > > > On 19 May 2018, at 12:40, Marty E. Plummer wrote: > > > > So explain to me what you'd like me to do here, if you would. What I > > gather from this is you want me to flip CONFIG_PHYS_64BIT and see if it > >

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-19 Thread Dr. Philipp Tomsich
Marty, > On 19 May 2018, at 12:40, Marty E. Plummer wrote: > > On Mon, May 14, 2018 at 05:56:27PM +0200, Dr. Philipp Tomsich wrote: >> I had a bit more time to look into this and it looks as if we have two >> problem-spots... >> >> First, there's a type-mismatch

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-19 Thread Marty E. Plummer
On Mon, May 14, 2018 at 05:56:27PM +0200, Dr. Philipp Tomsich wrote: > I had a bit more time to look into this and it looks as if we have two > problem-spots... > > First, there's a type-mismatch between ram_info.size (a size_t) and > gd.ram_size (phys_size_t). > While we can increase the size

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-14 Thread Dr. Philipp Tomsich
I had a bit more time to look into this and it looks as if we have two problem-spots... First, there's a type-mismatch between ram_info.size (a size_t) and gd.ram_size (phys_size_t). While we can increase the size of a phys_size_t to 64bit (by defining CONFIG_PHYS_64BIT), the size_t will

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-09 Thread Dr. Philipp Tomsich
> On 9 May 2018, at 07:29, Marty E. Plummer wrote: > > On Tue, May 08, 2018 at 11:08:14PM +0200, Dr. Philipp Tomsich wrote: >> >>> On 8 May 2018, at 21:21, Marty E. Plummer wrote: >>> >>> On Tue, May 08, 2018 at 12:21:24PM +0200, Dr. Philipp

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-08 Thread Marty E. Plummer
On Tue, May 08, 2018 at 11:08:14PM +0200, Dr. Philipp Tomsich wrote: > > > On 8 May 2018, at 21:21, Marty E. Plummer wrote: > > > > On Tue, May 08, 2018 at 12:21:24PM +0200, Dr. Philipp Tomsich wrote: > >> Marty, > >> > >>> On 8 May 2018, at 02:52, Marty E. Plummer

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-08 Thread Dr. Philipp Tomsich
> On 8 May 2018, at 21:21, Marty E. Plummer wrote: > > On Tue, May 08, 2018 at 12:21:24PM +0200, Dr. Philipp Tomsich wrote: >> Marty, >> >>> On 8 May 2018, at 02:52, Marty E. Plummer wrote: >>> >>> On Mon, May 07, 2018 at 11:16:28AM +0200, Dr.

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-08 Thread Marty E. Plummer
On Tue, May 08, 2018 at 12:21:24PM +0200, Dr. Philipp Tomsich wrote: > Marty, > > > On 8 May 2018, at 02:52, Marty E. Plummer wrote: > > > > On Mon, May 07, 2018 at 11:16:28AM +0200, Dr. Philipp Tomsich wrote: > >> > >>> On 7 May 2018, at 04:34, Marty E. Plummer

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-08 Thread Dr. Philipp Tomsich
Simon, Looks like we’d like to have a 64bit type for size in ‘struct ram_info’ (see below). Let us know what you think of the proposed change. Thanks, Philipp. > On 8 May 2018, at 12:21, Dr. Philipp Tomsich > wrote: > > Marty, > >> On 8 May 2018, at

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-08 Thread Dr. Philipp Tomsich
Marty, > On 8 May 2018, at 02:52, Marty E. Plummer wrote: > > On Mon, May 07, 2018 at 11:16:28AM +0200, Dr. Philipp Tomsich wrote: >> >>> On 7 May 2018, at 04:34, Marty E. Plummer wrote: >>> >>> On Mon, May 07, 2018 at 10:20:55AM +0800, Kever

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-07 Thread Marty E. Plummer
On Mon, May 07, 2018 at 11:16:28AM +0200, Dr. Philipp Tomsich wrote: > > > On 7 May 2018, at 04:34, Marty E. Plummer wrote: > > > > On Mon, May 07, 2018 at 10:20:55AM +0800, Kever Yang wrote: > >> Hi Marty, > >> > >> > >> On 05/06/2018 10:25 PM, Marty E. Plummer wrote:

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-07 Thread Dr. Philipp Tomsich
> On 7 May 2018, at 04:34, Marty E. Plummer wrote: > > On Mon, May 07, 2018 at 10:20:55AM +0800, Kever Yang wrote: >> Hi Marty, >> >> >> On 05/06/2018 10:25 PM, Marty E. Plummer wrote: >>> Taken from coreboot's src/soc/rockchip/rk3288/sdram.c >>> >>> Without this

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread Marty E. Plummer
On Mon, May 07, 2018 at 10:20:55AM +0800, Kever Yang wrote: > Hi Marty, > > > On 05/06/2018 10:25 PM, Marty E. Plummer wrote: > > Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > > > Without this change, my u-boot build for the asus c201 chromebook (4GiB) > > is incorrectly detected as

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread Kever Yang
Hi Marty, On 05/06/2018 10:25 PM, Marty E. Plummer wrote: > Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > Without this change, my u-boot build for the asus c201 chromebook (4GiB) > is incorrectly detected as 0 Bytes of ram. I know the root cause for this issue, and I have a local

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread Marty E. Plummer
On Mon, May 07, 2018 at 12:19:11AM +0200, Dr. Philipp Tomsich wrote: > > > On 6 May 2018, at 16:25, Marty E. Plummer wrote: > > > > Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > > > Without this change, my u-boot build for the asus c201 chromebook (4GiB) > >

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread Dr. Philipp Tomsich
> On 6 May 2018, at 16:25, Marty E. Plummer wrote: > > Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > Without this change, my u-boot build for the asus c201 chromebook (4GiB) > is incorrectly detected as 0 Bytes of ram. Could you elaborate what the change is

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread Marty E. Plummer
On Sun, May 06, 2018 at 10:21:55PM +0200, klaus.go...@theobroma-systems.com wrote: > > > On 06.05.2018, at 22:03, Marty E. Plummer wrote: > > > > On Sun, May 06, 2018 at 02:08:25PM -0500, Marty E. Plummer wrote: > >>> On Sun, May 06, 2018 at 08:39:23PM +0200, > >>>

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread klaus . goger
> On 06.05.2018, at 22:03, Marty E. Plummer wrote: > > On Sun, May 06, 2018 at 02:08:25PM -0500, Marty E. Plummer wrote: >>> On Sun, May 06, 2018 at 08:39:23PM +0200, klaus.go...@theobroma-systems.com >>> wrote: On 06.05.2018, at 16:25, Marty E. Plummer

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread Marty E. Plummer
On Sun, May 06, 2018 at 02:08:25PM -0500, Marty E. Plummer wrote: > > On Sun, May 06, 2018 at 08:39:23PM +0200, klaus.go...@theobroma-systems.com > > wrote: > > > On 06.05.2018, at 16:25, Marty E. Plummer wrote: > > > + * we use the 0x~0xfeff space >

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread Marty E. Plummer
On Sun, May 06, 2018 at 08:39:23PM +0200, klaus.go...@theobroma-systems.com wrote: > CC Philipp and Simon due maintainership (you may want to use > get_maintainer.pl in the future) > and Kever as the original author of the file. > > > On 06.05.2018, at 16:25, Marty E. Plummer

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

2018-05-06 Thread klaus . goger
CC Philipp and Simon due maintainership (you may want to use get_maintainer.pl in the future) and Kever as the original author of the file. > On 06.05.2018, at 16:25, Marty E. Plummer wrote: > > Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > Without this