Re: [U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards

2016-01-03 Thread Marek Vasut
On Sunday, January 03, 2016 at 03:56:01 PM, Stefano Babic wrote: > Hi Michael, > > some aditional comments before you will send V3: [...] > > diff --git a/board/i2se/duckbill/Makefile b/board/i2se/duckbill/Makefile > > new file mode 100644 > > index 000..b5577e3 > > --- /dev/null > > +++ b/b

Re: [U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards

2016-01-03 Thread Stefano Babic
Hi Michael, some aditional comments before you will send V3: On 13/12/2015 12:09, Michael Heimpold wrote: > Signed-off-by: Michael Heimpold This is the patch introducing a new board. It is not bad if you add some info in the commit message, for example which peripherals are already supported an

Re: [U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards

2015-12-13 Thread Marek Vasut
On Sunday, December 13, 2015 at 10:53:30 PM, Michael Heimpold wrote: > Hi Marek, Hi! > thanks for your review. My comments inline below. np :) > Am Sunday 13 December 2015, 16:40:14 schrieb Marek Vasut: > > On Sunday, December 13, 2015 at 12:09:58 PM, Michael Heimpold wrote: > > > > Commit mes

Re: [U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards

2015-12-13 Thread Michael Heimpold
Hi Marek, thanks for your review. My comments inline below. Am Sunday 13 December 2015, 16:40:14 schrieb Marek Vasut: > On Sunday, December 13, 2015 at 12:09:58 PM, Michael Heimpold wrote: > > Commit message describing the board would be real nice. > Ok, I'll add it in v3. [...] > > > > #de

Re: [U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards

2015-12-13 Thread Marek Vasut
On Sunday, December 13, 2015 at 12:09:58 PM, Michael Heimpold wrote: Commit message describing the board would be real nice. > Signed-off-by: Michael Heimpold > --- > > Please note, that this board setup files need the function > mxs_power_switch_dcdc_clocksource() as introduced in my patch > "