Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

2011-06-24 Thread Jason Hobbs
Dear Wolfgang, On Fri, Jun 24, 2011 at 07:18:55AM +0200, Wolfgang Denk wrote: > > +#ifdef CONFIG_MENU > > This being a new CONFIG_ variable, it must be documented in the > README. But as is this makes little sense, so I suggest you change > the order of your patches and add the abortboot support

Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

2011-06-24 Thread Jason Hobbs
Mike, On Thu, Jun 23, 2011 at 06:59:40PM -0400, Mike Frysinger wrote: > more ifdef trickery here than necessary: > #ifndef CONFIG_MENU > static inline > #endif > int abortboot(int bootdelay) > { Thanks - I'll change this in the next version of the patch. Jason _

Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

2011-06-23 Thread Wolfgang Denk
Dear "Jason Hobbs", In message <1308853655-12407-4-git-send-email-jason.ho...@calxeda.com> you wrote: > Signed-off-by: Jason Hobbs > --- > changes in v2: > - expose abortboot externally instead of using a wrapper > - expose abortboot externally when CONFIG_MENU is set > > common/main.c|

Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

2011-06-23 Thread Mike Frysinger
On Thursday, June 23, 2011 14:27:32 Jason Hobbs wrote: > +#ifdef CONFIG_MENU > +int abortboot(int bootdelay) > +#else > static __inline__ int abortboot(int bootdelay) > +#endif more ifdef trickery here than necessary: #ifndef CONFIG_MENU static inline #endif int ab