Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-12 Thread Marek Vasut
Dear Robert P. J. Day, > On Tue, 11 Dec 2012, Lukasz Majewski wrote: > > Hi Pantelis, > > > > > Tomorrow I will prepare output of USB Ellisys analizer on my side, so > > > we could get clue what is going on. > > > > Please find attached output from USB ellisys analizer. > > is it really appro

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-12 Thread Marek Vasut
Dear Lukasz Majewski, > Hi Pantelis, > > > Tomorrow I will prepare output of USB Ellisys analizer on my side, so > > we could get clue what is going on. > > Please find attached output from USB ellisys analizer. > > (It is possible to download WinXP based program to view logs without > USB anal

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-12 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/12/12 12:55, Marek Vasut wrote: > Dear Tom Rini, > >> On 12/10/12 19:47, Marek Vasut wrote: >>> Dear Lukasz Majewski, >>> Pantelis, >>> >>> [...] >>> >>> Hm hm ... I suspect it'd be nice to have a separate DFU >>> custodian. That'd lever

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-12 Thread Marek Vasut
Dear Tom Rini, > On 12/10/12 19:47, Marek Vasut wrote: > > Dear Lukasz Majewski, > > > >> Pantelis, > > > > [...] > > > > Hm hm ... I suspect it'd be nice to have a separate DFU custodian. > > That'd leverage some burden from me. I like that idea. I wonder if > > it'd be nice to start building

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-11 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/10/12 19:47, Marek Vasut wrote: > Dear Lukasz Majewski, > >> Pantelis, > [...] > > Hm hm ... I suspect it'd be nice to have a separate DFU custodian. > That'd leverage some burden from me. I like that idea. I wonder if > it'd be nice to start b

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-11 Thread Robert P. J. Day
On Tue, 11 Dec 2012, Lukasz Majewski wrote: > Hi Pantelis, > > > Tomorrow I will prepare output of USB Ellisys analizer on my side, so > > we could get clue what is going on. > > Please find attached output from USB ellisys analizer. is it really appropriate to post 8M of output to a mailing li

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-11 Thread Pantelis Antoniou
Hi Lukasz, I bet transmission is performed, but with the default settings of dfu. The DFU function descriptor is completely ignored. An easy way to verify it is to check if the DFU version of the device is the same one as the one stored in the descriptor. Same with the transmission block size. I

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-11 Thread Lukasz Majewski
Hi Lukasz, > Tomorrow I will prepare output of USB Ellisys analizer on my side, so > we could get clue what is going on. Since log itself waits for moderator approval, I will be more precise: 1. dfu-util version 0.1+svnexported 2. u-boot-denx master branch: SHA1: d987274e214cbfc7a56504fb3f0

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-11 Thread Wolfgang Denk
Dear Marek Vasut, In message <201212110147.49045.ma...@denx.de> you wrote: > > Hm hm ... I suspect it'd be nice to have a separate DFU custodian. That'd > leverage some burden from me. I like that idea. I wonder if it'd be nice to > start building such bigger net of custodians. I'm not sure abo

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-11 Thread Lukasz Majewski
Hi Marek, > Dear Lukasz Majewski, > > > Pantelis, > [...] > > Hm hm ... I suspect it'd be nice to have a separate DFU custodian. > That'd leverage some burden from me. I like that idea. I wonder if > it'd be nice to start building such bigger net of custodians. I think,that this (political) dec

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-10 Thread Marek Vasut
Dear Lukasz Majewski, > Pantelis, [...] Hm hm ... I suspect it'd be nice to have a separate DFU custodian. That'd leverage some burden from me. I like that idea. I wonder if it'd be nice to start building such bigger net of custodians. Hm ? Best regards, Marek Vasut __

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-10 Thread Lukasz Majewski
Pantelis, > Hi Lukasz, > > On Dec 10, 2012, at 7:11 PM, Lukasz Majewski wrote: > > > Hi Pantelis, > > > >> DFU is a bit peculiar. It needs to hook to composite setup and > >> return it's function descriptor. > >> > >> So when get-descriptor request comes with a type of DFU_DT_FUNC > >> we iter

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-10 Thread Pantelis Antoniou
Hi Lukasz, On Dec 10, 2012, at 7:11 PM, Lukasz Majewski wrote: > Hi Pantelis, > >> DFU is a bit peculiar. It needs to hook to composite setup and >> return it's function descriptor. >> >> So when get-descriptor request comes with a type of DFU_DT_FUNC >> we iterate over the configs, and functio

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-10 Thread Lukasz Majewski
Hi Pantelis, > DFU is a bit peculiar. It needs to hook to composite setup and > return it's function descriptor. > > So when get-descriptor request comes with a type of DFU_DT_FUNC > we iterate over the configs, and functions, and when we find > the DFU function we call the setup method which is