Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board

2013-01-24 Thread Wolfgang Denk
Dear Angelo Dureghello, In message <20130124200736.GA19171@sion.sysam> you wrote: > > > How big is your U-Boot image, then? I think it's a pretty long time > > since I haven't seen any image smaller than 128 kB... > > -rwxr-xr-x 1 angelo angelo 88556 gen 22 22:31 u-boot.bin Wow, that's jus

Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board

2013-01-24 Thread Angelo Dureghello
Dear Wolfgang, On Thu, Jan 24, 2013 at 07:24:11PM +0100, Wolfgang Denk wrote: > Dear Angelo Dureghello, > > In message <20130124161349.GA11311@sion.sysam> you wrote: > > > > > > +/* reserve 128-4KB */ > > > > +#define CONFIG_SYS_MONITOR_BASE(CONFIG_SYS_FLASH_BASE > > > > + 0x40

Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board

2013-01-24 Thread Wolfgang Denk
Dear Angelo Dureghello, In message <20130124161349.GA11311@sion.sysam> you wrote: > > > > +/* reserve 128-4KB */ > > > +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400) > > > +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024) > > > > Are you sure this is sufficient?

Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board

2013-01-24 Thread Angelo Dureghello
Dear Wolfgang, thanks for the review, will fix all points. > > > +/* reserve 128-4KB */ > > +#define CONFIG_SYS_MONITOR_BASE(CONFIG_SYS_FLASH_BASE + 0x400) > > +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024) > > Are you sure this is sufficient? For my board/case actually se

Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board

2013-01-24 Thread Wolfgang Denk
Dear Angelo Dureghello, In message <20130123145107.GA5565@sion.sysam> you wrote: > Add support for Sysam AMCORE mcf5307 (coldfire) based board. > > Signed-off-by: Angelo Dureghello > Cc: Jason Jin ... > > diff --git a/MAINTAINERS b/MAINTAINERS > index 28c052d..1d27cb7 100644 > --- a/MAINTAINERS