Re: rockchip: correctly set vop0 or vop1

2020-06-27 Thread Andy Yan
Hi : On 6/27/20 8:56 PM, Kever Yang wrote: +Andy Yan for this topic, Hi Patrick and Arnaud,     I would like to leave this patch until the code fits for all the socs, Thanks, - Kever On 2020/6/8 下午8:39, Patrick Wildt wrote: On Mon, Jun 08, 2020 at 02:24:32PM +0200, Arnaud Patard wrote:

Re: rockchip: correctly set vop0 or vop1

2020-06-27 Thread Kever Yang
On 2020/6/8 上午2:36, Patrick Wildt wrote: The EDP_LCDC_SEL bit has to be set correctly to select vop0 or vop1, but so far we have set it in both conditions, which is not correct. Can someone verify this is the correct way round? vop1 -> set, vop0 -> clear? Signed-off-by: Patrick Wildt I

Re: rockchip: correctly set vop0 or vop1

2020-06-27 Thread Kever Yang
+Andy Yan for this topic, Hi Patrick and Arnaud,     I would like to leave this patch until the code fits for all the socs, Thanks, - Kever On 2020/6/8 下午8:39, Patrick Wildt wrote: On Mon, Jun 08, 2020 at 02:24:32PM +0200, Arnaud Patard wrote: Patrick Wildt writes: On Mon, Jun 08, 2020

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Patrick Wildt
On Mon, Jun 08, 2020 at 02:24:32PM +0200, Arnaud Patard wrote: > Patrick Wildt writes: > > > On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote: > >> Patrick Wildt writes: > >> > >> Hi, > >> > >> > The EDP_LCDC_SEL bit has to be set correctly to select vop0 or > >> > vop1, but so

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Rtp
Patrick Wildt writes: > On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote: >> Patrick Wildt writes: >> >> Hi, >> >> > The EDP_LCDC_SEL bit has to be set correctly to select vop0 or >> > vop1, but so far we have set it in both conditions, which is not >> > correct. >> > >> > Can

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Patrick Wildt
On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote: > Patrick Wildt writes: > > Hi, > > > The EDP_LCDC_SEL bit has to be set correctly to select vop0 or > > vop1, but so far we have set it in both conditions, which is not > > correct. > > > > Can someone verify this is the correct

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Rtp
Patrick Wildt writes: Hi, > The EDP_LCDC_SEL bit has to be set correctly to select vop0 or > vop1, but so far we have set it in both conditions, which is not > correct. > > Can someone verify this is the correct way round? vop1 -> set, > vop0 -> clear? > > Signed-off-by: Patrick Wildt > >

rockchip: correctly set vop0 or vop1

2020-06-07 Thread Patrick Wildt
The EDP_LCDC_SEL bit has to be set correctly to select vop0 or vop1, but so far we have set it in both conditions, which is not correct. Can someone verify this is the correct way round? vop1 -> set, vop0 -> clear? Signed-off-by: Patrick Wildt diff --git a/drivers/video/rockchip/rk_edp.c