Re: [PATCH v3 03/20] drivers: reset: Handle gracefully NULL pointers

2021-05-04 Thread Kishon Vijay Abraham I
Hi Simon, On 04/05/21 10:28 pm, Simon Glass wrote: > Hi Kishon, > > On Tue, 4 May 2021 at 04:42, Kishon Vijay Abraham I wrote: >> >> The reset framework provides devm_reset_control_get_optional() >> which can return NULL (not an error case). So all the other reset_ops >> should handle NULL

Re: [PATCH v7 2/8] drivers: clk: add fu740 support

2021-05-04 Thread Green Wan
Thanks, I'll check the dependency. On Tue, May 4, 2021 at 5:54 PM Dimitri John Ledkov wrote: > > "Hi, > > On Thu, Apr 22, 2021 at 10:15 AM Green Wan wrote: > > > > Add fu740 support. One abstract layer is added for supporting > > multiple chips such as fu540 and fu740. > > > > Signed-off-by:

Re: [PATCH v7 8/8] drivers: net: macb: add fu740 support

2021-05-04 Thread Green Wan
Hi Dimitri, Thanks for looking into this. On Tue, May 4, 2021 at 5:33 PM Dimitri John Ledkov wrote: > > Hi, > > On Thu, Apr 22, 2021 at 10:15 AM Green Wan wrote: > > > > From: David Abdurachmanov > > > > Add fu740 support to macb ethernet driver > > > > There is a PLL HW quirk in FU740. The

Re: [RFC 1/2] net: net_up, net_down

2021-05-04 Thread Ramon Fried
On Mon, May 3, 2021 at 2:55 PM Ian Ray wrote: > > Calls made to eth_halt() by network operations (ping, nfs, tftp, etc.) > break netconsole if it is already running. > > * Maintain the network up / down state based on a reference count, > using new APIs net_up() and net_down(). > > Note that

Re: [PATCH 00/49] image: Reduce #ifdefs and ad-hoc defines in image code

2021-05-04 Thread Tom Rini
On Tue, May 04, 2021 at 07:24:25PM -0400, Sean Anderson wrote: > Hi Tom, > > On 5/4/21 5:40 PM, Tom Rini wrote: > > On Mon, May 03, 2021 at 05:10:47PM -0600, Simon Glass wrote: > > > > > Much of the image-handling code predates the introduction of Kconfig and > > > has quite a few #ifdefs in it.

Re: [PATCH 00/49] image: Reduce #ifdefs and ad-hoc defines in image code

2021-05-04 Thread Sean Anderson
Hi Tom, On 5/4/21 5:40 PM, Tom Rini wrote: On Mon, May 03, 2021 at 05:10:47PM -0600, Simon Glass wrote: Much of the image-handling code predates the introduction of Kconfig and has quite a few #ifdefs in it. It also uses its own IMAGE_... defines to help reduce the #ifdefs, which is

Re: [PATCH 4/4] malloc: Fix sbrk clearing memory after freeing it instead of before

2021-05-04 Thread Sean Anderson
On 5/4/21 11:26 AM, Simon Glass wrote: Hi Sean, On Sun, 2 May 2021 at 20:55, Sean Anderson wrote: This fixes memory being cleared after releasing it. Instead, clear memory before releasing it. In addition, suppress valgrind warnings about writing to free'd memory. Signed-off-by: Sean

Re: [PATCH 3/4] doc: sandbox: Document how to run sandbox with valgrind

2021-05-04 Thread Sean Anderson
On 5/4/21 11:26 AM, Simon Glass wrote: Hi Sean, On Sun, 2 May 2021 at 20:55, Sean Anderson wrote: This documents how to get more detailed results from valgrind made possible by the last two commits. Signed-off-by: Sean Anderson --- doc/arch/sandbox.rst | 14 ++ 1 file

[PATCH 1/5] arm: dts: k3-am642: Add ddr node

2021-05-04 Thread Dave Gerlach
Introduce ddr node for am642 needed for all ddr configurations. Also, introduce the 1600MTs DDR4 configuration that is supported on the am642-evm. Signed-off-by: Dave Gerlach --- arch/arm/dts/k3-am64-ddr.dtsi | 2205 arch/arm/dts/k3-am64-evm-ddr4-1600MTs.dtsi

Re: [PATCH 5/8] net: dwc_eth_qos: add dwc eqos for imx support

2021-05-04 Thread Daniil Stas
Hi, i think there are some issues with this patch. > @@ -1131,6 +1205,7 @@ static int eqos_start(struct udevice *dev) > } > > /* Configure MTL */ > + writel(0x60, >mtl_regs->txq0_quantum_weight - 0x100); > > /* Enable Store and Forward mode for TX */ > /* Program

Re: [PATCH 00/49] image: Reduce #ifdefs and ad-hoc defines in image code

2021-05-04 Thread Simon Glass
Hi Tom, On Tue, 4 May 2021 at 15:40, Tom Rini wrote: > > On Mon, May 03, 2021 at 05:10:47PM -0600, Simon Glass wrote: > > > Much of the image-handling code predates the introduction of Kconfig and > > has quite a few #ifdefs in it. It also uses its own IMAGE_... defines to > > help reduce the

Re: [PATCH 00/49] image: Reduce #ifdefs and ad-hoc defines in image code

2021-05-04 Thread Tom Rini
On Mon, May 03, 2021 at 05:10:47PM -0600, Simon Glass wrote: > Much of the image-handling code predates the introduction of Kconfig and > has quite a few #ifdefs in it. It also uses its own IMAGE_... defines to > help reduce the #ifdefs, which is unnecessary now that we can use > IS_ENABLED() et

[PATCH 2/5] arm: mach-k3: am642: Add support for triggering ddr init from SPL

2021-05-04 Thread Dave Gerlach
In SPL, DDR should be made available by the end of board_init_f() so that apis in board_init_r() can use ddr. Adding support for triggering DDR initialization from board_init_f(). Signed-off-by: Dave Gerlach --- arch/arm/mach-k3/am642_init.c | 6 ++ board/ti/am64x/Kconfig| 3 +++ 2

[PATCH 0/5] arm: mach-k3: k3-am64: Add DDR configuration and enable

2021-05-04 Thread Dave Gerlach
This series adds the required configuration needed to use the new common k3-ddrss driver on am64 and also adds the required dts data needed to enable DDR usage on the k3-am642-evm platform. This series depends on the AM64 base support series [1] and the Common K3 DDRSS series here [2]. Regards,

[PATCH 5/5] configs: am64x_evm_r5: Enable GPIO regulator

2021-05-04 Thread Dave Gerlach
From: Nishanth Menon Enable GPIO regulator. Signed-off-by: Nishanth Menon Signed-off-by: Dave Gerlach --- configs/am64x_evm_r5_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs/am64x_evm_r5_defconfig b/configs/am64x_evm_r5_defconfig index

[PATCH 3/5] arm: dts: k3-am64-main: Add GPIO nodes

2021-05-04 Thread Dave Gerlach
From: Nishanth Menon Add main domain GPIO nodes. Signed-off-by: Nishanth Menon Signed-off-by: Dave Gerlach --- arch/arm/dts/k3-am64-main.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm/dts/k3-am64-main.dtsi

[PATCH 4/5] arm: dts: k3-am642-r5-evm: Add GPIO DDR VTT regulator

2021-05-04 Thread Dave Gerlach
From: Nishanth Menon Add DDR VTT regulator. Signed-off-by: Nishanth Menon Signed-off-by: Dave Gerlach --- arch/arm/dts/k3-am642-r5-evm.dts | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/dts/k3-am642-r5-evm.dts b/arch/arm/dts/k3-am642-r5-evm.dts

Re: [PATCH v1 00/23] phy: marvell: Sync Armada 3k/7k/8k SERDES code with Marvell version

2021-05-04 Thread Pali Rohár
On Thursday 29 April 2021 11:00:17 Stefan Roese wrote: > Hi Marek, > > (Added Tom and Simon to Cc) > > On 29.04.21 10:27, Marek Behun wrote: > > On Thu, 29 Apr 2021 08:46:36 +0200 > > Stefan Roese wrote: > > > > > > phy: marvell: add RX training command > > > > > > Applied to

Re: Weirdness of ofnode_get_addr_size()

2021-05-04 Thread Jan Kiszka
On 04.05.21 22:01, Dario Binacchi wrote: > Hi Jan, > >> Il 04/05/2021 17:26 Simon Glass ha scritto: >> >> >> Hi Jan, >> >> On Sun, 2 May 2021 at 01:53, Jan Kiszka wrote: >>> >>> Hi, >>> >>> I'm trying to make some sense of ofnode_get_addr_size() in order to fix >>> [1] properly. >>> >>> First,

RE: [PATCH] cli: Fix command line underrun

2021-05-04 Thread Wang, Peng
Please discard this patch. I reviewed this patch and noticed that it forgot to take care the *np. The test that was performed may be incomplete. On the other hand, it's strange that the cursor can be moved back beyond the prompt while it should be stopped by the "if (*np == 0)" check. Since we

Re: Weirdness of ofnode_get_addr_size()

2021-05-04 Thread Dario Binacchi
Hi Jan, > Il 04/05/2021 17:26 Simon Glass ha scritto: > > > Hi Jan, > > On Sun, 2 May 2021 at 01:53, Jan Kiszka wrote: > > > > Hi, > > > > I'm trying to make some sense of ofnode_get_addr_size() in order to fix > > [1] properly. > > > > First, the documentation if this functions says "This

Re: [RFC 4/7] pinctrl: mscc: Fix multiple definition error

2021-05-04 Thread Daniel Schwierzeck
Am Montag, den 03.05.2021, 16:48 -0400 schrieb Tom Rini: > With gcc-11 we get a multiple errors here as the declarations for > mscc_pinctrl_ops and mscc_gpio_ops are missing an extern. > > CC: Gregory CLEMENT > Cc: Lars Povlsen > Cc: Horatiu Vultur > Signed-off-by: Tom Rini > --- >

Re: [PATCH] pinctrl: mscc: fix multiple definitions

2021-05-04 Thread Daniel Schwierzeck
Am Dienstag, den 04.05.2021, 14:45 -0400 schrieb Tom Rini: > On Tue, May 04, 2021 at 08:40:40PM +0200, Daniel Schwierzeck wrote: > > > gcc-11 complains about multiple definitions: > > > > /opt/gcc-11.0.20210426-nolibc/mips-linux/bin/mips-linux-ld.bfd: > >

Re: [PATCH] pinctrl: mscc: fix multiple definitions

2021-05-04 Thread Tom Rini
On Tue, May 04, 2021 at 08:40:40PM +0200, Daniel Schwierzeck wrote: > gcc-11 complains about multiple definitions: > > /opt/gcc-11.0.20210426-nolibc/mips-linux/bin/mips-linux-ld.bfd: > drivers/pinctrl/mscc/pinctrl-ocelot.o:drivers/pinctrl/mscc/mscc-common.h:64: > multiple definition of

[PATCH] pinctrl: mscc: fix multiple definitions

2021-05-04 Thread Daniel Schwierzeck
gcc-11 complains about multiple definitions: /opt/gcc-11.0.20210426-nolibc/mips-linux/bin/mips-linux-ld.bfd: drivers/pinctrl/mscc/pinctrl-ocelot.o:drivers/pinctrl/mscc/mscc-common.h:64: multiple definition of `mscc_pinctrl_ops';

[PATCH v5 10/10] am335x: add support for cape detect functionality

2021-05-04 Thread Kory Maincent
Update the Kconfig and the board file to make the am335x board compatible with cape detection. Signed-off-by: Kory Maincent --- Change Since v1: - Remove CAPE_EEPROM_BUS_NUM from board header arch/arm/mach-omap2/am33xx/Kconfig | 1 + board/ti/am335x/board.c| 1 + 2 files changed,

[PATCH v5 09/10] arm: am335x: add support for i2c2 bus

2021-05-04 Thread Kory Maincent
The am335x from BeagleBone use i2c EEPROM to detect capes. The memory is wired to i2c bus 2 therefore it need to be enabled. Add i2c2 clock, pinmux description and pinmux enable function. Signed-off-by: Kory Maincent --- arch/arm/mach-omap2/am33xx/clock_am33xx.c | 1 + board/ti/am335x/board.c

[PATCH v5 07/10] arm: sunxi: add support for DIP detection to CHIP board

2021-05-04 Thread Kory Maincent
Add the extension_board_scan specific function to scan the information of the EEPROM on one-wire and fill the extension struct. Add the Kconfig symbol to enable the needs to detect DIPs. Signed-off-by: Kory Maincent Reviewed-by: Maxime Ripard --- Change since v1: - Replace TARGET_CHIP options

[PATCH v5 06/10] w1: replace dt detection by automatic detection

2021-05-04 Thread Kory Maincent
This patch changes the functioning of the detection of w1 devices. The old way was a comparison between detected w1 and the ones described in the device tree. Now it will just look for the driver matching the family id of the w1 detected. The patch is inspired from Maxime Ripard code.

[PATCH v5 08/10] configs: CHIP: add support for DIP detect functionality

2021-05-04 Thread Kory Maincent
This commit enables using the extension board detection mechanism on CHIP boards Signed-off-by: Kory Maincent Acked-by: Maxime Ripard --- configs/CHIP_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig index a70ee31d40..8d40da090b

[PATCH v5 05/10] am57xx: add support for cape detect functionality

2021-05-04 Thread Kory Maincent
This commit enables using the extension board detection mechanism on AM57xx based platforms. Signed-off-by: Kory Maincent --- Change Since v1: - Remove CAPE_EEPROM_BUS_NUM from the header arch/arm/mach-omap2/omap5/Kconfig | 1 + board/ti/am57xx/board.c | 1 + 2 files changed, 2

[PATCH v5 02/10] cmd: add support for a new "extension" command

2021-05-04 Thread Kory Maincent
This patch adds a new "extension" command, which aims at detecting extension boards connected to the hardware platform, and apply the Device Tree overlays that describe the hardware present on those extension boards. In order to enable this mechanism, board-specific code must implement the

[PATCH v5 04/10] ti/common: add support for extension_scan_board function

2021-05-04 Thread Kory Maincent
The BeagleBone platforms all use a common mechanism to discover and identify extension boards (called "capes"): each extension board has an I2C-connected EEPROM describing itself. This patch implements a generic extension_scan_board() feature that can be used by all BeagleBone platforms to read

[PATCH v5 03/10] pytest: add sandbox test for "extension" command

2021-05-04 Thread Kory Maincent
This commit extends the sandbox to implement a dummy extension_board_scan() function and enables the extension command in the sandbox configuration. It then adds a test that checks the proper functionality of the extension command by applying two Device Tree overlays to the sandbox Device Tree.

[PATCH v5 01/10] fdt_support: move fdt_valid from cmd_fdt.c to fdt_support.c

2021-05-04 Thread Kory Maincent
Move the fdt_valid function to fdt_support. This changes allow to be able to test the validity of a devicetree in other c files. Update code syntax. Signed-off-by: Kory Maincent Reviewed-by: Tom Rini Reviewed-by: Maxime Ripard --- cmd/fdt.c | 49

[PATCH v5 00/10] Add support for extension boards detection and DT overlays application

2021-05-04 Thread Kory Maincent
This series of patches aims at proposing a generic U-Boot mechanism to detect extension boards connected to the HW platform, and apply the appropriate Device Tree overlays depending on the detected extension boards. Indeed, numerous popular platforms, such as the BeagleBone or the RaspberryPi,

Re: [PATCH v4 2/6] lib: ecdsa: Add skeleton to implement ecdsa verification in u-boot

2021-05-04 Thread Simon Glass
Hi Alex, On Thu, 29 Apr 2021 at 10:10, Simon Glass wrote: > > Hi Alex, > > On Mon, 26 Apr 2021 at 07:21, Alex G. wrote: > > > > > > > > On 4/23/21 11:56 PM, Simon Glass wrote: > > > Hi Tom, Alex, > > > > > > On Fri, 23 Apr 2021 at 12:47, Tom Rini wrote: > > >> > > >> On Fri, Apr 23, 2021 at

Re: [PATCH 04/49] btrfs: Use U-Boot API for decompression

2021-05-04 Thread Simon Glass
Hi Marek, On Mon, 3 May 2021 at 17:45, Marek Behun wrote: > > On Mon, 3 May 2021 17:10:51 -0600 > Simon Glass wrote: > > > Use the common function to avoid code duplication. > > > > Signed-off-by: Simon Glass > > Is this tested? Why only zstd? No, there are no tests for zstd, as I mentioned

Re: [PATCH v3] dm: core: Add address translation in fdt_get_resource

2021-05-04 Thread Simon Glass
On Tue, 4 May 2021 at 04:02, Patrick Delaunay wrote: > > Today of_address_to_resource() is called only in > ofnode_read_resource() for livetree support and > fdt_get_resource() is called when livetree is not supported. > > The fdt_get_resource() doesn't do the address translation > so when it is

Re: [PATCH v3 03/20] drivers: reset: Handle gracefully NULL pointers

2021-05-04 Thread Simon Glass
Hi Kishon, On Tue, 4 May 2021 at 04:42, Kishon Vijay Abraham I wrote: > > The reset framework provides devm_reset_control_get_optional() > which can return NULL (not an error case). So all the other reset_ops > should handle NULL gracefully. Prepare the way for a managed reset > API by handling

Re: [PATCH v3 01/20] dm: core: Add helper to compare node names

2021-05-04 Thread Simon Glass
Hi, On Tue, 4 May 2021 at 04:42, Kishon Vijay Abraham I wrote: > > Add helper to compare node names. > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/core/ofnode.c | 13 + > include/dm/ofnode.h | 10 ++ > 2 files changed, 23 insertions(+) Is there no change to

Re: [PATCH 03/17] x86: Allow coreboot serial driver to guess the UART

2021-05-04 Thread Andy Shevchenko
On Tue, May 04, 2021 at 09:26:19AM -0600, Simon Glass wrote: > On Fri, 30 Apr 2021 at 12:41, Andy Shevchenko > wrote: > > On Fri, Apr 30, 2021 at 9:14 PM Simon Glass wrote: > > > On Thu, 29 Apr 2021 at 17:01, Bin Meng wrote: > > > > On Fri, Apr 30, 2021 at 12:10 AM Simon Glass wrote: > > > >

Re: Unable to boot u-boot image from nand storage imx6ull.

2021-05-04 Thread Tim Harvey
On Tue, May 4, 2021 at 9:28 AM Navin Sankar wrote: > > On 04/05/21 8:49 pm, Tim Harvey wrote: > > On Sat, May 1, 2021 at 2:32 AM Navin Sankar wrote: > > Hello all, > > Ported uboot to seeed studio based imx6ull board. > > NAND Part Number - mt29f4g08abaeawp > > NAND Size - 512

Re: Unable to boot u-boot image from nand storage imx6ull.

2021-05-04 Thread Navin Sankar
On 04/05/21 8:49 pm, Tim Harvey wrote: On Sat, May 1, 2021 at 2:32 AM Navin Sankar wrote: Hello all, Ported uboot to seeed studio based imx6ull board. NAND Part Number - mt29f4g08abaeawp NAND Size - 512 MBytes Both the SPL and U-BOOT image boot successfully from SD card.

Re: [PATCH 2/4] malloc: Annotate allocator for valgrind

2021-05-04 Thread Simon Glass
On Sun, 2 May 2021 at 20:55, Sean Anderson wrote: > > This annotates malloc and friends so that valgrind can track the heap. To > do this, we need to follow a few rules: > > * Call VALGRIND_MALLOCLIKE_BLOCK whenever we malloc something > * Call VALGRIND_FREELIKE_BLOCK whenever we free something

Re: [PATCH 1/4] Add valgrind headers to U-Boot

2021-05-04 Thread Simon Glass
On Sun, 2 May 2021 at 20:55, Sean Anderson wrote: > > Valgrind uses magic code sequences to define an ABI that the client may use > to request behavior from the host. In particular, this may be used to > inform valgrind about custom allocators, such as the one used in U-Boot. > > This adds

Re: [PATCH 3/4] doc: sandbox: Document how to run sandbox with valgrind

2021-05-04 Thread Simon Glass
Hi Sean, On Sun, 2 May 2021 at 20:55, Sean Anderson wrote: > > This documents how to get more detailed results from valgrind made possible > by the last two commits. > > Signed-off-by: Sean Anderson > --- > > doc/arch/sandbox.rst | 14 ++ > 1 file changed, 10 insertions(+), 4

Re: [PATCH 03/17] x86: Allow coreboot serial driver to guess the UART

2021-05-04 Thread Simon Glass
Hi Bin and Andy, On Fri, 30 Apr 2021 at 12:41, Andy Shevchenko wrote: > > On Fri, Apr 30, 2021 at 9:14 PM Simon Glass wrote: > > On Thu, 29 Apr 2021 at 17:01, Bin Meng wrote: > > > On Fri, Apr 30, 2021 at 12:10 AM Simon Glass wrote: > > > > On Sun, 25 Apr 2021 at 18:21, Bin Meng wrote: > > >

Re: [PATCH] Makefile: allow to override python3

2021-05-04 Thread Simon Glass
On Sat, 1 May 2021 at 14:13, Andrey Zhizhikin wrote: > > Python3 taken from the PATH causes build issues when pylibfdt bindings are > generated with Yocto SDK. > > Python3 provided as a part of SDK is not compatible with host Python3, > therefore binding build breaks with following errors: > >

Re: Weirdness of ofnode_get_addr_size()

2021-05-04 Thread Simon Glass
Hi Jan, On Sun, 2 May 2021 at 01:53, Jan Kiszka wrote: > > Hi, > > I'm trying to make some sense of ofnode_get_addr_size() in order to fix > [1] properly. > > First, the documentation if this functions says "This does no address > translation". But the node-pointer path happily calls >

Re: [PATCH 4/4] malloc: Fix sbrk clearing memory after freeing it instead of before

2021-05-04 Thread Simon Glass
Hi Sean, On Sun, 2 May 2021 at 20:55, Sean Anderson wrote: > > This fixes memory being cleared after releasing it. Instead, clear memory > before releasing it. In addition, suppress valgrind warnings about writing > to free'd memory. > > Signed-off-by: Sean Anderson > --- > > common/dlmalloc.c

Re: [PATCH v1 1/6] lib: add crypt subsystem

2021-05-04 Thread Simon Glass
Hi Steffen, On Sat, 1 May 2021 at 03:51, Steffen Jaeckel wrote: > > Hi Simon, > > On 4/29/21 6:10 PM, Simon Glass wrote: > >> diff --git a/include/crypt.h b/include/crypt.h > >> new file mode 100644 > >> index 00..e0be2832ff > >> --- /dev/null > >> +++ b/include/crypt.h > >> @@ -0,0

Re: Unable to boot u-boot image from nand storage imx6ull.

2021-05-04 Thread Tim Harvey
On Sat, May 1, 2021 at 2:32 AM Navin Sankar wrote: > > Hello all, > > Ported uboot to seeed studio based imx6ull board. > > NAND Part Number - mt29f4g08abaeawp > > NAND Size - 512 MBytes > > Both the SPL and U-BOOT image boot successfully from SD card. > > While with nand flash,

Re: [PATCH v2] cmd: gpt: Add option to write GPT partitions to environment variable

2021-05-04 Thread Heinrich Schuchardt
On 5/3/21 9:29 PM, Farhan Ali wrote: > Hi Heinrich, > > I was wondering if there are any other changes necessary? Nothing on my side. The patch was reviewed by Simon and now is is assigned to Tom. https://patchwork.ozlabs.org/project/uboot/patch/20210226181733.19307-1-farhan@broadcom.com/

Re: [PATCH] ARM: stm32: Enable UNZIP on DHSOM by default

2021-05-04 Thread Patrick DELAUNAY
Hi, On 5/3/21 1:31 PM, Marek Vasut wrote: The CMD_UNZIP provides the 'gzwrite' command, which is convenient for writing e.g. gz-compressed images to eMMC from U-Boot. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay --- configs/stm32mp15_dhcom_basic_defconfig | 1 +

Re: [PATCH] ARM: stm32: Add additional ID register check for KSZ8851 presence

2021-05-04 Thread Patrick DELAUNAY
Hi, On 5/3/21 1:31 PM, Marek Vasut wrote: Currently the code sets eth1addr only if /ethernet1 alias exists in DT, the node pointed to by the alias has "micrel,ks8851-mll" compatible string, and the KSZ8851 CCR register read indicates programmed EEPROM is not connected. This is not sufficient

Re: [Uboot-stm32] [PATCH] arm: dts: stm32mp157c-odyssey-som: enable the RNG1

2021-05-04 Thread Patrick DELAUNAY
Hi, On 4/19/21 7:55 PM, Grzegorz Szymaszek wrote: Enable the true random number generator. It can be used, for example, to generate partition UUIDs when partitioning with the gpt command. The generator is already enabled in the device trees of several other STM32MP1‐based boards, like DKx or

Re: [PATCH] reset: stm32: Fix bank and offset computation

2021-05-04 Thread Patrick DELAUNAY
Hi Patrice, On 4/28/21 1:42 PM, Patrice Chotard wrote: BITS_PER_LONG is used to represent register's size which is 32. But when compiled on arch64, BITS_PER_LONG is then equal to 64. Fix bank and offset computation to make it work on arch32 and arch64 and ensure that register's size is always

Re: [PATCH v3 5/7] image-fdt: save no-map parameter of reserve-memory

2021-05-04 Thread Patrick DELAUNAY
Hi Simon, On 4/29/21 6:10 PM, Simon Glass wrote: Hi Patrick, On Wed, 28 Apr 2021 at 03:23, Patrick Delaunay wrote: Save the no-map information present in 'reserved-memory' node to allow correct handling when the MMU is configured in board to avoid speculative access. Signed-off-by: Patrick

Re: [PATCH v3 2/7] lmb: add lmb_is_reserved_flags

2021-05-04 Thread Patrick DELAUNAY
On 4/29/21 6:10 PM, Simon Glass wrote: Hi Patrick, On Wed, 28 Apr 2021 at 03:23, Patrick Delaunay wrote: Add a new function lmb_is_reserved_flags to check is a address is reserved with a specific flags. This function can be used to check if an address was reserved with no-map flags with:

Re: [PATCH v4 00/10] Add support for extension boards detection and DT overlays application

2021-05-04 Thread Tom Rini
On Tue, Apr 20, 2021 at 10:25:31AM +0200, Kory Maincent wrote: > This series of patches aims at proposing a generic U-Boot mechanism to > detect extension boards connected to the HW platform, and apply the > appropriate Device Tree overlays depending on the detected extension > boards. > >

Re: squashfs tests flaky?

2021-05-04 Thread Tom Rini
On Tue, May 04, 2021 at 04:31:57PM +0530, Pratyush Yadav wrote: > Hi, > > I am playing around with the U-Boot CI, mostly to make sure my patches > don't break things. To that end I created a fork of u-boot on GitLab and > started the CI pipeline on the current master (8ddaf94358). > > I see

Re: [RFC 4/7] pinctrl: mscc: Fix multiple definition error

2021-05-04 Thread Horatiu Vultur
The 05/03/2021 16:48, Tom Rini wrote: > > With gcc-11 we get a multiple errors here as the declarations for > mscc_pinctrl_ops and mscc_gpio_ops are missing an extern. Reviewed-by: Horatiu Vultur > > CC: Gregory CLEMENT > Cc: Lars Povlsen > Cc: Horatiu Vultur > Signed-off-by: Tom Rini >

Re: [PATCH] cmd: pxe_utils: sysboot: fix crash if either board or soc are not set.

2021-05-04 Thread Dimitri John Ledkov
Hi qemu-board meaintainers, The below patch affects any boards that do not have either board or soc variables set. Of which non-x86 qemu boards are exactly that, preventing to netboot the same rootfs across multiple boards and qemu at the same time. Another alternative would be for all non-x86

Re: [PATCH v7 2/8] drivers: clk: add fu740 support

2021-05-04 Thread Dimitri John Ledkov
(resending to the list after subscribing) Hi, On Thu, Apr 22, 2021 at 10:15 AM Green Wan wrote: > > Add fu740 support. One abstract layer is added for supporting > multiple chips such as fu540 and fu740. > > Signed-off-by: Green Wan > --- > drivers/clk/sifive/Kconfig | 8 +- >

Re: [PATCH v7 1/8] riscv: cpu: fu740: Add support for cpu fu740

2021-05-04 Thread Dimitri John Ledkov
(resending to the list after subscribing) Hi, On Thu, Apr 22, 2021 at 10:14 AM Green Wan wrote: > > Add SiFive fu740 cpu to support RISC-V arch > > Signed-off-by: Green Wan > Reviewed-by: Bin Meng > --- > arch/riscv/Kconfig| 1 + > arch/riscv/cpu/fu740/Kconfig

Re: [PATCH v7 8/8] drivers: net: macb: add fu740 support

2021-05-04 Thread Dimitri John Ledkov
(resending to list after subscribing) Hi, On Thu, Apr 22, 2021 at 10:15 AM Green Wan wrote: > > From: David Abdurachmanov > > Add fu740 support to macb ethernet driver > > There is a PLL HW quirk in FU740. The VSC8541XMV-02 specification > requires 125 +/-0.0125 Mhz. But the most close value

[PATCH] cli: slighly more clear error messages

2021-05-04 Thread Wang, Peng
>From e8a2f8a7098f4b18bbbf859ca7c765ebfcd944b0 Mon Sep 17 00:00:00 2001 From: "peng.w...@smartm.com" Date: Tue, 4 May 2021 01:45:59 -0700 Subject: [PATCH] cli: slighly more clear error messages This patch tries to distinguish two error messages. Signed-off-by: peng.w...@smartm.com ---

[PATCH] cli: Fix non-printable character handling

2021-05-04 Thread Wang, Peng
>From 8919b7cf69575773ce7140a5412d0547a26bb8e6 Mon Sep 17 00:00:00 2001 From: "peng.w...@smartm.com" Date: Tue, 4 May 2021 01:13:31 -0700 Subject: [PATCH] cli: Fix non-printable character handling This patch converts unhandled non-printable character to a beep without putting it into the buffer.

[PATCH] cli: Fix command line underrun

2021-05-04 Thread Wang, Peng
>From 7a3110962cd1482793a9912fa14e5d9961e9f01a Mon Sep 17 00:00:00 2001 From: "peng.w...@smartm.com" Date: Mon, 3 May 2021 23:53:29 -0700 Subject: [PATCH] cli: Fix command line underrun This patch adds a column position check to fix the cli issue that backspace doesn't stop at the prompt.

squashfs tests flaky?

2021-05-04 Thread Pratyush Yadav
Hi, I am playing around with the U-Boot CI, mostly to make sure my patches don't break things. To that end I created a fork of u-boot on GitLab and started the CI pipeline on the current master (8ddaf94358). I see on the official repo the job passes [0]. But on my fork, the job fails due to

[PATCH v3 20/20] configs: j7200_evm_a72: Enhance bootcmd to configure ethernet PHY

2021-05-04 Thread Kishon Vijay Abraham I
Update the default BOOTCOMMAND to provide an automatic and easier way to configure ethernet PHY before loading the firmware. Signed-off-by: Kishon Vijay Abraham I --- configs/j7200_evm_a72_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 19/20] env: ti: j721e-evm: Add env variable to power on & reset QSGMII PHY in J7200 EVM

2021-05-04 Thread Kishon Vijay Abraham I
MAIN CPSW0 requires the PHY to be powered on and reset for QSGMII operation. Add a env variable to configure driving "0" on ENET_EXP_PWRDN controlled by GPIO EXPANDER2 (I2C Addr: 0x22), PIN: 17 and driving "1" on ENET_EXP_RESETZ controlled by GPIO EXPANDER2 (I2C Addr: 0x22), PIN: 18.

[PATCH v3 18/20] configs: j7200_evm_a72_defconfig: Add config for torrent serdes and common clock framework

2021-05-04 Thread Kishon Vijay Abraham I
From: Aswath Govindraju Add config for torrent serdes and common clock framework. Signed-off-by: Aswath Govindraju Signed-off-by: Kishon Vijay Abraham I --- configs/j7200_evm_a72_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configs/j7200_evm_a72_defconfig

[PATCH v3 17/20] configs: j721e_evm_a72: Enable the drivers required for the USB3 support

2021-05-04 Thread Kishon Vijay Abraham I
From: Jean-Jacques Hiblot Enable the mmio mux driver, the J721E-wiz PHy driver and the cadence sierra phy driver. All of them are required for USB3 support Signed-off-by: Jean-Jacques Hiblot Signed-off-by: Vignesh Raghavendra Signed-off-by: Kishon Vijay Abraham I ---

[PATCH v3 16/20] arm: dts: k3-j7200-common-proc-board-u-boot: Add u-boot tags for torrent serdes

2021-05-04 Thread Kishon Vijay Abraham I
From: Aswath Govindraju Add u-boot tags for torrent serdes. Signed-off-by: Aswath Govindraju Signed-off-by: Kishon Vijay Abraham I --- arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v3 15/20] arm: dts: k3-j7200-common-proc-board: Enable SERDES DT

2021-05-04 Thread Kishon Vijay Abraham I
From: Aswath Govindraju Add default lane function for torrent serdes. Signed-off-by: Aswath Govindraju Signed-off-by: Kishon Vijay Abraham I --- arch/arm/dts/k3-j7200-common-proc-board.dts | 23 + 1 file changed, 23 insertions(+) diff --git

[PATCH v3 14/20] arm: dts: k3-j7200-main: Add DT node for torrent serdes

2021-05-04 Thread Kishon Vijay Abraham I
From: Aswath Govindraju Add DT node for torrent serdes. Signed-off-by: Aswath Govindraju Signed-off-by: Kishon Vijay Abraham I --- arch/arm/dts/k3-j7200-main.dtsi | 63 + 1 file changed, 63 insertions(+) diff --git a/arch/arm/dts/k3-j7200-main.dtsi

[PATCH v3 13/20] ARM: dts: k3-j721e: Add the entries required for USB3 support on USB0

2021-05-04 Thread Kishon Vijay Abraham I
Partially sync with Linux's dts to add the entries required for USB3 support on USB0. Note that the default mode is still "peripheral" not "host". USB3 is supported only for the host mode. Signed-off-by: Jean-Jacques Hiblot Signed-off-by: Vignesh Raghavendra Signed-off-by: Kishon Vijay Abraham

[PATCH v3 12/20] board: ti: j721e: Add support for probing and configuring Torrent serdes on J7200

2021-05-04 Thread Kishon Vijay Abraham I
From: Aswath Govindraju Add support for probing and configuring Torrent serdes on J7200. Signed-off-by: Aswath Govindraju Signed-off-by: Kishon Vijay Abraham I --- board/ti/j721e/evm.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH v3 10/20] phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC

2021-05-04 Thread Kishon Vijay Abraham I
From: Jean-Jacques Hiblot Add support for WIZ module present in TI's J721E SoC. WIZ is a SERDES wrapper used to configure some of the input signals to the SERDES. It is used with both Sierra(16G) and Torrent(10G) SERDES. This driver configures three clock selects (pll0, pll1, dig) and supports

[PATCH v3 11/20] usb: cdns3: cdns3-ti: Fix clk_get_by_name() to get the correct name

2021-05-04 Thread Kishon Vijay Abraham I
Upstream device tree got updated to use clock name as "ref" instead of "usb2_refclk". Fix cdns3-ti.c to use the correct name. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/cdns3/cdns3-ti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/cdns3/cdns3-ti.c

[PATCH v3 09/20] phy: cadence: Add driver for Torrent SERDES

2021-05-04 Thread Kishon Vijay Abraham I
From: Aswath Govindraju Add driver for Torrent SERDES. Signed-off-by: Aswath Govindraju Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/Kconfig |6 + drivers/phy/cadence/Makefile |1 + drivers/phy/cadence/phy-cadence-torrent.c | 2468

[PATCH v3 08/20] phy: cadence: Add driver for Sierra PHY

2021-05-04 Thread Kishon Vijay Abraham I
From: Alan Douglas Add a Sierra PHY driver with PCIe and USB support. This driver is a port from the mainline linux driver. The PHY has multiple lanes, which can be configured into groups, and a generic PHY device is created for each group. There are two resets controlling the overall PHY

[PATCH v3 07/20] dt-bindings: ti-serdes-mux: Add defines for AM64 SoC

2021-05-04 Thread Kishon Vijay Abraham I
AM64 has a single lane SERDES which can be configured to be used with either PCIe or USB. Define the possilbe values for the SERDES function in AM64 SoC here. Signed-off-by: Kishon Vijay Abraham I --- include/dt-bindings/mux/ti-serdes.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v3 06/20] dt-bindings: phy: cadence-torrent: Add defines for refclk driver

2021-05-04 Thread Kishon Vijay Abraham I
Add defines for refclk driver used to route the refclk out of torrent SERDES. Signed-off-by: Kishon Vijay Abraham I --- include/dt-bindings/phy/phy-cadence.h | 20 1 file changed, 20 insertions(+) create mode 100644 include/dt-bindings/phy/phy-cadence.h diff --git

[PATCH v3 05/20] dt-bindings: phy: Add defines for AM64 SERDES Wrapper

2021-05-04 Thread Kishon Vijay Abraham I
Add defines for AM64 SERDES Wrapper. Signed-off-by: Kishon Vijay Abraham I --- include/dt-bindings/phy/phy-ti.h | 21 + 1 file changed, 21 insertions(+) create mode 100644 include/dt-bindings/phy/phy-ti.h diff --git a/include/dt-bindings/phy/phy-ti.h

[PATCH v3 04/20] dt-bindings: phy: Add definitions for additional phy types

2021-05-04 Thread Kishon Vijay Abraham I
From: Aswath Govindraju Add definitions for additional phy types that's used specifically for Torrent SERDES. Signed-off-by: Aswath Govindraju Signed-off-by: Kishon Vijay Abraham I --- include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 03/20] drivers: reset: Handle gracefully NULL pointers

2021-05-04 Thread Kishon Vijay Abraham I
The reset framework provides devm_reset_control_get_optional() which can return NULL (not an error case). So all the other reset_ops should handle NULL gracefully. Prepare the way for a managed reset API by handling NULL pointers without crashing nor failing. Signed-off-by: Vignesh Raghavendra

[PATCH v3 00/20] TI/Cadence: Add Sierra/Torrent SERDES driver

2021-05-04 Thread Kishon Vijay Abraham I
Patch series adds Sierra and Torrent SERDES driver for the SERDES used in TI's K3 platforms. This SERDES is used by USB3, PCIe and Ethernet. This series is mostly an adaptation of drivers added in upstream Linux kernel. Changes from v2: 1) Re-worked "Handle gracefully NULL pointers" to fix Simons

[PATCH v3 02/20] dm: test: Add test case to check node name ignoring unit address

2021-05-04 Thread Kishon Vijay Abraham I
Add test to check node name ignoring unit address. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Simon Glass --- test/dm/core.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/test/dm/core.c b/test/dm/core.c index 2210345dd1..e83f71f767 100644 --- a/test/dm/core.c +++

[PATCH v3 01/20] dm: core: Add helper to compare node names

2021-05-04 Thread Kishon Vijay Abraham I
Add helper to compare node names. Signed-off-by: Kishon Vijay Abraham I --- drivers/core/ofnode.c | 13 + include/dm/ofnode.h | 10 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index d5058e..2a5b12040c 100644 ---

[PATCH v3] dm: core: Add address translation in fdt_get_resource

2021-05-04 Thread Patrick Delaunay
Today of_address_to_resource() is called only in ofnode_read_resource() for livetree support and fdt_get_resource() is called when livetree is not supported. The fdt_get_resource() doesn't do the address translation so when it is required, but the address translation is done by

Re: [PATCH v2 03/17] drivers: reset: Handle gracefully NULL pointers

2021-05-04 Thread Kishon Vijay Abraham I
Hi Simon, On 15/04/21 1:08 am, Simon Glass wrote: > Hi Kishon, > > On Mon, 5 Apr 2021 at 11:28, Kishon Vijay Abraham I wrote: >> >> From: Jean-Jacques Hiblot >> >> The reset framework provides devm_reset_control_get_optional() >> which can return NULL (not an error case). So all the other

Re: Weirdness of ofnode_get_addr_size()

2021-05-04 Thread Jan Kiszka
On 02.05.21 09:53, Jan Kiszka wrote: > Hi, > > I'm trying to make some sense of ofnode_get_addr_size() in order to fix > [1] properly. > > First, the documentation if this functions says "This does no address > translation". But the node-pointer path happily calls > of_translate_address(), as

Re: [PATCH] fs/squashfs: Fix some hardlinks reading the wrong inode

2021-05-04 Thread Miquel Raynal
Hello, Campbell Suter wrote on Fri, 30 Apr 2021 16:45:46 +1200: > In SquashFS, the contents of a directory is stored by > squashfs_directory_entry structures which contain the file's name, inode > and position within the filesystem. > > The inode number is not stored directly; instead each

Re: [PATCH 16/49] kconfig: Add host support to CONFIG_IS_ENABLED()

2021-05-04 Thread Rasmus Villemoes
On 04/05/2021 01.11, Simon Glass wrote: > At present we must separately test for the host build for many options, > since we force them to be enabled. For example, CONFIG_FIT is always > enabled in the host tools, even if CONFIG_FIT is not enabled by the > board itself. > > It would be more

Re: [PATCH 12/49] image: Create a function to do manual relocation

2021-05-04 Thread Rasmus Villemoes
On 04/05/2021 01.10, Simon Glass wrote: > Rather than adding an #ifdef and open-coding this calculation, add a > helper function to handle it. Use this in the image code. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > common/image.c | 33

Re: [PATCH 02/49] compiler: Add a comment to host_build()

2021-05-04 Thread Rasmus Villemoes
On 04/05/2021 01.10, Simon Glass wrote: > This function should have a comment explaining what it does. Add one. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > include/compiler.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/compiler.h

Re: [PATCH 01/49] Add support for an owned buffer

2021-05-04 Thread Rasmus Villemoes
On 04/05/2021 01.10, Simon Glass wrote: > When passing a data buffer back from a function, it is not always clear > who owns the buffer, i.e. who is responsible for freeing the memory used. > An example of this is where multiple files are decompressed from the > firmware image, using a temporary

  1   2   >