[U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
/DesignPrinciples: === 8. Keep it Maintainable Avoid #ifdefs where possible === Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Mischa Jonker mjon...@synopsys.com Cc: Jaehoon Chung jh80.ch...@samsung.com Cc: Andy Fleming aflem...@gmail.com Cc: Alim Akhtar alim.akh...@samsung.com Cc

Re: [U-Boot] [PATCH v2 4/4] cmd_eeprom: bug fix for i2c read/write

2013-11-29 Thread Alexey Brodkin
On Fri, 2013-11-29 at 17:32 +0800, Kuo-Jung Su wrote: Unfortunately I still cannot agree with you. In my opinion I2C driver has nothing to do with current situation. Yes, that's why I said the root cause is U-Boot's I2C model. The address should never be rebuilt/reformated inside the I2C

Re: [U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
On Fri, 2013-11-29 at 18:57 +0900, Jaehoon Chung wrote: I think good that just removed the #include asm/arch/dwmmc.h. Instead, Exnyos specific code can move into dw-mmc-exynos.c with callback function. (I didn't know whcih Soc is used with MPSCTRL register.) Because of this you selected

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
On Fri, 2013-11-29 at 19:00 +0900, Jaehoon Chung wrote: remove this and use callback function like the host-board_init()? if (host-board_init()) host-board_init(host); Then we can reuse the this function for board specific code. Anyway, I think that exynos code didn't exist at

Re: [U-Boot] [PATCH] mmc: dw_mmc: remove the exynos specific code in dw-mmc.c

2013-11-29 Thread Alexey Brodkin
Acked-by: Alexey Brodkin abrod...@synopsys.com On Fri, 2013-11-29 at 20:08 +0900, Jaehoon Chung wrote: dw-mmc.c is the general driver file. So, remove the exynos specific code at dw-mmc.c. Instead, exynos specific cod can be move into exynos-dw_mmc.c. Signed-off-by: Jaehoon Chung jh80.ch

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
All looks good from my side; Please do a boot test on the real hardware and let me know before I can apply. Hi Pantelis, confirming - builds/works good for me. -Alexey ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-12-02 Thread Alexey Brodkin
On Mon, 2013-12-02 at 14:45 +0900, Jaehoon Chung wrote: Hi, Rajeshwari It didn't need to include this patch. Best Regards, Jaehoon Chung Agree, there's no need in this particular patch any more. Jaehoon Chung did appropriate changes in dwmmc driver. Thanks for collaboration. -Alexey

Re: [U-Boot] [PATCH v3 4/4] cmd_eeprom: bug fix for i2c read/write

2013-12-02 Thread Alexey Brodkin
On Mon, 2013-12-02 at 16:02 +0800, Kuo-Jung Su wrote: From: Kuo-Jung Su dant...@faraday-tech.com diff --git a/common/cmd_eeprom.c b/common/cmd_eeprom.c index 02539c4..3924805 100644 --- a/common/cmd_eeprom.c +++ b/common/cmd_eeprom.c @@ -161,7 +161,7 @@ int eeprom_read (unsigned dev_addr,

Re: [U-Boot] [PATCH 2/2] arm: exynos: remove the unused define.

2013-12-02 Thread Alexey Brodkin
On Tue, 2013-12-03 at 14:00 +0900, Jaehoon Chung wrote: These defines didn't use anywhere. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com --- arch/arm/include/asm/arch-exynos/dwmmc.h |4 1 file changed, 4 deletions(-) Acked-by: Alexey Brodkin abrod...@synopsys.com Regards

Re: [U-Boot] [PATCH v3 4/4] cmd_eeprom: bug fix for i2c read/write

2013-12-02 Thread Alexey Brodkin
On Tue, 2013-12-03 at 08:55 +0800, Kuo-Jung Su wrote: The comment bellow clearly explain the issue here. soft_i2c.c: line 351 ~ 367: #ifdef CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW /* * EEPROM chips that implement address overflow are ones * like Catalyst 24WC04/08/16 which has

Re: [U-Boot] [PATCH v2] mmc/dwmmc: modify FIFO threshold only if value explicitly set

2013-12-06 Thread Alexey Brodkin
On Wed, 2013-11-27 at 22:07 +0900, Jaehoon Chung wrote: Acked-by: Jaehoon Chung jh80.ch...@samsung.com Any chance to get this patch applied? -Alexey ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 4/4] cmd_eeprom: bug fix for i2c read/write

2013-12-09 Thread Alexey Brodkin
Hi Heiko, On Mon, 2013-12-09 at 07:56 +0100, Heiko Schocher wrote: Applied to u-boot.i2c.git, thanks! I'm wondering if you've seen a discussion between me and Kuo-jung regarding this patch and consequences of it being applied. Do you mind to comment on questions we discussed there? My main

[U-Boot] [PATCH] lib/time - fix usec_to_tick calculation for hi freq system timers

2013-12-09 Thread Alexey Brodkin
Current implementation works fine if usec * get_tbclk() fits in 32 bits. Otherwise result will be cut down to 32-bit. Fix is obvious - first extend data type of either operand. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Mischa Jonker mjon

[U-Boot] [PATCH] lib/time - remove obsolete code

2013-12-09 Thread Alexey Brodkin
Seems like this is a reminder of some legacy stuff. Definitely of no use now. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Mischa Jonker mjon...@synopsys.com --- lib/time.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/time.c b/lib

Re: [U-Boot] [U-Boot, v3, 4/4] cmd_eeprom: bug fix for i2c read/write

2013-12-10 Thread Alexey Brodkin
On Mon, 2013-12-09 at 12:21 +0100, Heiko Schocher wrote: I thought the v3 patch just rolls things back as patch comment states: Changes for v3: - It turns out that what we did before 2013-11-13 (i.e., cmd_eeprom: fix i2c_{read|write} usage if env is in I2C

Re: [U-Boot] [PATCH] board_f: explicitly disable console on early boot

2013-12-10 Thread Alexey Brodkin
On Thu, 2013-11-28 at 13:55 +0400, Alexey Brodkin wrote: On Wed, 2013-11-27 at 18:43 -0700, Simon Glass wrote: I have a similar patch locally, but it actually does memset() on the whole structure. Some archs handle this setup differently. For example both ARM and x86 now allocate

[U-Boot] [PATCH] env_eeprom - fix bus recovery for eeprom_bus_read

2013-12-11 Thread Alexey Brodkin
env_eeprom_bus is no longer in use (it was introduced in commit 548738b4d43af841ff58c787bce297ac6a8bf7d1 cmd_eeprom: I2C updates). As in eeprom_bus_write we just reset I2C bus with the one we saved in old_bus. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Wolfgang Denk w...@denx.de Cc

[U-Boot] [PATCH] serial/serial_arc - add driver for ARC UART

2013-12-12 Thread Alexey Brodkin
Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Mischa Jonker mjon...@synopsys.com Cc: Francois Bedard fbed...@synopsys.com Cc: Tom Rini tr...@ti.com Cc: Wolfgang Denk w

Re: [U-Boot] [PATCH] lib/time - fix usec_to_tick calculation for hi freq system timers

2013-12-12 Thread Alexey Brodkin
Hi Tom, On Mon, 2013-12-09 at 16:57 +0400, Alexey Brodkin wrote: Current implementation works fine if usec * get_tbclk() fits in 32 bits. Otherwise result will be cut down to 32-bit. Fix is obvious - first extend data type of either operand. Signed-off-by: Alexey Brodkin abrod

Re: [U-Boot] [PATCH] serial/serial_arc - add driver for ARC UART

2013-12-13 Thread Alexey Brodkin
On Fri, 2013-12-13 at 08:07 -0500, Tom Rini wrote: Looks fine, please list this as a pre-requisite patch when posting the rest of the board, thanks! Hi Tom, is my understanding correct that this patch will be accepted as it is but later when I do submission of corresponding board I just

Re: [U-Boot] [PATCH] lib/time - fix usec_to_tick calculation for hi freq system timers

2013-12-13 Thread Alexey Brodkin
On Fri, 2013-12-13 at 09:09 -0500, Tom Rini wrote: Please note that I'm taking http://patchwork.ozlabs.org/patch/297361/ as the solution for this problem, thanks! As long as it resolves overflow issue (and from that patch I'd say it should) I'm totally fine with it. Thanks. P.S. funny

[U-Boot] [PATCH] drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW

2013-12-16 Thread Alexey Brodkin
Since we agreed on legacy implementation of eeprom_{read|write} (http://patchwork.ozlabs.org/patch/295825/) I had to fix/make it work again DesignWare I2C driver for cases when 1 EEPROM IC fake I2C with anumber of built-in ICs with different chip addresses. Signed-off-by: Alexey Brodkin abrod

Re: [U-Boot] [PATCH] mmc/dwmmc: Using calloc instead malloc

2013-12-18 Thread Alexey Brodkin
On Wed, 2013-12-18 at 09:08 -0600, Chin Liang See wrote: To enhance the SDMMC DesignWare driver to use calloc instead of malloc. This will avoid the incident that uninitialized members of mmc structure are later used for NULL comparison. IMHO pretty sane change. Actually I had local memset

[U-Boot] [PATCH] net/designware: make driver compatible with data cache

2013-12-24 Thread Alexey Brodkin
* Invalidate cache for data passed from GMAC to CPU I tried to implement items above keeping as much code unchanged as possible. So logic of operation is kept as it is. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Joe Hershberger joe.hershber...@ni.com Cc: Vipin Kumar vipin.ku...@st.com

[U-Boot] [PATCH] mmc/dwmmc: use bounce buffer for data exchange between CPU and MMC controller

2013-12-24 Thread Alexey Brodkin
definition (CONFIG_BOUNCE_BUFFER) in board configuration, otherwise corresponding library won't be compiled and linker will fail to build resulting executable. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Mischa Jonker mjon...@synopsys.com Cc: Alim Akhtar alim.akh...@samsung.com Cc

[U-Boot] [PATCH v2] mmc/dwmmc: use bounce buffer for data exchange between CPU and MMC controller

2013-12-26 Thread Alexey Brodkin
‘const’ qualifier from pointer target type Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Mischa Jonker mjon...@synopsys.com Cc: Alim Akhtar alim.akh...@samsung.com Cc: Rajeshwari Shinde rajeshwar...@samsung.com Cc: Jaehoon Chung jh80.ch...@samsung.com Cc: Amar amarendra...@samsung.com Cc

[U-Boot] [PATCH] net: execute miiphy_init if CONFIG_PHYLIB defined

2014-01-10 Thread Alexey Brodkin
mii_devs list which is not initialized because miiphy_init never got called. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Joe Hershberger joe.hershber...@ni.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Simon Glass s...@chromium.org Cc: Wolfgang Denk w...@denx.de --- net/eth.c | 2 +- 1

[U-Boot] [PATCH v2] net/designware: make driver compatible with data cache

2014-01-13 Thread Alexey Brodkin
to GMAC * Invalidate cache for data passed from GMAC to CPU Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Joe Hershberger joe.hershber...@ni.com Cc: Vipin Kumar vipin.ku...@st.com Cc: Stefan Roese s...@denx.de Cc: Mischa Jonker mjon...@synopsys.com Compared to v1: 1. Dropped all extra

[U-Boot] [PATCH] net/designware: add explicit reset of {tx|rx}_currdescnum

2014-01-13 Thread Alexey Brodkin
the first buffer descriptor as well after every init we have to reset {tx|rx}_currdescnum. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Joe Hershberger joe.hershber...@ni.com Cc: Vipin Kumar vipin.ku...@st.com Cc: Stefan Roese s...@denx.de Cc: Mischa Jonker mjon...@synopsys.com --- drivers

[U-Boot] [PATCH] net/designware - switch driver to phylib usage

2014-01-13 Thread Alexey Brodkin
no need now in doc/README.designware_eth because user only needs to instantiate the driver with designware_initialize whose prototype exists in include/netdev.h. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Joe Hershberger joe.hershber...@ni.com Cc: Vipin Kumar vipin.ku...@st.com Cc: Stefan

Re: [U-Boot] [PATCH] net/designware - switch driver to phylib usage

2014-01-13 Thread Alexey Brodkin
Completely forgot to mention that there's a prerequisite (http://patchwork.ozlabs.org/patch/309319/): == [PATCH] net: execute miiphy_init if CONFIG_PHYLIB defined == This makes sure that phylib will be correctly initialized even if there's no explicit mention of either entry in board

[U-Boot] [PATCH] board_r - fixup functions table after relocation

2014-01-15 Thread Alexey Brodkin
after relocation initcall_run_list will be jumping to pre-relocation addresses. As long as we don't overwrite pre-relocation memory area init calls are executed correctly. But still it is dangerous because after relocation we don't expect initially used memory to stay untouched. Signed-off-by: Alexey

Re: [U-Boot] [PATCH] board_r - fixup functions table after relocation

2014-01-15 Thread Alexey Brodkin
On Wed, 2014-01-15 at 11:27 +, thomas.lan...@lantiq.com wrote: I think this is only required/possible for architectures which define CONFIG_NEEDS_MANUAL_RELOC, others don't have gd-reloc_off if (initcall_run_list(init_sequence_r)) hang(); Hi Thomas, I think it's a

Re: [U-Boot] [PATCH] designware_i2c: Enhance DesignWare I2C driver address support

2014-01-15 Thread Alexey Brodkin
On Wed, 2014-01-15 at 08:58 -0600, Chin Liang See wrote: Enhance the DesignWare I2C driver to support address length more than 1 byte. This enhancement is required as some I2C slave device such as EEPROM chip might have 16 bit address byte. diff --git a/drivers/i2c/designware_i2c.c

Re: [U-Boot] [PATCH] drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW

2014-01-15 Thread Alexey Brodkin
On Mon, 2013-12-16 at 15:30 +0400, Alexey Brodkin wrote: Since we agreed on legacy implementation of eeprom_{read|write} (http://patchwork.ozlabs.org/patch/295825/) I had to fix/make it work again DesignWare I2C driver for cases when 1 EEPROM IC fake I2C with anumber of built-in ICs

Re: [U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support

2014-01-15 Thread Alexey Brodkin
On Wed, 2014-01-15 at 09:45 -0600, Chin Liang See wrote: Changes for v2 - Removed the function check_params() Ok, so you decided to not add assert check instead. I think it's ok - it's not a requirement. Others don't do it as well so let's leave it as it is. Acked-by: Alexey Brodkin abrod

Re: [U-Boot] [PATCH] board_r - fixup functions table after relocation

2014-01-16 Thread Alexey Brodkin
On Wed, 2014-01-15 at 22:43 +0100, Albert ARIBAUD wrote: Hi Alexey, On Wed, 15 Jan 2014 15:19:56 +0400, Alexey Brodkin alexey.brod...@synopsys.com wrote: init_sequence_r is just an array that consists of compile-time adresses of init functions. Since this is basically an array

Re: [U-Boot] [PATCH] board_r - fixup functions table after relocation

2014-01-16 Thread Alexey Brodkin
On Wed, 2014-01-15 at 09:56 -0700, Simon Glass wrote: I have not checked to make sure that the array contents remains un-relocated. Did you see this? Hi Simon, yes, I do see it. Please refer to my outputs below: 1. Without manual init_sequence_r modification: U-Boot

Re: [U-Boot] [PATCH] board_r - fixup functions table after relocation

2014-01-16 Thread Alexey Brodkin
On Thu, 2014-01-16 at 21:27 +0100, Albert ARIBAUD wrote: GOT relocation does not relocate references within data, contrary to ELF. Maybe it's just my faulty implementation of relocation but it might be that nobody ever noticed this because I think only initcalls are affected. Well,

Re: [U-Boot] [PATCH] board_r - fixup functions table after relocation

2014-01-16 Thread Alexey Brodkin
On Fri, 2014-01-17 at 00:40 +0400, Alexey Brodkin wrote: On Thu, 2014-01-16 at 21:27 +0100, Albert ARIBAUD wrote: Well, I've just realized that very similar thing is done in fixup_cmdtable. So I believe with addition of CONFIG_NEEDS_MANUAL_RELOC wrapper my change may make some sense. Any

Re: [U-Boot] [PATCH] drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW

2014-01-17 Thread Alexey Brodkin
On Fri, 2014-01-17 at 07:42 +0100, Heiko Schocher wrote: Hello Alexey, I picked it up, see: http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=summary http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=commit;h=32d041e218c6a22e92d91629902fd03a90934b6a Note this is not an enhancement - this is a

Re: [U-Boot] [PATCH] net/designware - switch driver to phylib usage

2014-01-20 Thread Alexey Brodkin
On Mon, 2014-01-13 at 15:11 +0400, Alexey Brodkin wrote: With this change driver will benefit from existing phylib and thus custom phy functionality implemented in the driver will go away: * Instantiation of the driver is now much shorter - 2 parameters instead of 4. * Simplified phy

Re: [U-Boot] [i2c] Pull request

2014-01-20 Thread Alexey Brodkin
for the second i2c controller (2014-01-13 09:06:08 +0100) Alexey Brodkin (2): env_eeprom - fix bus recovery for eeprom_bus_read drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW Darwin

[U-Boot] [PATCH v2] board_r - fixup functions table after relocation

2014-01-20 Thread Alexey Brodkin
. But still it is dangerous because after relocation we don't expect initially used memory to stay untouched. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com Cc: Simon Glass s...@chromium.org Cc: Masahiro Yamada yamad...@jp.panasonic.com Cc: Doug Anderson diand

[U-Boot] [PATCH v3] board_r - fixup functions table after relocation

2014-01-20 Thread Alexey Brodkin
. But still it is dangerous because after relocation we don't expect initially used memory to stay untouched. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com Cc: Simon Glass s...@chromium.org Cc: Masahiro Yamada yamad...@jp.panasonic.com Cc: Doug Anderson diand

Re: [U-Boot] [PATCH v3] board_r - fixup functions table after relocation

2014-01-21 Thread Alexey Brodkin
Hi Simon, On Tue, 2014-01-21 at 09:13 -0700, Simon Glass wrote: Hi, It's unfortunate that we need to carry over CONFIG_NEEDS_MANUAL_RELOC to the new common board init code. But if we do, this patch looks reasonable, so: I think as long as PIC relocation is supported in U-Boot (for some

Re: [U-Boot] [PATCH] net/designware - switch driver to phylib usage

2014-01-22 Thread Alexey Brodkin
Hi Sonic, On Wed, 2014-01-22 at 17:10 +0800, Sonic Zhang wrote: Hi Alexey, I failed to apply your patch on the 2014.01 release head. Indeed this one requires 2 other patches which didn't made it to mainline yet. Do you mind to try to apply both patches

Re: [U-Boot] Call for participation in the U-Boot Mini Summit 2014

2014-09-23 Thread Alexey Brodkin
Hi Marek, On Fri, 2014-09-19 at 06:27 +0200, Marek Vasut wrote: On Thursday, September 18, 2014 at 10:52:12 AM, Alexey Brodkin wrote: If that's an introduction to porting U-Boot, it might bring to light some new ideas about the porting process and also point out some obstacles we were

Re: [U-Boot] U-Boot Mini Summit

2014-10-07 Thread Alexey Brodkin
Hi Detlev, On Tue, 2014-10-07 at 11:38 +0200, Detlev Zundel wrote: Hello Masahiro-san, [...] Perhaps, is it better to insert 5-minute break between talks? Speakers might need to get something prepared. (connecting their laptop to the beamer, etc.) Of course. I did not explicitely

Re: [U-Boot] [PATCH] image-fdt: boot_get_fdt() return value when no DTB exists

2014-10-22 Thread Alexey Brodkin
Hi Tom, On Wed, 2014-10-22 at 12:48 -0400, Tom Rini wrote: On Wed, Oct 22, 2014 at 05:17:49PM +0300, Noam Camus wrote: From: Noam Camus no...@ezchip.com I believe that when no DTB is around we should return 1. This why I fixed such scenarious to not return zero anymore. Else kernel

Re: [U-Boot] [PATCH] i2c: designware: Convert driver to multibus/multiadapter framework

2014-10-23 Thread Alexey Brodkin
platform) I couldn't test this patch on those boards. Only compile tested for all spear boards. And tested on SoCFPGA. Signed-off-by: Stefan Roese s...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Marek Vasut ma...@denx.de Cc: Vipin Kumar vipin.ku...@st.com Cc: Alexey Brodkin abrod

Re: [U-Boot] [PATCH] axs101: Fix type mismatch warning

2014-08-26 Thread Alexey Brodkin
Hi Vasili, On Tue, 2014-08-26 at 13:46 +0300, Vasili Galka wrote: Initialization of pointer from integer shall be designated by explicit type cast. Signed-off-by: Vasili Galka vvv...@gmail.com Cc: Alexey Brodkin alexey.brod...@synopsys.com --- board/synopsys/axs101/nand.c |4

[U-Boot] [PATCH] common: fix compiler warning on wrong printf format

2014-08-26 Thread Alexey Brodkin
/bouncebuf.c: In function ‘addr_aligned’: common/bouncebuf.c:26:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘size_t’ [-Wformat=] debug(Unaligned buffer length %d\n, /*(int)*/state-len); ^ -- Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Vasili

[U-Boot] Please pull u-boot-arc/master

2014-08-26 Thread Alexey Brodkin
Hi Tom, The following changes since commit 7bee1c91a94db19bd26f92cc67be35d3592c6429: Merge branch 'ag...@denx.de' of git://git.denx.de/u-boot-staging (2014-08-25 08:34:39 -0400) are available in the git repository at: git://git.denx.de/u-boot-arc.git master for you to fetch changes up to

Re: [U-Boot] [PATCH v2] axs101: Fix type mismatch warning

2014-08-26 Thread Alexey Brodkin
Hi Vasili, On Tue, 2014-08-26 at 17:50 +0300, Vasili Galka wrote: Initialization of pointer from integer shall be designated by explicit type cast. Signed-off-by: Vasili Galka vvv...@gmail.com Cc: Alexey Brodkin alexey.brod...@synopsys.com --- Changes for v2: - Verified complience

Re: [U-Boot] [PATCH] arc: Fix printf size_t format related warnings (again...)

2014-08-26 Thread Alexey Brodkin
...@gmail.com Cc: Alexey Brodkin alexey.brod...@synopsys.com --- arch/arc/include/asm/posix_types.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arc/include/asm/posix_types.h b/arch/arc/include/asm/posix_types.h index 20415f0..51347a4 100644 --- a/arch/arc

[U-Boot] [PATCH v2] common: fix compiler warning on wrong printf format

2014-08-28 Thread Alexey Brodkin
From: Alexey Brodkin alexey.brod...@synopsys.com bounce_buffer-len_aligned is of type size_t so use %zd. this fixes following warning: -- common/bouncebuf.c: In function addr_aligned: common/bouncebuf.c:26:3: warning: format %d expects argument of type int, but argument 2 has type size_t

Re: [U-Boot] [PATCH v2] common: fix compiler warning on wrong printf format

2014-08-28 Thread Alexey Brodkin
Hi Vasili, On Thu, 2014-08-28 at 17:17 +0300, Vasili Galka wrote: On Thu, Aug 28, 2014 at 4:15 PM, Alexey Brodkin alexey.brod...@synopsys.com wrote: From: Alexey Brodkin alexey.brod...@synopsys.com bounce_buffer-len_aligned is of type size_t so use %zd

Re: [U-Boot] Call for participation in the U-Boot Mini Summit 2014

2014-09-18 Thread Alexey Brodkin
Hi Detlev, On Wed, 2014-09-03 at 18:56 +0200, Przemyslaw Marczak wrote: Hello Detlev, On 08/11/2014 05:48 PM, Przemyslaw Marczak wrote: Hello Detlev, On 01/13/2014 06:12 PM, Detlev Zundel wrote: Hi, as already indicated, we are looking forward to our next U-Boot Mini Summit at

[U-Boot] [PATCH] designware_i2c: remove 10msec delay in i2c_xfer_finish

2013-11-07 Thread Alexey Brodkin
devices. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com cc: Armando Visconti armando.visco...@st.com Cc: Stefan Roese s...@denx.de Cc: Albert ARIBAUD albert.u.b...@aribaud.net Cc: Heiko Schocher h...@denx.de Cc: Vipin KUMAR vipin.ku...@st.com Cc: Tom Rix tom

[U-Boot] [PATCH] cmd_eeprom: fix i2c_{read|write} usage if env is in I2C EEPROM

2013-11-07 Thread Alexey Brodkin
Data offset is not used directly in case of I2C EEPROM. Istead it is split into block number and offset within mentioned block. Which are addr[0] and addr[1] respectively. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com cc: Peter

[U-Boot] [PATCH] designware_i2c: disable i2c controller during target address setup

2013-11-07 Thread Alexey Brodkin
As it is stated in DesignWare I2C databook: writes to IC_TAR (0x4) register succeed only when IC_ENABLE[0] is set to 0. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com cc: Armando Visconti armando.visco...@st.com Cc: Stefan Roese s...@denx.de Cc: Albert ARIBAUD

[U-Boot] [PATCH] kbuild/makefile: allow building host tools separately

2014-03-20 Thread Alexey Brodkin
with make XXX_config 2. Execute tools building but still cross-compiler will be invoked and if there's no proper cross-compiler in PATH compilation will fail. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Masahiro Yamada yamad...@jp.panasonic.com Cc: Tom Rini tr...@ti.com Cc: Simon

[U-Boot] [PATCH] net/designware: align DMA buffer descriptors to D$ line

2014-03-21 Thread Alexey Brodkin
It's important to have ability to flush/invalidate each DMA buffer descriptor individually to prevent incoherency of adjacent BDs. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Vineet Gupta vgu...@synopsys.com Cc: Joe Hershberger joe.hershber...@ni.com Cc: Vipin Kumar vipin.ku

[U-Boot] [PATCH] axs101: flush DMA buffer descriptors before DMA transactons starts

2014-03-21 Thread Alexey Brodkin
. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Vineet Gupta vgu...@synopsys.com Cc: Tom Rini tr...@ti.com --- board/synopsys/axs101/nand.c | 8 1 file changed, 8 insertions(+) diff --git a/board/synopsys/axs101/nand.c b/board/synopsys/axs101/nand.c index 8672803..c7f90c4

[U-Boot] [PATCH] axs101 - increase EEPROM page write delay from 32 to 64 msec

2014-03-24 Thread Alexey Brodkin
With 32 milliseconds delay on some boards EEMPROM got written inconsistently. With 64 msec all of our existig boards show properly written EEPROM. Cc: Tom Rini tr...@ti.com Signed-off-by: Alexey Brodkin abrod...@synopsys.com --- include/configs/axs101.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH] kbuild/makefile: allow building host tools separately

2014-03-28 Thread Alexey Brodkin
Hi Masahiro-san, On Fri, 2014-03-28 at 15:36 +0900, Masahiro Yamada wrote: Hi Alexey, This may be the similar discussion to http://u-boot.10912.n7.nabble.com/U-Boot-could-not-cross-compile-u-boot-tools-td174911.html It looks not that relevant to me. For example even before switching U-Boot

Re: [U-Boot] [PATCH] kbuild/makefile: allow building host tools separately

2014-03-30 Thread Alexey Brodkin
Hi Masahiro-san, On Mon, 2014-03-31 at 10:43 +0900, Masahiro Yamada wrote: I wanted to show retionale why a make target tools-only is better than HOST_TOOLS_ONLY=yes. Completely agree. I should have think a bit more before sending initial patch because right after the email was sent I thought

Re: [U-Boot] [PATCH] Kbuild: allow building tools without board configuration

2014-03-31 Thread Alexey Brodkin
tools-only Neither board configuration nor cross compiler are required to build host tools. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Suggested-by: Alexey Brodkin alexey.brod...@synopsys.com Cc: Alexey Brodkin alexey.brod...@synopsys.com Cc: Simon Glass s...@chromium.org

Re: [U-Boot] [PATCH] Kbuild: allow building tools without board configuration

2014-03-31 Thread Alexey Brodkin
. This patch revives it again by adding a make target tools-only. Usage: $ make tools-only Neither board configuration nor cross compiler are required to build host tools. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Suggested-by: Alexey Brodkin alexey.brod...@synopsys.com

Re: [U-Boot] [PATCH] Kbuild: allow building tools without board configuration

2014-03-31 Thread Alexey Brodkin
On Mon, 2014-03-31 at 11:31 -0400, Tom Rini wrote: On Mon, Mar 31, 2014 at 03:24:19PM +, Alexey Brodkin wrote: Hi Tom, On Mon, 2014-03-31 at 11:16 -0400, Tom Rini wrote: On Mon, Mar 31, 2014 at 05:33:51PM +0900, Masahiro Yamada wrote: Prior to Kbuild, U-Boot could build

Re: [U-Boot] [PATCH] axs101 - increase EEPROM page write delay from 32 to 64 msec

2014-04-01 Thread Alexey Brodkin
Hi Tom, On Mon, 2014-03-24 at 17:27 +0400, Alexey Brodkin wrote: With 32 milliseconds delay on some boards EEMPROM got written inconsistently. With 64 msec all of our existig boards show properly written EEPROM. Cc: Tom Rini tr...@ti.com Signed-off-by: Alexey Brodkin abrod...@synopsys.com

[U-Boot] [PATCH] axs101: bump DDR size from 256 to 512 Mb

2014-04-01 Thread Alexey Brodkin
Signed-off-by: Alexey Brodkin abrod...@synopsys.com --- include/configs/axs101.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/axs101.h b/include/configs/axs101.h index 8d03110..c22d6d0 100644 --- a/include/configs/axs101.h +++ b/include/configs/axs101.h

[U-Boot] Changes for boards I maintain

2014-04-11 Thread Alexey Brodkin
Hi Tom, Now I have my own tree (u-boot-arc) and I may commit there changes for ARC architecture. But I'm wondering if I may commit changes to boards I maintain in the same u-boot-arc repo as well? Currently these are all in board/synopsys folder. Or I need to send patches for my boards to the

Re: [U-Boot] [PATCH 1/3] net/designware: ensure device private data is DMA aligned.

2014-04-24 Thread Alexey Brodkin
this hard-coded item. Still I haven't tried to execute this on the real board. Hope to do it soon but I don't expect any issues. Regards, Alexey Reviewed-by: Alexey Brodkin abrod...@synopsys.com ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] [PATCH 2/3] net/designware: invalidate entire descriptor in dw_eth_send

2014-04-24 Thread Alexey Brodkin
Dear Ian, On Sat, 2014-04-19 at 14:52 +0100, Ian Campbell wrote: - /* Invalidate only status field for the following check */ - invalidate_dcache_range((unsigned long)desc_p-txrx_status, - (unsigned long)desc_p-txrx_status + -

Re: [U-Boot] [PATCH 2/3] net/designware: invalidate entire descriptor in dw_eth_send

2014-04-25 Thread Alexey Brodkin
Hi Ian, On Thu, 2014-04-24 at 20:14 +0100, Ian Campbell wrote: On Thu, 2014-04-24 at 17:41 +, Alexey Brodkin wrote: 1. Don't invalidate sizeof(struct dmamacdescr) but only roundup(sizeof(desc_p-txrx_status), ARCH_DMA_MINALIGN)). OK. (Although given the realities of the real world

[U-Boot] please pull u-boot-arc master

2014-04-25 Thread Alexey Brodkin
to 0cdd762027340ad82fdc2bf7476e8e791529a251: axs101: bump DDR size from 256 to 512 Mb (2014-04-25 18:00:23 +0400) Alexey Brodkin (2): axs101: increase EEPROM page write delay from 32 to 64 msec axs101: bump DDR size from 256

Re: [U-Boot] please pull u-boot-arc master

2014-04-28 Thread Alexey Brodkin
Hi Tom, On Fri, 2014-04-25 at 15:45 -0400, Tom Rini wrote: On Fri, Apr 25, 2014 at 02:24:57PM +, Alexey Brodkin wrote: Dear Tom, The following changes since commit adcdeacc3eda1e5949e54062aa99c299e12483be: Merge branch 'master' of git://git.denx.de/u-boot-mips (2014-04-23

[U-Boot] Failure on attempt to build env tools

2014-04-28 Thread Alexey Brodkin
the same error could you please fix it? If it's me who builds env tools improperly could you please teach me how to build them correctly? -- Best regards, Alexey Brodkin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman

Re: [U-Boot] [PATCH] tools: env: Add aes.c placeholder

2014-04-28 Thread Alexey Brodkin
Hi Marek, On Mon, 2014-04-28 at 11:56 +0200, Marek Vasut wrote: Add missing aes.c placeholder which includes lib/aes.c . Without this one, tools/env/ will fail to build. Signed-off-by: Marek Vasut ma...@denx.de Cc: Alexey Brodkin alexey.brod...@synopsys.com Cc: Masahiro Yamada yamad

Re: [U-Boot] [PATCH 2/3] net/designware: invalidate entire descriptor in dw_eth_send

2014-04-28 Thread Alexey Brodkin
Dear Ian, On Sun, 2014-04-27 at 19:47 +0100, Ian Campbell wrote: This is the driver for one particular ARM cache controller and not the one used for the SoC. In any case it does proper start/end handling only for cache flush operations, not cache invalidate. Cache invalidate is a

Re: [U-Boot] [PATCH v3 9/9] net/designware: Reduce DMA burst length

2014-04-28 Thread Alexey Brodkin
Hi Marek, On Mon, 2014-04-28 at 07:55 +0200, Marek Vasut wrote: On Monday, April 28, 2014 at 07:51:49 AM, Chen-Yu Tsai wrote: On Mon, Apr 28, 2014 at 2:08 AM, Marek Vasut ma...@denx.de wrote: On Sunday, April 27, 2014 at 05:29:29 PM, Chen-Yu Tsai wrote: On Sun, Apr 27, 2014 at 11:25 PM,

[U-Boot] [PATCH] cmd_bdinfo: check for CONFIG_ARC instead of CONFIG_ARC700

2014-12-26 Thread Alexey Brodkin
For all flavours of ARC we execute the same code in bdinfo so we may safely check for CONFIG_ARC. This is especially important since we're about to add more types of ARC so existing check won't work in all cases. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com

[U-Boot] [PATCH] arc: introduce mdbtrick target

2014-12-26 Thread Alexey Brodkin
may build U-Boot that will be loaded on target via MDB saying make mdbtrick. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com --- arch/arc/Makefile | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index de25cc9

Re: [U-Boot] [PATCH] arc: introduce mdbtrick target

2014-12-26 Thread Alexey Brodkin
Hi Wolfgang, On Fri, 2014-12-26 at 11:00 +0100, Wolfgang Denk wrote: Dear Alexey, In message 1419587516-30541-1-git-send-email-abrod...@synopsys.com you wrote: MetaWare debugger doesn't support PIE (position-independent executable) so the only way to load U-Boot in MDB is to fake it by:

[U-Boot] [PATCH] initcall: add explicit hint if initcall was relocated

2014-12-27 Thread Alexey Brodkin
as expected and then for some reason returned back? But I hope comment in brackets will save some time for those curious developers who are careful enough to catch unexpected jump to pre-reloc area or those unlucky ones who'll have to deal with relocation debugging. Signed-off-by: Alexey Brodkin abrod

[U-Boot] [PATCH v2] arc: introduce mdbtrick target

2014-12-29 Thread Alexey Brodkin
. But still MDB will do its work on showing disassembly, global symbols, registers, accessing low-level debug facilities etc. As a summary - this is a pretty dirty hack but it simplifies life a lot for us ARc developers. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com Cc

[U-Boot] [PATCH 1/2] common: mark commands as default to match config_cmd_default.h

2015-01-03 Thread Alexey Brodkin
Now when we may select commands via menuconfig let's adjust default settings with config_cmd_default.h. As the next step we may get rid of config_cmd_default.h inclusion in include/configs/*.h and config_cmd_default.h itself. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Masahiro

[U-Boot] [PATCH 2/2] config_cmd_default.h: wrap each definition in ifndef

2015-01-03 Thread Alexey Brodkin
in config_cmd_default.h since we still have to keep it util we're done with complete switch to Kconfig. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Tom Rini tr...@ti.com --- include/config_cmd_default.h | 42 ++ 1 file changed, 42 insertions(+) diff

[U-Boot] [PATCH 0/2] select default commands in Kconfig

2015-01-03 Thread Alexey Brodkin
compile-time warnings. Alexey Brodkin (2): common: mark commands as default to match config_cmd_default.h config_cmd_default.h: wrap each definition in ifndef common/Kconfig | 19 +++ include/config_cmd_default.h | 42 ++ 2

[U-Boot] [PATCH 03/12] arc: add more flavours of ARC700 series CPU

2015-02-03 Thread Alexey Brodkin
of options that exist in both CPUs but may have say different version like MMUv2 in ARC750D vs MMUv3 in ARC770D. Signed-off-by: Alexey Brodkin abrod...@synopsys.com --- arch/arc/Kconfig | 40 arch/arc/config.mk | 4 arch/arc

[U-Boot] [PATCH 04/12] arc: define and use PTAG AUX regs for MMUv3 only

2015-02-03 Thread Alexey Brodkin
DC_PTAG and IC_PTAG registers only exist in MMUv3. Signed-off-by: Alexey Brodkin abrod...@synopsys.com --- arch/arc/include/asm/arcregs.h | 4 ++-- arch/arc/lib/cache.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arc/include/asm/arcregs.h b/arch/arc

[U-Boot] [PATCH 02/12] arc: remove CPU hard-coded selection from board description in include/configs

2015-02-03 Thread Alexey Brodkin
With switch to Kconfig we only need very board-specific descriptions in include/configs. CPU selection is performed with either defconfig or manually via menuconfig. Signed-off-by: Alexey Brodkin abrod...@synopsys.com --- include/configs/arcangel4-be.h | 1 - include/configs/arcangel4.h| 1

[U-Boot] [PATCH 01/12] arc: memcmp - fix zero-delay loop utilization

2015-02-03 Thread Alexey Brodkin
From: Igor Guryanov gurya...@synopsys.com It's prohibited to put branch instruction in the very end of zero-delay loop. On execution this causes Illegal instruction exception. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Signed-off-by: Igor Guryanov gurya...@synopsys.com --- arch/arc/lib

[U-Boot] [PATCH 00/12] ARC: more improvements

2015-02-03 Thread Alexey Brodkin
This series is focused on following items: * Move more config options to Kconfig - Cache settings - Endianess - Monitor base * Clean-up of board configuration headers * Build libgcc in U-Boot for portability Alexey Brodkin (11): arc: remove CPU hard-coded selection from board

[U-Boot] [PATCH 07/12] arc: hard-code CONFIG_SYS_GENERIC_BOARD into asm/config.h

2015-02-03 Thread Alexey Brodkin
There're no other options for ARC except generic board so ther's no point to define CONFIG_SYS_GENERIC_BOARD per board. We now have it set fo all ARC boards. Signed-off-by: Alexey Brodkin abrod...@synopsys.com --- arch/arc/include/asm/config.h | 1 + include/configs/arcangel4.h | 1 - include

[U-Boot] [PATCH 05/12] arc: select cache settings via menuconfig

2015-02-03 Thread Alexey Brodkin
This change allows to keep board description clean and minimalistic. This is especially helpful if one board may house different CPUs with different features. It is applicable to both FPGA-based boards or those that have CPUs mounted on interchnagable daughter-boards. Signed-off-by: Alexey

[U-Boot] [PATCH 06/12] arc: add selection of endianess in Kconfig

2015-02-03 Thread Alexey Brodkin
/board/synopsys/MAINTAINERS index 720edd8..43114ce 100644 --- a/board/synopsys/MAINTAINERS +++ b/board/synopsys/MAINTAINERS @@ -3,5 +3,4 @@ M: Alexey Brodkin abrod...@synopsys.com S: Maintained F: include/configs/arcangel4.h F: configs/arcangel4_defconfig -F: include/configs

[U-Boot] [PATCH 09/12] arc: hard-code CONFIG_ARCH_EARLY_INIT_R in asm/config.h

2015-02-03 Thread Alexey Brodkin
Common arch_early_init_r() is used in arc/lib/cpu.c for all ARC boards so there's no sense in separate per-board definitions. Signed-off-by: Alexey Brodkin abrod...@synopsys.com --- arch/arc/include/asm/config.h | 1 + include/configs/arcangel4.h | 5 - include/configs/axs101.h | 5

<    1   2   3   4   5   6   7   8   >