[U-Boot] [PATCH 1/1] common/image.c: prefixes for binary multiples

-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- common/image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/image.c b/common/image.c index 8c35327745..31317a581e 100644 --- a/common/image.c +++ b/common/image.c @@ -561,7 +561,7 @@ void genimg_print_size(ui

[U-Boot] [PATCH 1/1] yaffs2: remove redundant condition

If !parent, the changed line is not reached. So there is no need to check the value again. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- fs/yaffs2/yaffsfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/yaffs2/yaffsfs.c b/fs/yaffs2/yaffsfs.c

[U-Boot] [PATCH] x86: zImage: avoid potential NULL dereference

If bootargs is not assigned getenv("bootargs") will return NULL. Some part of the code is checking for this condition. Other parts dereference a possible NULL pointer. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- arch/x86/

[U-Boot] [PATCH] cmd: ubi: remove unnecessary logical constraint

A size_t variable can never be negative. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- cmd/ubi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ubi.c b/cmd/ubi.c index efc43ffde9..222be5a357 100644 --- a/cmd

[U-Boot] [PATCH 1/1] usbtty: avoid potential NULL pointer dereference

If current_urb is NULL it should not be dereferenced. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/serial/usbtty.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/serial/usbtty.c b/d

[U-Boot] [PATCH] drivers/crypto/fsl: remove redundant logical contraint

'A || (!A && B)' is equivalent to 'A || B'. Let's reduce the complexity of the statement in start_jr0(). The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/crypto/fsl/jr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(

[U-Boot] [PATCH v2 1/1] tools/env: avoid memory leak in fw_setenv

If realloc fails we should release the old buffer. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2: Initial mail was garbled. --- tools/env/fw_env.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index 862a0b1a02..31c18d73bc

[U-Boot] [PATCH 1/1] musb: properly detect failed initialization of controller

We want to check the result of musb_init_controller and not the address were the result is stored. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/usb/musb-new/musb_uboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb-new/musb_u

[U-Boot] [PATCH] ddr: fsl: incorrect logical constraint in populate_memctl_options

(pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40) is always true. We should use && here. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/ddr/fsl/options.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[U-Boot] [RFC 1/1] omap3: incorrect logical check in do_emif4_init

((readl(_base->sdram_iodft_tlgc) & (1<<10)) == 0x01) is always false. This does not match the comment /*Wait till that bit clears*/ The problem was indicated by cppcheck. I do not have the hardware to test if the code change below leads to a correct system behavior. Signed-off

[U-Boot] [PATCH] arm: omap-common: add missing va_end()

Each call of va_start must be matched by a call of va_end. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- arch/arm/mach-omap2/sec-common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/sec-common.c b/arch/arm/mach-omap2/sec-common.c

[U-Boot] [RFC 1/1] usb: musb: avoid out of bound access in udc_setup_ep

For id = 15 an out of bound access occurs in udc_setup_ep(). Increase the size of epinfo[] from 30 to 32 to encompass ids 0..15. The problem was highlighted by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- I have no hardware for testing the patch. Please,

[U-Boot] [PATCH 1/1] fsl/sata: correctly identify failed malloc

After allocating sata->cmd_hdr_tbl_offset we have to check this variable and not variable sata. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/block/fsl_sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [U-Boot] [PATCH v7 0/4] mmc: meson: add MMC driver for Meson GX (S905)

On 04/14/2017 12:49 PM, Jaehoon Chung wrote: > Hi Heinrich, > > On 04/14/2017 07:26 PM, Heinrich Schuchardt wrote: >> This patch series is a resubmission of the v6 patch series >> https://lists.denx.de/pipermail/u-boot/2017-February/281941.html >> by Heiner Kall

[U-Boot] [PATCH 1/1] odroid-c2: enable MMC as boot target

To enable booting from MMC the MMC devices 0 and 1 are added to the BOOT_TARGET_DEVICES. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- This is a resubmission of https://lists.denx.de/pipermail/u-boot/2017-April/287315.html where this patch was part of patch series

[U-Boot] [PATCH v7 2/4] mmc: meson: add MMC driver for Meson GX (S905)

suse.de> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Tested-by: Heinrich Schuchardt <xypron.g...@gmx.de> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v7: no change v6: - remove DM_MMC_OPS from Kconfig dependencies - address two minor review comments of Ja

[U-Boot] [PATCH v7,4/4] odroid-c2: enable MMC as boot target

To enable booting from MMC the MMC devices 0 and 1 are added to the BOOT_TARGET_DEVICES. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v7: - added this patch to patch series --- include/configs/meson-gxbb-common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/i

[U-Boot] [PATCH v7 0/4] mmc: meson: add MMC driver for Meson GX (S905)

. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> Heiner Kallweit (2): mmc: meson: add MMC driver for Meson GX (S905) arm: dts: update Meson GXBB / Odroid-C2 DT with latest Linux version Heinrich Schuchardt (2): Enable new Meson GX MMC driver in Odroid C2 defconfig. odroid-c2:

[U-Boot] [PATCH 1/1] odroid-c2: increase CONFIG_SYS_BOOTM_LEN

A feature rich Kernel for Linux needs more than 8 MiB. Hence enlarge CONFIG_SYS_BOOTM_LEN to 64 MiB for the Odroid C2. As the Odroid C2 has has 2 GiB of RAM this poses no problem. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- include/configs/meson-gxbb-common.h | 2 ++

[U-Boot] [PATCH v7 1/4] arm: dts: update Meson GXBB / Odroid-C2 DT with latest Linux version

faer...@suse.de> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Tested-by: Heinrich Schuchardt <xypron.g...@gmx.de> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v7: - no changes v6: - changed prefix in subject v5: - no changes v4: - Added SoB of original aut

[U-Boot] [U-Boot, v7, 3/4] Enable new Meson GX MMC driver in Odroid C2 defconfig.

This patch is based on [U-Boot,v6,3/3] odroid-c2: enable new Meson GX MMC driver in board defconfig by Heiner Kallweit <hkallwe...@gmail.com> CC: Heiner Kallweit <hkallwe...@gmail.com> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v7: - made applicable to curren

Re: [U-Boot] [PATCH 1/1] odroid-c2: enable MMC as boot target

On 04/14/2017 03:42 PM, Andreas Färber wrote: > Am 14.04.2017 um 13:46 schrieb Heinrich Schuchardt: >> To enable booting from MMC the MMC devices 0 and 1 are added to the > > from eMMC > >> BOOT_TARGET_DEVICES. >> >> Signed-off-by: Hei

Re: [U-Boot] [PATCH 1/1] odroid-c2: enable MMC as boot target

On 04/14/2017 03:55 PM, Andreas Färber wrote: > Am 14.04.2017 um 15:50 schrieb Heinrich Schuchardt: >> On 04/14/2017 03:42 PM, Andreas Färber wrote: >>> Am 14.04.2017 um 13:46 schrieb Heinrich Schuchardt: >>>> To enable booting from MMC the MMC devices 0 and 1 are

[U-Boot] [PATCH v2 1/1] odroid-c2: enable MMC as boot target

To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 are added to the BOOT_TARGET_DEVICES. Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled. Cc: Andreas Färber <afaer...@suse.de> Signed-off-by: Heinrich Schu

Re: [U-Boot] [PATCH v2 1/1] core/uclass: iterate over all devices of a uclass

On 04/19/2017 04:28 PM, Simon Glass wrote: > Hi Heinrich, > > On 19 April 2017 at 05:26, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: >> When iterating over the devices of an uclass the iteration stops >> at the first device that cannot be probed. >> Whe

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

ath); > } > +printf("Setting boot device name to '%s'\n", devname); > ascii2unicode(bootefi_image_path[0].str, devname); > } > diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c > index 1e3dca4..f83fa0e 100644 > --- a/lib/efi_loader/efi_dis

[U-Boot] [PATCH v3 1/1] meson: gxbb: enable MMC as boot target

To enable automatic booting from SD card or eMMC the MMC devices 0, 1, and 2 are added to the BOOT_TARGET_DEVICES. Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled. Cc: Andreas Färber <afaer...@suse.de> Signed-off-by: He

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

On 04/15/2017 10:34 PM, Andreas Färber wrote: > Am 15.04.2017 um 20:27 schrieb Alexander Graf: >> On 15.04.17 20:18, Heiner Kallweit wrote: >>> Am 15.04.2017 um 17:05 schrieb Andreas Färber: But for the Vega S95 Telos I needed to disable the first of three MMC nodes (SDIO) - otherwise

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

anning disk m...@74000.blk... > Adding disk device 'm...@74000.blk' > Found 2 disks > > Regards, > Andreas > By adding sd_mmc_a to the odroid-c2.dts I was able to reproduce the problem on the Odroid C2. While booting from SD card via booti still worked bootefi would not find any block dev

Re: [U-Boot] [PATCH] x86: zImage: avoid potential NULL dereference

On 04/15/2017 06:12 PM, Tom Rini wrote: > On Sat, Apr 15, 2017 at 03:58:55PM +0200, Heinrich Schuchardt wrote: > >> If bootargs is not assigned getenv("bootargs") will >> return NULL. >> Some part of the code is checking for this condition. >> Other p

[U-Boot] [PATCH 1/1] odroid-c2: README: MMC is supported

Mention eMMC and microSD as supported devices. They have been enabled with patch d0c5c8d529f16fa88ab52a3b5dd2d4fc03664f19 odroid-c2: enable new Meson GX MMC driver in board defconfig which was accepted for u-boot-mmc.git. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- Po

[U-Boot] [PATCH] FPGA: drivers/fpga/ivm_core.c: incorrect printf

The number of arguments for printf does not match the format string. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/fpga/ivm_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/ivm_core.c b/d

[U-Boot] [PATCH 1/1] core/uclass: uclass_get_device_tail: always set devp

.html For testing I used an odroid-c2 with a dts including _emmc_a { status = "okay"; } This device does not exist on the board and cannot be initialized. Reported-by: Andreas Färber <afaer...@suse.de> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- dri

Re: [U-Boot] [PATCH v2 1/1] core/uclass: iterate over all devices of a uclass

; >>>>>> On 19 April 2017 at 08:43, Andreas Färber <afaer...@suse.de> wrote: >>>>>>> Hi Simon, >>>>>>> >>>>>>> Am 19.04.2017 um 16:28 schrieb Simon Glass: >>>>>>>> On 19 April 2017 at

[U-Boot] [PATCH v2 1/1] core/uclass: iterate over all devices of a uclass

they find the first device that can be probed or the end of the device list is reached. Debug output is provided for the two functions. Reported-by: Andreas Färber <afaer...@suse.de> Cc: Simon Glass <s...@chromium.org> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> ---

Re: [U-Boot] [U-Boot,v2] odroid-c2: Enable distro boot

On 04/22/2017 03:10 PM, Andreas Färber wrote: > Hi, > > Am 22.04.2017 um 14:59 schrieb Heinrich Schuchardt: >> On 01/15/2017 07:52 PM, Andreas Färber wrote: >>> Use the generic "distro" boot framework to enable automatic DHCP boot. >>> >>> The

Re: [U-Boot] [U-Boot,v2] odroid-c2: Enable distro boot

On 04/22/2017 03:10 PM, Andreas Färber wrote: > Hi, > > Am 22.04.2017 um 14:59 schrieb Heinrich Schuchardt: >> On 01/15/2017 07:52 PM, Andreas Färber wrote: >>> Use the generic "distro" boot framework to enable automatic DHCP boot. >>> >>> The

Re: [U-Boot] [U-Boot,v2] odroid-c2: Enable distro boot

On 04/22/2017 05:47 PM, Andreas Färber wrote: > Am 22.04.2017 um 16:19 schrieb Heinrich Schuchardt: >> On 04/22/2017 03:10 PM, Andreas Färber wrote: >>> Am 22.04.2017 um 14:59 schrieb Heinrich Schuchardt: >>>> On 01/15/2017 07:52 PM, Andreas Färber wrote: >&

Re: [U-Boot] [PATCH v2 1/1] core/uclass: iterate over all devices of a uclass

On 04/23/2017 04:10 AM, Simon Glass wrote: > Hi Heinrick, > > On 19 April 2017 at 05:26, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: >> When iterating over the devices of an uclass the iteration stops >> at the first device that cannot be probed. >> Whe

[U-Boot] [PATCH 1/1] odroid-c2: make fdtfile conform with README.pxe

a vendor directory prefixed to ftddir: hikey_defconfig: fdtfile=hi6220-hikey.dtb dragonboard410c_defconfig: fdtfile=apq8016-sbc.dtb pine64_plus_defconfig: fdtfile=sun50i-a64-pine6-plus.dtb Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- include/configs/odroid-c2.h | 2 +- 1 file c

Re: [U-Boot] [PATCH v6 1/3] arm: dts: update Meson GXBB / Odroid-C2 DT with latest Linux version

/xypron/u-boot-odroid-c2/ together with my Makefile. Heiner, are you planning to update your patch series? Or should I retest against the next branch of u-boot and submit myself? Best regards Heinrich Schuchardt ___ U-Boot mailing list U-Boot

[U-Boot] [PATCH v2 1/1] meson: gxbb: change ramdisk_addr_r

me address. With the patch booting Linux with booti succeeds on an Odroid C2, without the patch Linux hangs. Cc: Andreas Färber <afaer...@suse.de> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2: Title and commit message changed to reflect that this patch applies to all

[U-Boot] [PATCH v2 1/1] meson: gxbb: increase CONFIG_SYS_BOOTM_LEN

A feature rich Linux kernel needs more than 8 MiB. Hence enlarge CONFIG_SYS_BOOTM_LEN to 64 MiB for the GXBB systems. As all known GXBB systems have at least 512 MiB of RAM this poses no problem. Cc: Andreas Färber <afaer...@suse.de> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.d

[U-Boot] [PATCH 1/1] odroid-c2: change ramdisk_addr_r

-odroid-c2-20160815.img.xz http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb So let's use the same address. With the patch booting Linux with booti succeeds, without the patch Linux hangs. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- include/co

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

On 04/16/2017 09:34 PM, Simon Glass wrote: > Hi Alex, > > On 16 April 2017 at 04:08, Alexander Graf <ag...@suse.de> wrote: >> >> >> On 16.04.17 04:09, Heinrich Schuchardt wrote: >>> >>> On 04/15/2017 11:51 PM, Andreas Färber wrote: >

Re: [U-Boot] [PATCH 1/1] core/uclass: uclass_get_device_tail: always set devp

On 04/19/2017 05:37 AM, Simon Glass wrote: > Hi, > > On 18 April 2017 at 21:03, Andreas Färber <afaer...@suse.de> wrote: >> Hi Simon, >> >> Am 19.04.2017 um 02:12 schrieb Simon Glass: >>> On 18 April 2017 at 12:44, Heinrich Schuchardt <xypron.g...

Re: [U-Boot] [PATCH v2 2/7] efi_loader: implement multiple event support

On 07/28/2017 06:19 AM, Simon Glass wrote: > Hi, > > On 18 July 2017 at 12:17, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: >> Up to now the boot time supported only a single event. >> This patch now allows four events. >> >> Signed-off-by: Heinrich Schuc

Re: [U-Boot] [PATCH] efi_loader: add some missing breaks

case DEVICE_PATH_SUB_TYPE_FILE_PATH: > @@ -63,6 +64,7 @@ static uint16_t *efi_convert_device_node_to_text( > memcpy(buffer, device_node->data, buffer_size); > break; > } > + break; > } > &

Re: [U-Boot] [PATCH] vsprintf.c: add wide string (%ls) support

On 08/02/2017 08:15 PM, Rob Clark wrote: > On Wed, Aug 2, 2017 at 1:05 PM, Heinrich Schuchardt <xypron.g...@gmx.de> > wrote: >> On 08/02/2017 11:38 AM, Rob Clark wrote: >>> On Tue, Aug 1, 2017 at 10:22 PM, Heinrich Schuchardt <xypron.g...@gmx.de> >>> wro

Re: [U-Boot] [PATCH] vsprintf.c: add wide string (%ls) support

On 07/31/2017 02:42 PM, Rob Clark wrote: > This is convenient for efi_loader which deals a lot with utf16. > > Signed-off-by: Rob Clark > --- > lib/vsprintf.c | 39 +-- > 1 file changed, 37 insertions(+), 2 deletions(-) > > diff --git

Re: [U-Boot] [PATCH] efi_loader: make pool allocations cacheline aligned

On 08/01/2017 10:00 PM, Rob Clark wrote: > This avoids printf() spam about file reads (such as loading an image) > into unaligned buffers (and the associated memcpy()). And generally > seems like a good idea. > > Signed-off-by: Rob Clark > --- > lib/efi_loader/efi_memory.c

[U-Boot] [RFC] C2011 standard for building U-Boot

Hello Tom, for the UEFI implementation of U-Boot it would make defining string constants much easier using the following C 2011 notation: u16 *foo = u"My lovely string"; Do you see any reason forcing us not to use features of C 2011? In /Makefile I found the following: ifeq ($(HOSTOS),cygwin)

[U-Boot] Custodian Albert Aribaud not reachable by mail

Hello Tom, mail for Albert Aribaud cannot be delivered since a few weeks. See appendix. Could you, please, update the MAINTAINERS file either with Albert's new address or with the future maintainer for arch/arm/. Hopefully somebody at Denx has current contact data.

[U-Boot] [PATCH 1/1] efi_loader: allow return value in EFI_CALL

Macro EFI_CALL was introduced to call an UEFI function. Unfortunately is did not support return values. Most UEFI functions have a return value. So let's rename EFI_CALL to EFI_CALL_VOID and introduce a new EFI_CALL macro that supports return values. Signed-off-by: Heinrich Schuchardt <xypro

Re: [U-Boot] [PATCH 4/5] vsprintf.c: add GUID printing

#endif > +#ifdef CONFIG_LIB_UUID > + case 'U': > + return uuid_string(buf, end, ptr, field_width, precision, > +flags, fmt); > +#endif > + default: > + break; > + } > flags |= SMALL; > if (field_width == -1) { > field_width = 2*sizeof(void *); > Successfully tested printing using %pUl with a patch under development on arm64. Tested-by: Heinrich Schuchardt <xypron.g...@gmx.de> ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/3] efi_loader: open_info in OpenProtocol, CloseProtocol

On 08/12/2017 03:37 PM, Alexander Graf wrote: > > > On 05.08.17 22:32, Heinrich Schuchardt wrote: >> efi_open_protocol and close_protocol have to keep track of >> opened protocols. >> >> So we add an array open_info to each protocol of each handle. >>

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

On 08/13/2017 12:45 PM, Rob Clark wrote: > Introduce directory traversal iterators, and implement fs_readdir() > which is needed by EFI_LOADER. > > The part re-working fat.c to use the directory iterators itself is > nearly a 2:1 negative diffstat, and a pretty big cleanup. I fixed > one or two

Re: [U-Boot] [PATCH v3 3/3] efi_loader: implement OpenProtocolInformation

On 08/13/2017 09:24 PM, Alexander Graf wrote: > > > On 13.08.17 13:17, Heinrich Schuchardt wrote: >> On 08/12/2017 03:38 PM, Alexander Graf wrote: >>> >>> >>> On 05.08.17 22:32, Heinrich Schuchardt wrote: >>>> efi_open_protocol_information

Re: [U-Boot] [PATCH v1 13/15] efi_loader: make pool allocations cacheline aligned

On 08/10/2017 08:29 PM, Rob Clark wrote: > This avoids printf() spam about file reads (such as loading an image) > into unaligned buffers (and the associated memcpy()). And generally > seems like a good idea. > > Signed-off-by: Rob Clark > --- > lib/efi_loader/efi_memory.c

Re: [U-Boot] [PATCH v3 1/3] efi_loader: write protocol GUID in OpenProtocol

On 08/11/2017 12:11 PM, Alexander Graf wrote: > > > On 05.08.17 21:32, Heinrich Schuchardt wrote: >> To understand what happens in OpenProtocol it is necessary to know >> the protocol interface GUID. Let's write a debug message. >> >> Using uuid_g

Re: [U-Boot] [PATCH v1 05/15] efi_loader: add device-path utils

On 08/10/2017 08:29 PM, Rob Clark wrote: > Helpers to construct device-paths from devices, partitions, files, and > for parsing and manipulating device-paths. > > For non-legacy devices, this will use u-boot's device-model to construct > device-paths which include bus hierarchy to construct

Re: [U-Boot] [PATCH v1 13/15] efi_loader: make pool allocations cacheline aligned

On 08/11/2017 07:27 PM, Rob Clark wrote: > On Fri, Aug 11, 2017 at 12:58 PM, Heinrich Schuchardt > <xypron.g...@gmx.de> wrote: >> On 08/10/2017 08:29 PM, Rob Clark wrote: >>> This avoids printf() spam about file reads (such as loading an image) >>> into unaligne

Re: [U-Boot] [PATCH v1 03/15] part: extract MBR signature from partitions

Hello Rob, I couldn't apply your patch to either of u-boot/agraf/efi-next nor u-boot/master Applying: part: extract MBR signature from partitions error: patch failed: include/blk.h:62 error: include/blk.h: patch does not apply Patch failed at 0001 part: extract MBR signature from partitions

Re: [U-Boot] [PATCH v1 01/15] fs: add fs_readdir()

On 08/10/2017 08:29 PM, Rob Clark wrote: > Needed to support efi file protocol. The fallback.efi loader wants > to be able to read the contents of the /EFI directory to find an OS > to boot. > > Also included is an ls2 command which implements ls on top of > fs_readdir(), to more easily test the

Re: [U-Boot] [PATCH v1 13/15] efi_loader: make pool allocations cacheline aligned

On 08/11/2017 07:27 PM, Rob Clark wrote: > On Fri, Aug 11, 2017 at 12:58 PM, Heinrich Schuchardt > <xypron.g...@gmx.de> wrote: >> On 08/10/2017 08:29 PM, Rob Clark wrote: >>> This avoids printf() spam about file reads (such as loading an image) >>> into unaligne

[U-Boot] [PATCH 1/1] efi_loader: attribute EFIAPI of efi_locate handle()

efi_locate_handle is called internally so it should not be marked as EFIAPI. The external function is efi_locate_handle_ext. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- @Alex Please, pull this patch after [PATCH v2] efi_loader: LocateHandle should return EFI_NOT_FOUND i

Re: [U-Boot] [PATCH v1 13/15] efi_loader: make pool allocations cacheline aligned

On 08/10/2017 08:29 PM, Rob Clark wrote: > This avoids printf() spam about file reads (such as loading an image) > into unaligned buffers (and the associated memcpy()). And generally > seems like a good idea. > > Signed-off-by: Rob Clark > --- > lib/efi_loader/efi_memory.c

[U-Boot] [PATCH 1/1] efi_loader: use EFI_PAGE_SIZE instead of 4096

We should use constant EFI_PAGE_SIZE instead of 4096 where the coding relies on 4096 being EFI_PAGE_SIZE. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- cmd/bootefi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c

[U-Boot] [PATCH 1/1] efi_loader: use EFI_PAGE_MASK instead of EFI_PAGE_SIZE - 1

We should be consistent in the way we calculate page sizes. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- lib/efi_loader/efi_runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index dd52

Re: [U-Boot] [PATCH v3 3/3] efi_loader: implement OpenProtocolInformation

On 08/12/2017 03:38 PM, Alexander Graf wrote: > > > On 05.08.17 22:32, Heinrich Schuchardt wrote: >> efi_open_protocol_information provides the agent and controller >> handles as well as the attributes and open count of an protocol >> on a handle. >> >

Re: [U-Boot] [PATCH 1/1] efi_loader: disk: iterate only over valid block devices

On 07/03/2017 06:07 PM, Alexander Graf wrote: > On 07/03/2017 05:34 PM, Simon Glass wrote: >> Hi Alex, >> >> On 3 July 2017 at 06:37, Alexander Graf <ag...@suse.de> wrote: >>> On 06/20/2017 09:39 PM, Andreas Färber wrote: >>>> Am

[U-Boot] [PATCH 3/4] efi_loader: debug info in efi_convert_device_path_to_text

The debug information provided by efi_convert_device_path_to_text is insufficient. The type and the subtype are needed to find out why the function did not support a conversion. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- lib/efi_loader/efi_device_path_to_text.c | 3 +++

[U-Boot] [PATCH 4/4] efi_loader: parameter check efi_convert_device_path_to_text

Do not dereference NULL. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- lib/efi_loader/efi_device_path_to_text.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index 746b34a377..81a6

[U-Boot] [PATCH 0/4] efi_convert_device_path_to_text

debug output. The 4th patch adds a missing parameter check. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> Heinrich Schuchardt (4): efi_loader: do not duplicate constants for device path efi_loader: DevicePathToText for MAC address efi_loader: debu

[U-Boot] [PATCH v2 0/5] efi_convert_device_path_to_text

parameter check. The 4th patch supplies additional debug output. The 5th patch moves the declarations to the beginning of the function efi_convert_device_path_to_text. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 Switch patch 3 and 4. Put debug statement

[U-Boot] [PATCH v2 5/5] efi_loader: DevicePathToText put declarations first

Variables should be declared before the first executable statement. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 new patch --- lib/efi_loader/efi_device_path_to_text.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_

[U-Boot] [PATCH v2 1/5] efi_loader: do not duplicate constants for device path

We should not duplicate existing constants used by the device path protocol. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 no change --- lib/efi_loader/efi_device_path_to_text.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/efi_

[U-Boot] [PATCH 1/1] efi_loader: implement ProtocolsPerHandle

Boot service ProtocolsPerHandle is implemented in efi_protocols_per_handle. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- lib/efi_loader/efi_boottime.c | 46 ++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/lib/efi_

[U-Boot] [PATCH v2 3/5] efi_loader: parameter check efi_convert_device_path_to_text

Do not dereference NULL. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 no change --- lib/efi_loader/efi_device_path_to_text.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_

[U-Boot] [PATCH v2 2/5] efi_loader: DevicePathToText for MAC address

Implement DevicePathToText MAC address device path. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 no change --- lib/efi_loader/efi_device_path_to_text.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/lib/efi_

[U-Boot] [PATCH v2 4/5] efi_loader: debug info in efi_convert_device_path_to_text

The debug information provided by efi_convert_device_path_to_text is insufficient. The type and the subtype are needed to find out why the function did not support a conversion. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 debug statement has to be after parameter

Re: [U-Boot] [PATCH 1/3] efi_loader: implement multiple event support

On 07/16/2017 09:25 AM, Alexander Graf wrote: > > > On 15.07.17 13:43, Heinrich Schuchardt wrote: >> On 07/12/2017 12:55 PM, Alexander Graf wrote: >>> >>> >>> On 05.07.17 19:47, Heinrich Schuchardt wrote: >>>> Up to now the boot time supporte

[U-Boot] [PATCH v2 02/12] efi_loader: efi_open_protocol: parameter checks

Add all parameter checks for function efi_open_protocol that do not depend on a locking table. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 no change --- lib/efi_loader/efi_boottime.c | 31 +++ 1 file changed, 27 insertions(+), 4 del

[U-Boot] [PATCH v2 03/12] efi_loader: implement InstallProtocolInterface

efi_install_protocol_interface up to now only returned an error code. The patch implements the UEFI specification for InstallProtocolInterface with the exception that it will not create new handles. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 Correctly check

[U-Boot] [PATCH v2 05/12] efi_loader: refactor efi_install_protocol_interface

For the implementation of InstallMultipleProtocolInterfaces we need to call efi_install_protocol_interface. In internal calls we should not pass through EFI_EXIT. The patch introduces a wrapper function efi_install_protocol_interface_ext. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx

[U-Boot] [PATCH v2 10/12] efi_loader: provide a sufficient number of protocols

Four protocols per object is too few to run iPXE. Let's raise the number of protocols per object to eight. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 new patch --- include/efi_loader.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/i

[U-Boot] [PATCH v2 08/12] efi_loader: refactor efi_locate_handle

To implement LocateHandleBuffer we need to call efi_locate_handle internally without running through EFI_EXIT. So put EFI_ENTRY and EFI_EXIT into a new wrapper function efi_locate_handle_ext. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 no change --- lib/efi_

[U-Boot] [PATCH v2 04/12] efi_loader: implement UninstallProtocolInterface

Without the patch efi_uninstall_protocol_interface always returns an error. With the patch protocols without interface can be uninstalled. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 Check if protocol != NULL to avoid illegal memory access. --- lib/efi_

[U-Boot] [PATCH v2 09/12] efi_loader: implement LocateHandleBuffer

UEFI boot service LocateHandleBuffer is implemented by calling efi_allocate_handle and efi_locate_handle. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 no change --- lib/efi_loader/efi_boottime.c | 25 - 1 file changed, 24 insertions

[U-Boot] [PATCH v2 12/12] efi_loader: implement EFI_DEVICE_PATH_TO_TEXT_PROTOCOL

ConvertPathToText is implemented for * type 4- media device path * subtype 4 - file path This is the kind of device path we hand out for block devices. All other cases may be implemented later. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 new patch --

[U-Boot] [PATCH v2 07/12] efi_loader: implement InstallMultipleProtocolInterfaces

Implement InstallMultipleProtocolInterfaces in function efi_install_multiple_protocol_interfaces by repeatedly calling efi_install_protocol_interface. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 no change --- lib/efi_loader/efi_boottime.

[U-Boot] [PATCH v2 00/12] efi_loader: protocol services

increases the number of protocols per handle. The 11th patch reimplements efi_locate_protocol. The 12th patch implements the device path to text protocol. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 Remove implementation of efi_return_handle in 1st

[U-Boot] [PATCH v2 06/12] efi_loader: refactor efi_uninstall_protocol_interface

For the implementation of UninstallMultipleProtocolInterfaces we need to call efi_uninstall_protocol_interface. In internal calls we should not pass through EFI_EXIT. The patch introduces a wrapper function efi_uninstall_protocol_interface_ext. Signed-off-by: Heinrich Schuchardt <xypro

[U-Boot] [PATCH v2 11/12] efi_loader: reimplement efi_locate_protocol

The UEFI specification requires that LocateProtol finds the first handle supporting the protocol and to return a pointer to its interface. So we have to assign the protocols to an efi_object and not use any separate storage. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>

[U-Boot] [PATCH v2 01/12] efi_loader: refactor efi_open_protocol

is stored in the list of installed protocols of an efi_object instead of an open function. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- v2 Remove implementation of efi_return_handle. --- cmd/bootefi.c | 14 +++--- include/efi_lo

Re: [U-Boot] [RFC] efi_loader: memory leak in bootefi

On 07/06/2017 05:52 PM, Alexander Graf wrote: > Hi Heinrich, > > On 07/06/2017 05:43 PM, Heinrich Schuchardt wrote: >> Hello Alex, >> >> in bootefi.c do_bootefi_exec we build the efi_obj_list. This includes >> allocation of memory for some handlers (e.g.

[U-Boot] [PATCH 1/1] efi_memory: avoid NULL dereference in efi_free_pool

If efi_free_pool is called with argument NULL an illegal memory access occurs. So let's check the parameter on entry. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- lib/efi_loader/efi_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/efi_loader/efi_memory.c

Re: [U-Boot] [PATCH 1/3] efi_loader: implement multiple event support

On 07/12/2017 12:55 PM, Alexander Graf wrote: > > > On 05.07.17 19:47, Heinrich Schuchardt wrote: >> Up to now the boot time supported only a single event. >> This patch now allows four events. >> >> Signed-off-by: Heinrich Schuchardt <xypron.g...@g

Re: [U-Boot] [PATCH v2 01/12] efi_loader: refactor efi_open_protocol

Hello Alex, I had no problem compiling against efi-next yesterday. It contains the patch. Where can I find the git tree that does not compile? Best regards Heinrich Schuchardt Am 18.07.17 um 15:12 schrieb Alexander Graf > On 07/11/2017 10:06 PM, Heinrich Schuchardt wr

Re: [U-Boot] [PATCH v2 01/12] efi_loader: refactor efi_open_protocol

On 07/18/2017 03:12 PM, Alexander Graf wrote: > On 07/11/2017 10:06 PM, Heinrich Schuchardt wrote: >> efi_open_protocol was implemented to call a protocol specific open >> function to retrieve the protocol interface. >> >> The UEFI specification does

  1   2   3   4   5   6   7   8   9   10   >