to quoted __section("foo").
Also convert __attribute__((section("foo"))) uses to __section("foo")
even if the __attribute__ has multiple list entry forms.
Signed-off-by: Marek Behún
---
arch/arm/cpu/arm926ejs/spear/spl.c| 2 +-
arch/arm/cpu/armv7/ls102xa/ls102x
reference to `memcpy'
.../uuid.c:206: more undefined references to `memcpy' follow
Make memcpy() and memset() visible by using the __used macro to avoid
this error.
Signed-off-by: Marek Behún
---
lib/string.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/string.c b/lib
Use the `externally_visible` attribute to declare binman symbols
externally visible, so that when building with LTO the compiler does not
optimize this data away.
Signed-off-by: Marek Behún
---
include/binman_sym.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include
Use the __ADDRESSABLE() macro to make entries and lists declared by
ll_entry_declare() and ll_entry_declare_list() addressable so that when
building with LTO the compiler does not optimize this data away.
Signed-off-by: Marek Behún
---
include/linker_lists.h | 8 ++--
1 file changed, 6
Indent the linking commands so that they look cosmetically better.
Signed-off-by: Marek Behún
---
Makefile | 12 +++-
scripts/Makefile.spl | 15 +--
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile
index 68ce5195b2..7b0ba9df9a
Add plumbing for building U-Boot with Link Time Optimizations.
Signed-off-by: Marek Behún
---
Kbuild | 2 ++
Kconfig | 19 +++
Makefile | 36
scripts/Makefile.lib | 3 +++
scripts/Makefile.spl | 14
to use the P flag for ar, otherwise final linking may fail.
Signed-off-by: Marek Behún
---
Makefile | 4 ++--
arch/sandbox/config.mk | 10 +++---
scripts/Makefile.build | 16
scripts/Makefile.spl | 4 ++--
4 files changed, 19 insertions(+), 15 deletions
in order to fix this.
Signed-off-by: Marek Behún
---
lib/crc32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/crc32.c b/lib/crc32.c
index e9be3bf386..c033449cff 100644
--- a/lib/crc32.c
+++ b/lib/crc32.c
@@ -88,7 +88,7 @@ static void __efi_runtime make_crc_table(void
When building with LTO, move $(PLATFORM_LIBS) into the --start-group /
--end-group list.
Otherwise some functions declared in assembly may not be resolved and
linking may fail.
Signed-off-by: Marek Behún
---
Makefile | 3 ++-
scripts/Makefile.spl | 3 ++-
2 files changed, 4
in
/tmp/u-boot.EQlEXz.ltrans0.ltrans.o
To avoid this conflict use different asm label for this variable when
CONFIG_SANDBOX is enabled.
Signed-off-by: Marek Behún
---
include/errno.h | 8 +++-
lib/errno.c | 4 +++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include
’ was
previously declared here
7 | char __efi_runtime_start[0] __attribute__((section(".__efi_run
| ^
Change the type to char[] in include/efi_loader.h.
Signed-off-by: Marek Behún
---
include/efi_loader.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/in
Enable LTO for some boards that were tested by people on U-Boot Mailing
List.
Signed-off-by: Marek Behún
Tested-by: Adam Ford
Tested-by: Pali Rohár
---
configs/da850evm_defconfig| 1 +
configs/da850evm_direct_nor_defconfig | 1 +
configs/da850evm_nand_defconfig | 1
When building with LTO, using -ffunction-sections/-fdata-sections is not
useful anymore.
Signed-off-by: Marek Behún
---
arch/arm/config.mk | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/config.mk b/arch/arm/config.mk
index 4153f7e371..2b2c6ad2e5 100644
here
CI managed to trigger this as an error when compiling with LTO for AXP.
Fix this by using values from the header files, which seem to be the
correct ones.
Signed-off-by: Marek Behún
---
drivers/ddr/marvell/axp/ddr3_dfs.c | 4 ++--
drivers/ddr/marvell/axp
For some reason when building SPL for ARMv8 with LTO, the relocation
information is not discarded.
Discard it explicitly in the linker script.
This fixes LTO build for imx8mm_venice_defconfig.
Signed-off-by: Marek Behún
---
arch/arm/cpu/armv8/u-boot-spl.lds | 1 +
1 file changed, 1 insertion
therefore should not (hopefully) cause regression
when applied.
Marek
Marek Behún (39):
ddr: marvell: axp: align signature of mv_xor_mem_init() with a38x
ddr: marvell: axp: fix array types have different bounds warning
regmap: fix a serious pointer casting bug
api: fix a potential serious
-by: Marek Behún
Reviewed-by: Stefan Roese
---
drivers/ddr/marvell/axp/xor.c | 4 ++--
drivers/ddr/marvell/axp/xor.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/ddr/marvell/axp/xor.c b/drivers/ddr/marvell/axp/xor.c
index 17bfe6a7bf..76aea96682 100644
--- a/drivers
Adam Ford says that DM3730 needs board.c compiled without LTO flags.
Also add clock.c, since it says in Makefile that it need different
flags.
Signed-off-by: Marek Behún
Suggested-by: Adam Ford
---
arch/arm/mach-omap2/omap3/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch
actually passes an int variable into the function (so it is implicitly
converted to u8).
Change the type of this parameter to int in drivers/ata/ahci.c.
Signed-off-by: Marek Behún
---
drivers/ata/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.c b
-off-by: Marek Behún
---
arch/arm/mach-rockchip/board.c| 2 +-
board/samsung/common/exynos5-dt.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c
index c386b52987..5304eb055c 100644
--- a/arch/arm/mach-rockchip
Make LTO available for ARM architecture.
Signed-off-by: Marek Behún
---
arch/Kconfig | 1 +
arch/arm/lib/Makefile | 2 ++
2 files changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index b884b7b248..bf4b8afcb4 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -33,6 +33,7
Build ARM targets with LTO by default.
Signed-off-by: Marek Behún
---
arch/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index bf4b8afcb4..d0f5a16b95 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -37,6 +37,7 @@ config ARM
select
Make LTO available for sandbox architecture.
Signed-off-by: Marek Behún
---
arch/Kconfig | 1 +
arch/sandbox/config.mk | 2 ++
2 files changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 27843cd79c..a6dab3e56d 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -101,6
it thinks that array is empty (start and end
symbols are at the same address).
Signed-off-by: Marek Behún
---
arch/sandbox/cpu/os.c | 3 ++-
arch/sandbox/cpu/start.c| 3 ++-
arch/sandbox/cpu/u-boot-spl.lds | 8 +---
arch/sandbox/cpu/u-boot.lds | 8
Build sandbox targets with LTO by default.
Signed-off-by: Marek Behún
---
arch/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index a6dab3e56d..b884b7b248 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -123,6 +123,7 @@ config SANDBOX
select
When imx28_xea_defconfig is built with LTO, the compiler complains about
the two different declarations of _start:
include/asm-generic/sections.has extern void _start(void);
arch/arm/cpu/arm926ejs/mxs/mxs.c as extern uint32_t _start;
Fix this.
Signed-off-by: Marek Behún
---
arch
-by: Marek Behún
---
arch/arm/cpu/arm926ejs/Makefile | 2 ++
arch/arm/lib/Makefile | 1 +
2 files changed, 3 insertions(+)
diff --git a/arch/arm/cpu/arm926ejs/Makefile b/arch/arm/cpu/arm926ejs/Makefile
index af63d5cc5e..98aafe805a 100644
--- a/arch/arm/cpu/arm926ejs/Makefile
+++ b/arch/arm/cpu
The Thumb instruction `ldr` is able to move high registers only from
armv7. For armv5 and armv6 we have to use `mov`.
Signed-off-by: Marek Behún
---
arch/arm/include/asm/global_data.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/global_data.h
b
blk_dwrite(struct blk_desc *block_dev, lbaint_t st
| ^
Signed-off-by: Marek Behún
---
include/api_public.h | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/include/api_public.h b/include/api_public.h
index def103ce22..5a4465ea89
here
CI managed to trigger this as an error when compiling with LTO for AXP.
Fix this by using values from the header files, which seem to be the
correct ones.
Signed-off-by: Marek Behún
---
drivers/ddr/marvell/axp/ddr3_dfs.c | 4 ++--
drivers/ddr/marvell/axp
This is how Linux does this now, see Linux commit 339f29d91acf.
Signed-off-by: Marek Behún
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 755f4802a4..fd1e9c4d24 100755
--- a/scripts/checkpatch.pl
symbol of the form
_u_boot_list_2_X_2_Y
also symbol
__UNIQUE_ID___addressable__u_boot_list_2_X_2_YN,
(where N at the end is some number).
In order to avoid matching these additional symbols, ensure that the
character before "_u_boot_list_2" is not a symbol name character.
Signed-off
blk_dwrite(struct blk_desc *block_dev, lbaint_t st
| ^
Signed-off-by: Marek Behún
---
include/api_public.h | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/include/api_public.h b/include/api_public.h
index def103ce22..5a4465ea89
the space so that we don't get invalid
result if regmap_raw_read() does not fill the whole object.
Signed-off-by: Marek Behún
Reviewed-by: Simon Glass
Reviewed-by: Heiko Schocher
---
drivers/core/regmap.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers
Prepare private macros expanding to linker list entry symbol name and
declaration to avoid nasty code repetition in the next patch.
We also avoid some code repetition in current code with these macros.
Signed-off-by: Marek Behún
---
include/linker_lists.h | 46
Use UNIQUE_ID in the __ADDRESSABLE macro.
Signed-off-by: Marek Behún
---
include/linux/compiler.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 82a8a4ede9..98dd3fc4cc 100644
--- a/include/linux/compiler.h
+++ b
For some reason when building SPL for ARMv8 with LTO, the relocation
information is not discarded.
Discard it explicitly in the linker script.
This fixes LTO build for imx8mm_venice_defconfig.
Signed-off-by: Marek Behún
---
arch/arm/cpu/armv8/u-boot-spl.lds | 1 +
1 file changed, 1 insertion
?id=68384
Signed-off-by: Marek Behún
---
arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 +-
arch/arm/include/asm/global_data.h| 2 +-
arch/arm/mach-exynos/spl_boot.c | 2 +-
arch/arm/mach-imx/imx8m/soc.c | 2 +-
arch/arm/mach-imx/spl_imx_romapi.c| 16
5 files
this by removing -flto for this file.
Signed-off-by: Marek Behún
---
arch/arm/mach-tegra/tegra20/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-tegra/tegra20/Makefile
b/arch/arm/mach-tegra/tegra20/Makefile
index faaf30d068..bb17c90cca 100644
--- a/arch/arm/mach-tegra/tegra20
When apf27_defconfig is built with LTO, linking complains about
undefined reference to `nand_boot`. This is because it is referenced
from inline assembly. Make it visible.
Signed-off-by: Marek Behún
---
drivers/mtd/nand/raw/mxc_nand_spl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
an implementation.
Change the type of this function in the implementation to fix this.
Signed-off-by: Marek Behún
---
arch/arm/mach-imx/imx8m/clock_imx8mm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mm.c
b/arch/arm/mach-imx/imx8m/clock_imx8mm.c
of this function to that of the other usages.
Signed-off-by: Marek Behún
---
arch/arm/cpu/armv7/kona-common/clk-stubs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv7/kona-common/clk-stubs.c
b/arch/arm/cpu/armv7/kona-common/clk-stubs.c
index 2dfa3f7e73..4eddaca887
When building keystone with LTO the compiler complains:
Error: selected processor does not support `smc #0' in Thumb mode
Fix this by removing -flto for the file implementing these SMC calls.
Signed-off-by: Marek Behún
---
arch/arm/mach-keystone/Makefile | 1 +
1 file changed, 1 insertion
into the section .rodata.efi_runtime, instead of
.data.efi_runtime.
Signed-off-by: Marek Behún
---
include/efi_loader.h | 2 ++
lib/crc32.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/efi_loader.h b/include/efi_loader.h
index a8281b3c95..b1e5d2e13e 100644
-by: Marek Behún
---
arch/arm/cpu/arm926ejs/Makefile | 2 ++
arch/arm/lib/Makefile | 1 +
2 files changed, 3 insertions(+)
diff --git a/arch/arm/cpu/arm926ejs/Makefile b/arch/arm/cpu/arm926ejs/Makefile
index af63d5cc5e..98aafe805a 100644
--- a/arch/arm/cpu/arm926ejs/Makefile
+++ b/arch/arm/cpu
the space so that we don't get invalid
result if regmap_raw_read() does not fill the whole object.
Signed-off-by: Marek Behún
---
drivers/core/regmap.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/core/regmap.c b/drivers/core/regmap.c
index b51ce108c1
-by: Marek Behún
---
drivers/ddr/marvell/axp/xor.c | 4 ++--
drivers/ddr/marvell/axp/xor.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/ddr/marvell/axp/xor.c b/drivers/ddr/marvell/axp/xor.c
index 17bfe6a7bf..76aea96682 100644
--- a/drivers/ddr/marvell/axp/xor.c
Add macro __efi_runtime_rodata, for const variables with similar purpose
as those using __efi_runtime_data.
Signed-off-by: Marek Behún
---
include/efi_loader.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/efi_loader.h b/include/efi_loader.h
index a8281b3c95..b1e5d2e13e 100644
into the section .rodata.efi_runtime, instead of
.data.efi_runtime, via macro __efi_runtime_rodata.
Signed-off-by: Marek Behún
---
lib/crc32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/crc32.c b/lib/crc32.c
index e9be3bf386..f2acc107fe 100644
--- a/lib/crc32.c
+++ b/lib
Indent the linking commands so that they look cosmetically better.
Signed-off-by: Marek Behún
---
Makefile | 12 +++-
scripts/Makefile.spl | 17 +++--
2 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile
index 68ce5195b2
into the section .rodata.efi_runtime, instead of
.data.efi_runtime, via macro __efi_runtime_rodata.
Signed-off-by: Marek Behún
Reviewed-by: Marek Vasut
---
lib/crc32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/crc32.c b/lib/crc32.c
index e9be3bf386..f2acc107fe 100644
Document the macros __efi_runtime and __efi_runtime_data in Sphinx
style.
Signed-off-by: Marek Behún
---
include/efi_loader.h | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/include/efi_loader.h b/include/efi_loader.h
index a8281b3c95
Add macro __efi_runtime_rodata, for const variables with similar purpose
as those using __efi_runtime_data.
Signed-off-by: Marek Behún
---
include/efi_loader.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/efi_loader.h b/include/efi_loader.h
index 696f80e9f3
On Mon, 8 Mar 2021 19:32:10 +0800
Bin Meng wrote:
> On Mon, Mar 8, 2021 at 7:18 PM Marek Behun wrote:
> >
> > On Mon, 8 Mar 2021 18:44:58 +0800
> > Bin Meng wrote:
> >
> > > Could you investigate why?
> >
> > I could, but I don't understand why exactly I should
> > - Linux is also using
On Mon, 8 Mar 2021 22:30:17 +0800
Bin Meng wrote:
> Hi Marek,
>
> On Mon, Mar 8, 2021 at 9:24 PM Marek Behún wrote:
> >
> > On Mon, 8 Mar 2021 19:32:10 +0800
> > Bin Meng wrote:
> >
> > > On Mon, Mar 8, 2021 at 7:18 PM Marek Behun
> > > w
t Baranwal
Tested-by: sa_ip-sw-jenkins
Reviewed-by: Sujeet Kumar Baranwal
Reviewed-by: Nadav Haklai
Signed-off-by: Marek Behún
---
Stefan, last time I overlooked this commit.
I am sending it as part of series 2, since it can be applied on top of
it.
With the first 18 patches the SPL b
to ensure that NOT_COMBINED
has value zero.
Signed-off-by: heaterC
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/ddr_topology_def.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ddr/marvell/a38x/ddr_topology_def.h
b/drivers/ddr/ma
The code was processed with unifdef utility to omit portions not
relevant to A38x and DDR3. This removes usage of many macros, including
A70X0, A80X0 and A3900. It seems that the unifdef utility did not remove
the macros from #else comment.
Signed-off-by: Marek Behún
Tested-by: Chris Packham
14.0.0 is newer than 18.12.0.
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/mv_ddr_build_message.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ddr/marvell/a38x/mv_ddr_build_message.c
b/drivers/ddr/marvell/a38x
On Fri, 19 Feb 2021 08:38:48 +0100
Stefan Roese wrote:
> Hi Marek,
>
> On 18.02.21 20:56, Marek Behun wrote:
> > Chris put his Tested-by on this series and noone else replyied to
> > it. What do you think about this?
>
> How about the issue of size increase in the SPL? IIRC, then one patch
>
will fail, since it think that there are no phase to
correct
Signed-off-by: Moti Buskila
Reviewed-by: Kostya Porotchkin
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/ddr3_training_ip_engine.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
commit 6c705ebc0d70f67ed7cae83ad1978c3305ef25be upstream.
The commit mentioned above changes non-DDR3 stuff in upstream, but it
also changes header mv_ddr_topology.h.
Import this header change to remain consistent with upstream.
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers
Porotchkin
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/mv_ddr_topology.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ddr/marvell/a38x/mv_ddr_topology.c
b/drivers/ddr/marvell/a38x/mv_ddr_topology.c
index 09840b1e70..f2cd7c0ef3
From: Moti Buskila
commit 0b5adedd4ced9b8f528faad1957d4d69e95759ef upstream.
Signed-off-by: Moti Buskila
Reviewed-by: Alex Leibovich
Reviewed-by: Kostya Porotchkin
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/mv_ddr_topology.c | 2 +-
1 file changed, 1
-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/mv_ddr_spd.c | 5 +
drivers/ddr/marvell/a38x/mv_ddr_spd.h | 1 +
drivers/ddr/marvell/a38x/mv_ddr_topology.c | 6 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/ddr/marvell/a38x/mv_ddr_spd.c
for
all boards, as this was default behaviour prior this change ]
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
board/CZ.NIC/turris_omnia/turris_omnia.c | 2 ++
board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 1 +
board/Marvell/db-88f6820-gp/db-88f6820-gp.c | 1 +
board
commit d653b305d0b3da9727c49124683f1a6d95d5c9a5 upstream.
The commit mentioned above changes non-DDR3 stuff in upstream, but it
also changes header ddr_topology_def.h.
Import this header change to remain consistent with upstream.
Signed-off-by: Marek Behún
Tested-by: Chris Packham
.
- memory size with 64 and 32 bit already calculated correctly
at mv_ddr_mem_sz_per_cs_get() function
Signed-off-by: Moti Buskila
Reviewed-by: Stefan Chulski
Reviewed-by: Alex Leibovich
Reviewed-by: Kostya Porotchkin
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x
commit 3908e20c6c520339e9bddb566823ae5e065d5218 upstream.
The commit mentioned above changes non-DDR3 stuff in upstream, but it
also changes header ddr_topology_def.h.
Import this header change to remain consistent with upstream.
Signed-off-by: Marek Behún
Tested-by: Chris Packham
commit 2bdd12dd68b1f8e27a03a3443ae49a09a14c18e4 upstream.
The commit mentioned above changes non-DDR3 stuff in upstream, but it
also changes code in ddr3_training.c.
Import this change to remain consistent with upstream.
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr
And also pinging this series, since we had our answer from Thomas
Petazzoni :)
commit a165037ec26f301be75e1fabc263643683e85255 upstream.
The commit mentioned above changes non-DDR3 stuff in upstream, but it
also changes header ddr_topology_def.h.
Import this header change to remain consistent with upstream.
Signed-off-by: Marek Behún
Tested-by: Chris Packham
ames are now in the From headers
- added Chris' Tested-by
Marek
Alex Leibovich (2):
ddr: marvell: a38x: add ddr32 support
ddr: marvell: a38x: add ddr 32bit ECC support
Baruch Siach (1):
ddr: marvell: a38x: allow board specific ODT configuration
Marek Behún (7):
ddr: marvell: a38x: import h
Just pinging this series :)
configuration register value.
Signed-off-by: Baruch Siach
Reviewed-by: Moti Buskila
Reviewed-by: Nadav Haklai
Reviewed-by: Kostya Porotchkin
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/ddr3_init.c| 5 +
drivers/ddr/marvell/a38x
as in MB and then
multiply it by 1MB.
Signed-off-by: Moti Buskila
Reviewed-by: Kostya Porotchkin
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/mv_ddr_plat.c | 9 +++--
drivers/ddr/marvell/a38x/xor.c | 6 +++---
2 files changed, 10 insertions(+), 5
From: Moti Buskila
commit 994509eb4fe6771d92cd06314c37895098ac48fa upstream.
Signed-off-by: Moti Buskila
Reviewed-by: Kostya Porotchkin
Signed-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/ddr3_training_ip_def.h | 2 ++
drivers/ddr/marvell/a38x/mv_ddr_topology.c
-off-by: Marek Behún
Tested-by: Chris Packham
---
drivers/ddr/marvell/a38x/ddr3_training_db.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/ddr/marvell/a38x/ddr3_training_db.c
b/drivers/ddr/marvell/a38x/ddr3_training_db.c
index b2f11a8399..6aa7b6069e 100644
--- a/drivers/ddr
M_SIZE
> and adjust usage to match that CONFIG_SYS_SDRAM_SIZE expects the entire
> size rather than MiB.
>
> Cc: Marek Behún
> Cc: Stefan Roese
> Signed-off-by: Tom Rini
> ---
> drivers/ddr/marvell/axp/ddr3_axp.h | 4 ++--
> include/configs/maxbcm.h | 4 +++-
> > +#elif defined(CONFIG_ARMADA_3700)
> > +/* SAR values for Armada 3700 */
> > +#define MVEBU_TEST_PIN_LATCH_N MVEBU_REGISTER(0x13808)
> > +#define MVEBU_XTAL_MODE_MASK BIT(9)
> > +#define CONFIG_SYS_REF_CLK ((readl(MVEBU_TEST_PIN_LATCH_N) &
> > MVEBU_XTAL_MODE_MASK) ? \
> > +
Acked-by: Marek Behún
Acked-by: Marek Behún
On Fri, 27 Aug 2021 13:16:25 +1200
Chris Packham wrote:
> On Thu, Aug 26, 2021 at 1:46 AM Marek Behún wrote:
> >
> > Hello Stefan and others,
> >
> > this series adds support for booting Marvell platforms via UART (those
> > bootable with kwboot) at higher ba
On Fri, 27 Aug 2021 10:36:52 +0200
Pali Rohár wrote:
> Anyway, it looks like that A385 bootrom has bugs in debug console and so
> -d is on this SoC unusable. When I enter into debug mode, boorom
> somehow does not send output from (debug) commands over UART. But it
> sends ECHO over UART...
On Fri, 27 Aug 2021 14:45:07 +1200
Chris Packham wrote:
> The higher speed settings weren't so good. I started with 3125000 and
> that doesn't get onto the 2nd part of the download, same for 1152000
> and 400 (I stopped trying higher speeds at that point). Using
> 230400 and 460800 it does
majority of the binary, though. On Turris
Omnia the payload currently makes ~87%.)
The series also contains various other fixes, refactors and improvements
of the code, upon which the main change is done.
Marek & Pali
Marek Behún (13):
tools: kwbimage: Fix printf format warning
tools: kw
-off-by: Marek Behún
---
tools/kwbimage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/kwbimage.c b/tools/kwbimage.c
index aa865cc443..ed11c835a5 100644
--- a/tools/kwbimage.c
+++ b/tools/kwbimage.c
@@ -544,7 +544,7 @@ static int kwb_export_pubkey(RSA *key, struct
This buffer is never written to. Make it const.
Signed-off-by: Marek Behún
---
tools/kwboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/kwboot.c b/tools/kwboot.c
index e6e99849a7..f18f6d2134 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -460,7 +460,7
buffer of enough size instead of
mmap()ing it. (If we are going to move the data, most of the pages will
be dirty anyway.) Then move the payload if header size needs to be
increased.
Signed-off-by: Pali Rohár
[ refactored ]
Signed-off-by: Marek Behún
---
tools/kwboot.c | 91
From: Pali Rohár
Add Pali and Marek as another authors of the kwboot utility.
Signed-off-by: Pali Rohár
Signed-off-by: Marek Behún
---
tools/kwboot.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/kwboot.c b/tools/kwboot.c
index f60cfd130e..b183e4b35b 100644
--- a/tools/kwboot.c
]
Signed-off-by: Marek Behún
---
tools/kwboot.c| 16 +++-
tools/termios_linux.h | 170 ++
2 files changed, 185 insertions(+), 1 deletion(-)
create mode 100644 tools/termios_linux.h
diff --git a/tools/kwboot.c b/tools/kwboot.c
index dbe59833eb
Rename this function to kwbimage_version() and don't cast argument if
not needed.
Signed-off-by: Marek Behún
---
tools/kwbimage.c | 8
tools/kwbimage.h | 4 ++--
tools/kwboot.c | 4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/kwbimage.c b/tools
Add entry for these tools with Marek, Pali and Stefan as maintainers.
Signed-off-by: Marek Behún
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 776ff703b9..d4b21dd660 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -772,6 +772,16
From: Pali Rohár
This change is required to implement other features in kwboot.
Split sending header and data parts of the image into two stages.
Signed-off-by: Pali Rohár
[ refactored ]
Signed-off-by: Marek Behún
---
tools/kwbimage.h | 8 +++--
tools/kwboot.c | 84
From: Pali Rohár
After kwboot sends EOT, BootROM sends back ACK. Add code for handling
this and retry sending EOT on error.
Signed-off-by: Pali Rohár
[ refactored ]
Signed-off-by: Marek Behún
---
tools/kwboot.c | 65 +-
1 file changed, 48
-by: Marek Behún
---
tools/kwboot.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/kwboot.c b/tools/kwboot.c
index b9a402ca91..88353d19c0 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -347,7 +347,7 @@ kwboot_debugmsg(int tty, void *msg)
return rc
The `in` variable is set to -1 in kwboot_terminal() if stdin is not a
tty. In this case we should not look whether -1 is set in fd_set, for it
can lead to a buffer overflow, which can be reproduced with
echo "xyz" | ./tools/kwboot -t /dev/ttyUSB0
Signed-off-by: Marek Behún
---
tool
the
now unnecessary break.
In other failure cases return immediately.
Signed-off-by: Pali Rohár
Reviewed-by: Marek Behún
---
tools/kwboot.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/kwboot.c b/tools/kwboot.c
index 454339db14..b9a402ca91 100644
--- a/tools
From: Pali Rohár
It is not possible to modify image with secure header due to
cryptographic signature.
Signed-off-by: Pali Rohár
[ refactored ]
Signed-off-by: Marek Behún
---
tools/kwboot.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/tools
There is no separation between output from the code from binary header
(U-Boot SPL in most cases) and subsequent kwboot output.
Print '\n' to make distinguishing these two easier.
Signed-off-by: Marek Behún
---
tools/kwboot.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools
601 - 700 of 1644 matches
Mail list logo