Re: [U-Boot-Users] [PATCH] Fill in remaining MTD driver data for OneNAND (take #2)

> Don't cast the return of malloc. ok. > Why not just declare a static array? I tried with a static array but it doesn't give the expected result (a quick test with onenand info command returns an empty mtd name), so I used a pointer. > It'd be better to use snprintf, even if you're pretty su

[U-Boot-Users] [PATCH] Fill in remaining MTD driver data for OneNAND (take #2)

Fill in remaining MTD driver data for OneNAND. Review onenand_print_device_info(): - Return device info to fill mtd device name. - Remove verbose parameter as it become useless. Since last comments: - Include malloc.h - Initialize dev_info pointer. Signed-off-by: Fathi Boudra <[EM

Re: [U-Boot-Users] [PATCH] JFFS2 command support on OneNAND (take #2)

Hi, > > TODO: Use NAND command interface (e.g.: part_validate_*nand()). > > Do you mean merging the NAND and OneNAND versions of the jffs2 > code, through the (mostly already existing) function pointer > interface? yes, as you suggested to kyungmin: use mtd_info function pointer interface. > I'd

[U-Boot-Users] [PATCH] JFFS2 command support on OneNAND (take #3)

.: part_validate_*nand()). Signed-off-by: Kyungmin Park <[EMAIL PROTECTED]> Signed-off-by: Fathi Boudra <[EMAIL PROTECTED]> --- diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c index b4698be..16ca8f7 100644 --- a/common/cmd_jffs2.c +++ b/common/cmd_jffs2.c @@ -51,7 +51,7 @

[U-Boot-Users] [PATCH] Fill in remaining MTD driver data for OneNAND

Fill in remaining MTD driver data for OneNAND. Review onenand_print_device_info(): - Return device info to fill mtd device name. - Remove verbose parameter as it become useless. Signed-off-by: Fathi Boudra <[EMAIL PROTECTED]> --- diff --git a/common/cmd_onenand.c b/common/cmd_onenand.c

[U-Boot-Users] [PATCH] JFFS2 command support on OneNAND (take #2)

JFFS2 command support on OneNAND. - Fix typo. - Fix nand_bbt_descr redefinition when NAND and OneNAND are enabled. TODO: Use NAND command interface (e.g.: part_validate_*nand()). Signed-off-by: Kyungmin Park <[EMAIL PROTECTED]> Signed-off-by: Fathi Boudra <[EMAIL PROTECTED]> ---

Re: [U-Boot-Users] [PATCH] Fix duplicated flash state

sorry, mail sent too fast... nand_bbt_desc structure is defined in include/linux/mtd/bbm.h and iinclude/linux/mtd/nand.h cheers, Fathi - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the

Re: [U-Boot-Users] [PATCH] Fix duplicated flash state

> > It's not this patch contents. > I'ts related with the previous patch "JFFS2 support on OneNAND" > Anyway, it should be below. > > static inline void put_fl_mem(void *buf) > { > -#if defined(CONFIG_JFFS2_NAND) && \ > -defined(CONFIG_CMD_NAND) > +#if (defined(CONFIG_JFFS2_NAND) && defined(C

Re: [U-Boot-Users] [PATCH] Fix duplicated flash state

On Tue, Jul 22, 2008 at 10:09 AM, Kyungmin Park <[EMAIL PROTECTED]> wrote: > Move to one place > I just compiled test. Please check other NAND users. > > It fails to build, redefinition of id: jffs2_1pass.c: In function 'put_fl_mem': jffs2_1pass.c:466: error: redefinition of 'id' jffs2_1pass.c:459

Re: [U-Boot-Users] [PATCH] JFFS2 command support on OneNAND

> Yes, you're right. it's complicit. > However it's not related with this patch. It happens always at current > source. > Next time it will fix it. > The kernel implementation is similar. You'll probably have to fix it there also. cheers, Fathi ---

Re: [U-Boot-Users] [PATCH] JFFS2 command support on OneNAND

Hi, > > I really would rather not duplicate all of this, which looks extremely > > > similar to regular NAND. Is there reason why we don't use the mtd_info > > > function pointer interface? > > > > Agreed, It's almost same as NAND code. > > Now nand code uses two modes, legacy and mtd. Because I

[U-Boot-Users] which config to choose for MPC8347E cpu ?

Hi, I have a custom board with a MPC8347E and U-Boot doesn't have a config for this cpu. which config is more appropriate to use for my board ? (maybe MPC8349EMDS or sbc8349 or tqm834x ?). any tips ? TIA. cheers, Fathi - Ch