Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-11 Thread Ben Warren
Timur Tabi wrote: > Ben Warren wrote: > >> The problem is that you're artificially making this a PowerPC-only >> part. If you used 8-bit accessors endianness wouldn't matter and >> other architectures could use this without changes (notwithstanding >> the #includes...) > > Ok, I will try to figure

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-11 Thread Timur Tabi
Ben Warren wrote: > The problem is that you're artificially making this a PowerPC-only > part. If you used 8-bit accessors endianness wouldn't matter and > other architectures could use this without changes (notwithstanding > the #includes...) Ok, I will try to figure out how to make 8-bit acces

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-08 Thread Ben Warren
On Feb 8, 2008 11:44 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Ben Warren wrote: > > > Is this switch able to pass traffic in a default configuration without > > this firmware or is it dead? > > Without the firmware, the switch is completely dead. OK, good to know. What a lovely feature. > > >

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-08 Thread Scott Wood
Timur Tabi wrote: >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> >> I think Kim mentioned this will break some architectures. Just repeating it. > > Yeah, I'm still waiting for someone to tell me why. Not every architecture has an io.h and an errno.h. -Scott --

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-08 Thread Timur Tabi
Ben Warren wrote: > Is this switch able to pass traffic in a default configuration without > this firmware or is it dead? Without the firmware, the switch is completely dead. > I'm not 100% convinced that this is network code, but my opinion isn't > very strong and I can't really think of a be

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-08 Thread Ben Warren
Hi Timur, Just some nit-picking... Timur Tabi wrote: > The Vitesse VSC7385 is a 5-port switch found on the Freescale MPC8349E-mITX > and other boards. A small firwmare must be uploaded to its on-board memory > before it can be enabled. This patch adds the code which uploads firmware > (but not

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-07 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > > Previously, this feature was provided by a U-Boot application that was > > made available only on Freescale BSPs. The VSC7385 firmware must still > > be obtained separately, but at least there is no longer a need for a > > separate > > application.

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-07 Thread Timur Tabi
Kim Phillips wrote: > I'd prefer firmware uploading bits remain apps (perhaps in examples/?) > but I don't know the "U-Boot Philosophy" for this area.. The whole point behind this patch is to get rid of the currently application and make this a native feature of U-Boot. In this regard, it is n

Re: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-07 Thread Kim Phillips
On Wed, 6 Feb 2008 13:19:25 -0600 Timur Tabi <[EMAIL PROTECTED]> wrote: > The Vitesse VSC7385 is a 5-port switch found on the Freescale MPC8349E-mITX > and other boards. A small firwmare must be uploaded to its on-board memory > before it can be enabled. This patch adds the code which uploads f

[U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

2008-02-06 Thread Timur Tabi
The Vitesse VSC7385 is a 5-port switch found on the Freescale MPC8349E-mITX and other boards. A small firwmare must be uploaded to its on-board memory before it can be enabled. This patch adds the code which uploads firmware (but not the firmware itself) and updates the MPC8349E-mITX, MPC8313E-RD