Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-04-13 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: This patch should resolve the compilation issues on 547x/548x cpus. Unfortunately it's missing your Signed-off-by: line. Also, please post patches inline rather than attachments. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD:

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-04-13 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: Yes. Thanks. ... Then how about doing this: --- a/include/asm-m68k/global_data.h +++ b/include/asm-m68k/global_data.h @@ -47,6 +47,9 @@ typedef struct global_data { unsigned long vco_clk; unsigned long flb_clk; #endif +#ifdef

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-03-27 Thread Luigi 'Comio' Mantellini
This patch seems incompatible with cf547x/548x cpus because the cpu specific global data doesn't define the i2c1_clk / i2c2_clk attributes. Best regards, luigi On ven, 2008-03-14 at 17:45 -0500, Timur Tabi wrote: Add support to the Freescale I2C driver (fsl_i2c.c) for setting and querying

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-03-27 Thread Timur Tabi
Luigi 'Comio' Mantellini wrote: This patch should resolve the compilation issues on 547x/548x cpus. Sorry, I didn't even think to check for anything outside of PowerPC. I had no idea m68k used fsl_i2c.c. @@ -47,6 +47,9 @@ typedef struct global_data { unsigned long vco_clk;

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-03-27 Thread Liew Tsi Chung
547x/548x are not the only ColdFire affected, 5235, 5373, 5275, 5329, 54455, 52277, and 5271 are required to update as well. -Original Message- From: Tabi Timur Sent: Thursday, March 27, 2008 9:46 AM To: Luigi 'Comio' Mantellini Cc: U-boot-Users; Liew Tsi Chung Subject: Re:

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-03-27 Thread Liew Tsi Chung
Yes. Thanks. Regards, TsiChung -Original Message- From: Tabi Timur Sent: Thursday, March 27, 2008 12:51 PM To: Liew Tsi Chung Cc: Luigi 'Comio' Mantellini; U-boot-Users Subject: Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c Liew Tsi Chung wrote:

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-03-26 Thread Timur Tabi
Timur Tabi wrote: Add support to the Freescale I2C driver (fsl_i2c.c) for setting and querying the I2C bus speed. Current 8[356]xx boards define the CFG_I2C_SPEED macro, but fsl_i2c.c ignores it and uses conservative value when programming the I2C bus speed. Kim and Jon, I tested this patch

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-03-26 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: Add support to the Freescale I2C driver (fsl_i2c.c) for setting and querying the I2C bus speed. Current 8[356]xx boards define the CFG_I2C_SPEED macro, but fsl_i2c.c ignores it and uses conservative value when programming the I2C bus speed.

Re: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c

2008-03-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:45 Fri 14 Mar , Timur Tabi wrote: Add support to the Freescale I2C driver (fsl_i2c.c) for setting and querying the I2C bus speed. Current 8[356]xx boards define the CFG_I2C_SPEED macro, but fsl_i2c.c ignores it and uses conservative value when programming the I2C bus speed.