Re: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200

2008-05-29 Thread Liew Tsi Chung
: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200 Liew Tsi Chung wrote: Where are you getting the +31 from? Is this in the User's Manual? No in user's manual. The +31 is rounding up purpose. The formula (n + 31) / 32 is *NOT ROUNDING* the answer, it is doing a ceiling function. You

[U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200

2008-05-28 Thread Tsi-Chung.Liew
From: TsiChung Liew [EMAIL PROTECTED] If bus frequency is larger than 133MHz, the UART cannot output baudrate at 115200 correctly. Signed-off-by: TsiChung Liew [EMAIL PROTECTED] --- drivers/serial/mcfuart.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

Re: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200

2008-05-28 Thread Jerry Van Baren
Tsi-Chung.Liew wrote: From: TsiChung Liew [EMAIL PROTECTED] If bus frequency is larger than 133MHz, the UART cannot output baudrate at 115200 correctly. Signed-off-by: TsiChung Liew [EMAIL PROTECTED] --- drivers/serial/mcfuart.c |5 - 1 files changed, 4 insertions(+), 1

Re: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200

2008-05-28 Thread Liew Tsi Chung
-Users] [PATCH] ColdFire: Fix UART baudrate at 115200 Tsi-Chung.Liew wrote: From: TsiChung Liew [EMAIL PROTECTED] If bus frequency is larger than 133MHz, the UART cannot output baudrate at 115200 correctly. Signed-off-by: TsiChung Liew [EMAIL PROTECTED] --- drivers/serial/mcfuart.c

Re: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200

2008-05-28 Thread Jerry Van Baren
: Jerry Van Baren [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 28, 2008 1:45 PM To: Liew Tsi Chung Cc: U-Boot-Users; Wolfgang Denx; Rigby John Subject: Re: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200 Tsi-Chung.Liew wrote: From: TsiChung Liew [EMAIL PROTECTED] If bus

Re: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate at 115200

2008-05-28 Thread Liew Tsi Chung
Where are you getting the +31 from? Is this in the User's Manual? No in user's manual. The +31 is rounding up purpose. Computations are for mathematicians. Real engineers measure the actual frequency. ;-) Agree. If you change the - 31 to - 42, your computations will result in a different