Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-08-01 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20 TimerLoad */ ^ - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD; /*=20 TimerValue */ ^ Your patch is line-wrapped and cannot

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-08-01 Thread Gururaja Hebbar K R
Hi, The original source file has nothing to do with this problem. Yes, but that is NOT the problem. The problem is that your mailer is wrapping long lines when it sends your patch, thus corrpting it. The source line may be long, but it is not broken. It is your mailer which corrupts the patch by

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-08-01 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: Yes. Sorry for the mistake. It was my M$ Office which was wrapping the mail @ column 76 hence the issue. I have changed it to 81 i have Re-Submitted the Patch. Hopefully. Its Corrected Now. Changed it to 81? I don't understand. What happens when

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-08-01 Thread Gururaja Hebbar K R
Hi, In message [EMAIL PROTECTED] you wrote: Yes. Sorry for the mistake. It was my M$ Office which was wrapping the mail @ column 76 hence the issue. I have changed it to 81 i have Re-Submitted the Patch. Hopefully. Its Corrected Now. Changed it to 81? I don't understand.

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-08-01 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: I can turn this off completely in M$ Office For Plain Text Mails, It Automatically Wraps the text. We can only set the Number of characters to wrap I checked found that the max characters that can be allowed b4 wrapping is 132 ...which is why we

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-07-31 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: Hi, @@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20 TimerLoad */ ^ - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD; /*=20

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-07-31 Thread Gururaja Hebbar K R
Hi, In message [EMAIL PROTECTED] you wrote: Hi, @@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20 TimerLoad */ ^ - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD;

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-07-29 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: Sorry. Re-sending as uboot-mailing list was not properly Included last time Regards Gururaja Please do not include such comments in the commit message part of the patch. They belong *below* the '--- line. @@ -50,8 +50,7 @@ static ulong lastdec;

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-07-29 Thread Gururaja Hebbar K R
Hi, @@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD; /* TimerLoad */ ^ - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD; /* TimerValue */ ^ Your patch is line-wrapped and

[U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

2008-07-24 Thread Gururaja Hebbar K R
Hi, Sorry. Re-sending as uboot-mailing list was not properly Included last time Regards Gururaja - According to ARM Dual-Timer Module (SP804) TRM (ARM DDI0271), --Timer Value Register @ TIMER Base + 4 is Read-only. So removed code which writes to this register --Prescale Value (Bits 3-2 of