Fathi BOUDRA wrote:
>> Why not just declare a static array?
>
> I tried with a static array but it doesn't give the expected result (a quick
> test with onenand info command returns an empty mtd name), so I used a
> pointer.
Odd... Maybe a relocation issue?
>> It'd be better to use snprintf, e
> Don't cast the return of malloc.
ok.
> Why not just declare a static array?
I tried with a static array but it doesn't give the expected result (a quick
test with onenand info command returns an empty mtd name), so I used a
pointer.
> It'd be better to use snprintf, even if you're pretty su
In message <[EMAIL PROTECTED]> you wrote:
>
> > - printk(KERN_INFO "%sOneNAND%s %dMB %sV 16-bit (0x%02x)\n",
> > + sprintf(dev_info, "%sOneNAND%s %dMB %sV 16-bit (0x%02x)",
> >demuxed ? "" : "Muxed ",
> >ddp ? "(DDP)" : "",
> >(16 << density), vcc ? "2.65/3.
On Wed, Aug 06, 2008 at 10:06:20AM +0200, Fathi BOUDRA wrote:
> -void onenand_print_device_info(int device, int verbose)
> +char * onenand_print_device_info(int device)
No space after unary '*' (here and elsewhere).
> {
> int vcc, demuxed, ddp, density;
> -
> - if (!verbose)
> -
Fill in remaining MTD driver data for OneNAND.
Review onenand_print_device_info():
- Return device info to fill mtd device name.
- Remove verbose parameter as it become useless.
Since last comments:
- Include malloc.h
- Initialize dev_info pointer.
Signed-off-by: Fathi Boudra <[EMAIL PROTECTE
