[U-Boot-Users] [PATCH] I2C Monitor chip ADT7460 support (Resubmit)

2008-07-23 Thread Ricardo Ribalda Delgado
Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 83 +++ include/dtt.h |3 +- 3 files changed, 86 insertions(+), 1 deletions(-) create mode 100644 drivers/hwmon/ad

[U-Boot-Users] [PATCH] I2C Monitor chip ADT7460 support

2008-07-15 Thread Ricardo Ribalda Delgado
Minor changes to previous patch Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- -Remove whitespaces drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 83 +++ include/dtt.h |3 +- 3 files changed, 86 insertions(+

[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (new version)

2008-07-14 Thread Ricardo Ribalda Delgado
Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- -Add support to the ADT7460 Monitor Chip by Analog Devices. -Correct wrong previous coding style -Correct previous use of puts -Correct comments and remove whitespaces drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 83 +

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (new version)

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:26 Mon 14 Jul , Ricardo Ribalda Delgado wrote: > -Add support to the ADT7460 Monitor Chip by Analog > Devices. > -Correct wrong previous coding style > -Correct previous use of puts please add this comment after the --- > > Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> > ---

[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (new version)

2008-07-14 Thread Ricardo Ribalda Delgado
-Add support to the ADT7460 Monitor Chip by Analog Devices. -Correct wrong previous coding style -Correct previous use of puts Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 86 ++

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-13 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > Still is there coding style issue. > > and you have one extra header file which is uneeded. I recommend you > move usefull values directly to driver. > > WD: I looked at include/dtt.h there are many driver specific values. IMHO > these > value should

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Ricardo Ribalda Delgado
OK, I will do it on this and the next patches Best Regards On Fri, Jul 11, 2008 at 12:58 PM, Stefan Roese <[EMAIL PROTECTED]> wrote: > On Friday 11 July 2008, Ricardo Ribalda Delgado wrote: >> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> > > Ricardo, please address my (nitpickin

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Stefan Roese
On Friday 11 July 2008, Ricardo Ribalda Delgado wrote: > Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> Ricardo, please address my (nitpicking) comments below in the next version. You could also run "Lindent" if you don't want to do this coding style cleanup manually. > --- > drive

[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Ricardo Ribalda Delgado
Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 85 +++ include/dtt.h |3 +- 3 files changed, 88 insertions(+), 1 deletions(-) create mode 100644 drivers/hwmon/a

[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Ricardo Ribalda Delgado
Removed extra lines - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lamen

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Michal Simek
Still you have 3 empty lines. Look at code. Do not add more than 2 empty lines to source files M From: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 90

[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 90 +++ include/dtt.h |3 +- 3 files changed, 93 insertions(+),

[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (fixed)

2008-07-11 Thread Ricardo Ribalda Delgado
Fixed version of the previous patch - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Stefan Roese
On Friday 11 July 2008, Michal Simek wrote: > Still is there coding style issue. > > and you have one extra header file which is uneeded. I recommend you > move usefull values directly to driver. > > WD: I looked at include/dtt.h there are many driver specific values. IMHO > these value should be u

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Michal Simek
Still is there coding style issue. and you have one extra header file which is uneeded. I recommend you move usefull values directly to driver. WD: I looked at include/dtt.h there are many driver specific values. IMHO these value should be usefull move to driver c file. What do you think about?

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Stefan Roese
On Friday 11 July 2008, Ricardo Ribalda Delgado wrote: > Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> Please find some comments below (mostly nitpicking). > drivers/hwmon/Makefile |1 + > drivers/hwmon/adt7460.c | 81 > +++ drivers/

[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

2008-07-11 Thread Ricardo Ribalda Delgado
Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- drivers/hwmon/Makefile |1 + drivers/hwmon/adt7460.c | 81 +++ drivers/hwmon/adt7460.h | 49 include/dtt.h |3 +- 4 files changed, 133 ins