Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

2008-07-13 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: Unfortunately this tip does not have nicname and other. We want to acquire a name same as Linux kernel USB driver.. I see. Well, so we have to swallow that bitter pill, I guess. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD:

Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

2008-07-10 Thread Yoshihiro Shimoda
2008/07/10 4:15, Jean-Christophe PLAGNIOL-VILLARD wrote: + +#include common.h +#include usb.h +#include asm/io.h + +#include r8a66597.h + +#if defined(CONFIG_USB_R8A66597_HCD) please move to the Makefile Thank you for your comment. I wlll move to the Makefile. + +#ifdef

Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

2008-07-10 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: is it not possible to have a better name for the struct and the var and btw for the function naming? Because XTAL, LDRV, DEVADD are a register name or register bit name, I think that it is a good name... But I will change a name of the struct

Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

2008-07-10 Thread Yoshihiro Shimoda
2008/07/10 20:01, Wolfgang Denk wrote: In message [EMAIL PROTECTED] you wrote: is it not possible to have a better name for the struct and the var and btw for the function naming? Because XTAL, LDRV, DEVADD are a register name or register bit name, I think that it is a good name... But I

Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

2008-07-10 Thread Nobuhiro Iwamatsu
Hi, Wolfgang. 2008/7/11 Wolfgang Denk [EMAIL PROTECTED]: In message [EMAIL PROTECTED] you wrote: Can you not find some simpler name that r8a66597? That's a mess to type and to read. Thank you for your comment. I can change that struct r8a66597 for a simple name. For example, its name

[U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

2008-07-09 Thread Yoshihiro Shimoda
add support for Renesas R8A66597 usb controller. This patch supports USB Host mode. Signed-off-by: Yoshihiro Shimoda [EMAIL PROTECTED] --- drivers/usb/Makefile |1 + drivers/usb/r8a66597-hcd.c | 924 drivers/usb/r8a66597.h | 663