Re: [U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in and out macros for LEON processors.

2008-03-31 Thread Ben Warren
Daniel Hellstrom wrote: > Ben Warren wrote: > >> Daniel Hellstrom wrote: >> >>> Ben Warren wrote: >>> >>> I haven't looked at how all the funky macros in this patch are called, but it's generally considered good form to wrap multi-line macros with do {...} while(0) in order to av

Re: [U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in and out macros for LEON processors.

2008-03-31 Thread Daniel Hellstrom
Ben Warren wrote: > Daniel Hellstrom wrote: > >> Ben Warren wrote: >> >> >>> I haven't looked at how all the funky macros in this patch are >>> called, but it's generally considered good form to wrap multi-line >>> macros with do {...} while(0) in order to avoid compiler issues. >>> I'll NAK

Re: [U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in and out macros for LEON processors.

2008-03-31 Thread Ben Warren
Daniel Hellstrom wrote: > Ben Warren wrote: > >> I haven't looked at how all the funky macros in this patch are called, but >> it's generally considered good form to wrap multi-line macros with do {...} >> while(0) in order to avoid compiler issues. I'll NAK the patch for now based >> on this

Re: [U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in and out macros for LEON processors.

2008-03-31 Thread Ben Warren
Alessandro Rubini wrote: >>> +#define SMC_insb(r,b,l)({ int __i ; \ >>> + byte *__b2; \ >>> + __b2 = (byte *) b; \ >>> + for (__i = 0; __i < l; __i++) { \ >>> +

Re: [U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in and out macros for LEON processors.

2008-03-31 Thread Daniel Hellstrom
Ben Warren wrote: > I haven't looked at how all the funky macros in this patch are called, but > it's generally considered good form to wrap multi-line macros with do {...} > while(0) in order to avoid compiler issues. I'll NAK the patch for now based > on this. The Macros are used to read/writ

Re: [U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in and out macros for LEON processors.

2008-03-29 Thread Ben Warren
Daniel Hellstrom wrote: > Hello Wolfgang, > > This patch makes SPARC/LEON processors able to read and write > to the SMC9 chip using the chip external I/O bus of the memory > controller. This patchs defines the standard in and out macros > expected by the SMC9111 driver. > > To access that I/O

[U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in and out macros for LEON processors.

2008-03-28 Thread Daniel Hellstrom
Hello Wolfgang, This patch makes SPARC/LEON processors able to read and write to the SMC9 chip using the chip external I/O bus of the memory controller. This patchs defines the standard in and out macros expected by the SMC9111 driver. To access that I/O bus one must set up the memory control