Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-14 Thread Dave Liu
> > fsl_spi.h might be a bit too general? How about non-8xxx Freescale > > processors? > > f > > > The naming convention was modeled after 'fsl_i2c', which surely isn't > universal to all Freescale I2C controllers either. In Linux, this > driver is called 'mpc83xx', which we've learned here i

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-14 Thread Ben Warren
Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: > >> please put this into fsl_spi.h to reuse for different 8xxx family. >> > > fsl_spi.h might be a bit too general? How about non-8xxx Freescale > processors? > f > The naming convention was modeled after 'fsl_i2c', which

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > please put this into fsl_spi.h to reuse for different 8xxx family. fsl_spi.h might be a bit too general? How about non-8xxx Freescale processors? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel H

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Liu Dave
> I don't have access to 8313 or 8610 reference manuals. Can you please > verify the memory map of these two for me. I've verified that 8315 is > identical. 8313/8315/834x/8610 have same SPI. Dave - Check out the new Sourc

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Liu Dave
> > > > 8313/8315/834x/8610 have same SPI. and 837x > asm/immap_86xx.h doesn't have SPI registers listed in the > memory map, so > support for 8610 will have to wait. > > I've incorporated your change requests and will see if > there's any more > feedback on Monday before reposting the patch

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Ben Warren
Liu Dave wrote: >> I don't have access to 8313 or 8610 reference manuals. Can you please >> verify the memory map of these two for me. I've verified that 8315 is >> identical. >> > > 8313/8315/834x/8610 have same SPI. > > Dave > > asm/immap_86xx.h doesn't have SPI registers listed in the

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Ben Warren
Liu Dave wrote: >> I don't have access to 8313 or 8610 reference manuals. Can you please >> verify the memory map of these two for me. I've verified that 8315 is >> identical. >> > > 8313/8315/834x/8610 have same SPI. > > Dave > > Cool. Thanks. Ben --

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Ben Warren
Liu Dave wrote: +typedef struct spi834x +{ + u8 res0[0x20]; /* 0x0-0x01f reserved */ + u32 mode; /* mode register */ + u32 event; /* event register */ + u32 mask; /* mask register */ + u32 com;/* command re

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Ben Warren
Liu Dave wrote: +typedef struct spi834x +{ + u8 res0[0x20]; /* 0x0-0x01f reserved */ + u32 mode; /* mode register */ + u32 event; /* event register */ + u32 mask; /* mask register */ + u32 com;/* command re

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Liu Dave
> >> +typedef struct spi834x > >> +{ > >> + u8 res0[0x20]; /* 0x0-0x01f reserved */ > >> + u32 mode; /* mode register */ > >> + u32 event; /* event register */ > >> + u32 mask; /* mask register */ > >> + u32 com;/* command register */ > >> +

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Ben Warren
Dave Liu wrote: > On Sun, 2008-01-13 at 10:48 +0800, Ben Warren wrote: > >> This patch adds support for the SPI controller found on Freescale >> PowerPC >> processors such as the MCP834x family. Additionally, a new config >> option, >> CONFIG_HARD_SPI, is added for general purpose SPI controlle

Re: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller

2008-01-13 Thread Dave Liu
On Sun, 2008-01-13 at 10:48 +0800, Ben Warren wrote: > This patch adds support for the SPI controller found on Freescale > PowerPC > processors such as the MCP834x family. Additionally, a new config > option, > CONFIG_HARD_SPI, is added for general purpose SPI controller use. Ben, Could you make