On Mon, 28 Apr 2008 12:05:42 +0200
Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you wrote:
> >
> > > I would change the image size to 256k to safe some space in FLASH. For
> > > this
> > > you have to change TEXT_BASE (in config.mk in your board directory) to
> > >
In message <[EMAIL PROTECTED]> you wrote:
>
> > I would change the image size to 256k to safe some space in FLASH. For this
> > you have to change TEXT_BASE (in config.mk in your board directory) to
> > 0xfffc. And CFG_MONITOR_BASE too. Or even better:
> >
> > #define CFG_MONITOR_BASE
On Sunday 27 April 2008, Wolfgang Denk wrote:
> In message <[EMAIL PROTECTED]> you wrote:
> > I definitely think so. I am aware of the coding style rule set be
> > Wolfgang to
>
> You are definitely wrong.
>
> > use the "func ()" style. But I never use this style in the files I write
> > from
>
> Y
On Monday 28 April 2008, Gary Jennejohn wrote:
> > I would change the image size to 256k to safe some space in FLASH. For
> > this you have to change TEXT_BASE (in config.mk in your board directory)
> > to 0xfffc. And CFG_MONITOR_BASE too. Or even better:
> >
> > #define CFG_MONITOR_BASE
On Sun, 27 Apr 2008 14:07:39 +0200
Stefan Roese <[EMAIL PROTECTED]> wrote:
> On Saturday 26 April 2008, Wolfgang Grandegger wrote:
> > > Please use only one coding style in one file. So either:
> > >
> > > func();
> > >
> > > or
> > >
> > > func ();
> > >
> > > Since this file mostly consists
On Sun, 27 Apr 2008 14:01:45 +0200
Stefan Roese <[EMAIL PROTECTED]> wrote:
> On Saturday 26 April 2008, Gary Jennejohn wrote:
> > > > +#define CFG_MONITOR_LEN(256 * 1024)/* Reserve 256
> > > > kB for Monitor */
> > > > +#define CFG_MALLOC_LEN (128 * 1024)/* Reser
In message <[EMAIL PROTECTED]> you wrote:
>
> I definitely think so. I am aware of the coding style rule set be Wolfgang to
You are definitely wrong.
> use the "func ()" style. But I never use this style in the files I write from
You mean you intentionally ignore the rules?
That's not nice.
In message <[EMAIL PROTECTED]> you wrote:
>
> > Since this file mostly consists of the func() style I suggest you switch to
> > this one completely.
>
> Do we really have the choice?
The README says:
All contributions to U-Boot should conform to the Linux kernel
coding style; see the f
Hi Wolfgang,
On Saturday 26 April 2008, Wolfgang Grandegger wrote:
> > Please use only one coding style in one file. So either:
> >
> > func();
> >
> > or
> >
> > func ();
> >
> > Since this file mostly consists of the func() style I suggest you switch
> > to this one completely.
>
> Do we
On Saturday 26 April 2008, Gary Jennejohn wrote:
> > > +#define CFG_MONITOR_LEN (256 * 1024)/* Reserve 256 kB for
> > > Monitor */
> > > +#define CFG_MALLOC_LEN (128 * 1024)/* Reserve 128 kB for
> > > malloc() */
> > > +#define CFG_MONITOR_BASE 0xFFF8
> >
> > CFG
Hi Stefan,
Stefan Roese wrote:
> Hi Gary,
>
> Please use only one coding style in one file. So either:
>
> func();
>
> or
>
> func ();
>
> Since this file mostly consists of the func() style I suggest you switch to
> this one completely.
Do we really have the choice?
Wolfgang.
On Sat, 26 Apr 2008 08:22:02 +0200
Stefan Roese <[EMAIL PROTECTED]> wrote:
Hi Stefan,
> Looks much better now. Just some minor issues (nitpicking) left. See comments
> below.
>
> > + /* taken from PPCBoot */
> > + mtdcr(uicsr, 0x); /* clear all ints */
> > + mtdcr(uicer, 0x0
Hi Gary,
On Friday 25 April 2008, Gary Jennejohn wrote:
> Handle Stefan's comments. This has the added benefit of making the
> patch considerably smaller.
Looks much better now. Just some minor issues (nitpicking) left. See comments
below.
> diff --git a/board/quad100hd/quad100hd.c b/board/qua
Handle Stefan's comments. This has the added benefit of making the
patch considerably smaller.
Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]>
---
MAINTAINERS |4 +
MAKEALL |1 +
Makefile|3 +
board/quad100hd/Makefile|
14 matches
Mail list logo
