Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Shinya Kuribayashi
Jean-Christophe PLAGNIOL-VILLARD wrote: >> But even if that is the case, there still might be some build breakage. >> > I've found an error on ARM, I'll send a patch about it soon. Sorry, and thanks in advance. > Best Regards, > J. -- Shinya Kuribayashi NEC Electronics

Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:42 Sun 06 Jul , Shinya Kuribayashi wrote: > Wolfgang Denk wrote: > > Hm... Are you absolutely sure your changes, especially the > > CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not > > cause any trouble on any systems? > > [...] > > > It seems not obvious to me tha

Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Wolfgang Denk
Dear Ben, in message <[EMAIL PROTECTED]> you wrote: > > welcome back... Thanks (I already feel again as if I could need a good vacation :-) > So, IMHO the worst case scenario is a bit of code bloat or compile > error, which aren't disastrous. Run-time errors bad, compile-time, not > so much.

Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Ben Warren
Hi Wolfgang, welcome back... Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: > >> Replace COBJS-y with appropriate driver config names. >> >> Signed-off-by: Shinya Kuribayashi <[EMAIL PROTECTED]> >> --- >> >> Changes v2: >> >> * Kill more CONFIG_CMD_NET and CONFIG_NET_MULTI d

Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-05 Thread Shinya Kuribayashi
Wolfgang Denk wrote: > Hm... Are you absolutely sure your changes, especially the > CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not > cause any trouble on any systems? [...] > It seems not obvious to me that your change is really harmless, or > tested. > > Could you ple

Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-05 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > Replace COBJS-y with appropriate driver config names. > > Signed-off-by: Shinya Kuribayashi <[EMAIL PROTECTED]> > --- > > Changes v2: > > * Kill more CONFIG_CMD_NET and CONFIG_NET_MULTI defines from >- fsl_mcdmafec.c >- mcffec.c >- netarm_

[U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-06-09 Thread Shinya Kuribayashi
Replace COBJS-y with appropriate driver config names. Signed-off-by: Shinya Kuribayashi <[EMAIL PROTECTED]> --- Changes v2: * Kill more CONFIG_CMD_NET and CONFIG_NET_MULTI defines from - fsl_mcdmafec.c - mcffec.c - netarm_eth.c * Revised DM9000 part against the net repo. drivers/ne