Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver

2008-01-17 Thread Ben Warren
, Ben > Regards, > TsiChung > > -Original Message- > From: Ben Warren [mailto:[EMAIL PROTECTED] > Sent: Thursday, January 17, 2008 12:27 PM > To: Liew Tsi Chung > Cc: U-Boot-Users; Wolfgang Denx; Rigby John > Subject: Re: [U-Boot-Users] resend#3 [PATCH 6/8] Col

Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver

2008-01-17 Thread Liew Tsi Chung
-Boot-Users; Wolfgang Denx; Rigby John Subject: Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver Liew Tsi Chung wrote: > Ben, > > The prototypes have place in include/asm-m68k/fsl_mcdmafec.h. > > Regards, > TsiChung > > Right, so there's no

Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver

2008-01-17 Thread Ben Warren
Liew Tsi Chung wrote: > Ben, > > The prototypes have place in include/asm-m68k/fsl_mcdmafec.h. > > Regards, > TsiChung > > Right, so there's no need to mention them in C code. Less is more, as they say. regards, Ben --

Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver

2008-01-17 Thread Liew Tsi Chung
-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver Hi Tsi-Chung, Tsi-Chung Liew wrote: > + > +static int fec_send(struct eth_device *dev, volatile void *packet, > +int length); static int fec_recv(struct eth_device *dev); static int > +fec_init(struct eth_device *de

Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver

2008-01-16 Thread Ben Warren
Hi Tsi-Chung, Tsi-Chung Liew wrote: > + > +static int fec_send(struct eth_device *dev, volatile void *packet, int > length); > +static int fec_recv(struct eth_device *dev); > +static int fec_init(struct eth_device *dev, bd_t * bd); > +static void fec_halt(struct eth_device *dev); > You don't

[U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver

2008-01-16 Thread Tsi-Chung Liew
Signed-off-by: TsiChungLiew <[EMAIL PROTECTED]> --- drivers/net/Makefile |1 + drivers/net/fsl_mcdmafec.c | 583 net/eth.c |4 + 3 files changed, 588 insertions(+), 0 deletions(-) create mode 100644 drivers/net/fsl_mcdma