Created attachment 9102753
1575512-glue-mark2.patch (v1b)
Slightly optimised, we only check the app name once, so if there are
thousands of URI in the permissions file, we don't get the app name
repeatedly. Debug patch doesn't apply any more.
--
You received this bug notification because you
Changing that event to profile-after-change doesn't help. In the IMAP
code `ready` is always false :-( - Setting it to true makes the test
pass as expected.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Thinking about this, I had a better idea: We should not handle the
final-ui-startup in the folder code (where the observer is attached too
late), but elsewhere, like in MailGlue.
When the event arrives call into the folders code to re-read the
strings. Also, in IMAP's NewURI() suppress folder
Comment on attachment 9101990
1575512-mail-startup-done.patch (v3)
We can't use this, see comment #72.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not
Created attachment 9101930
1575512-mail-startup-done.patch (v2)
OK, we only add observers until our event fires.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names
> Can this be made 'attribute boolean finalUiStartupDone' ?
You mean "readonly". I don't think so. I don't have an instance of
nsIMailGlue. I just get the service and run one of its methods.
I'll worry about the other comments tomorrow.
--
You received this bug notification because you are a
Created attachment 9102586
folder-debug-glue.patch
Here's the debug patch that goes with it.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not localized in
> The hard part is to create a folder API that MailGlue can call.
Or it could be the other way around: Folder code checks somewhere if
final-ui-startup has already run.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Hmm, two Xpcshell test failures:
TEST-UNEXPECTED-TIMEOUT |
comm/mailnews/db/gloda/test/unit/test_index_messages_imap_offline.js | Test
timed out
TEST-UNEXPECTED-TIMEOUT |
comm/mailnews/db/gloda/test/unit/test_index_messages_imap_online_to_offline.js
| Test timed out
Most likely they fail
OK, with the patch we see the main window come up and the names of local
folders are already localised, the ones of IMAP folders aren't. They get
corrected a little later. Debugging shows that this happens during
nsImapIncomingServer::PossibleImapMailbox() which calls SetPrettyName().
Looks like
Created attachment 9102698
1575512-glue.patch (v1b)
Here's the final patch with added comments and error checking as well as
added #ifdef since otherwise SeaMonkey won't compile since it doesn't
have mailGlue (but suiteGlue instead).
Try:
Comment on attachment 9101510
1575512-mail-startup-done.patch (v1b)
I guess that would add an observer to every folder created. That's not
so desirable. Perhaps we should remember whether the event already
happened and after that not create any observers any more. That's a
refinement I can make
Created attachment 9102588
1575512-glue.patch - Simplified
Here's a simplified version of the idea. The folder code doesn't check
any more whether the strings are ready, it just assumes that they are
ready when really needed. This works just as well as the other patch but
is less secure.
--
You
Created attachment 9102074
folder-debug-jit.patch
OK, here's the debug patch. It shows:
=== NewURI start block
=== accessing string INBOX in SetPrettyName, blocked=1
=== accessing string Archives in SetPrettyName, blocked=1
=== accessing string Drafts in SetPrettyName, blocked=1
=== accessing
Created attachment 9101990
1575512-mail-startup-done.patch (v3)
Aceman was worried that we might not run the code that fixes the folder
names. So here's a different approach. We don't do the "folder stuff" in
nsImapService::NewURI() which is mostly optional anyway. Surely we don't
need it when
Created attachment 9102048
folder-debug.patch
This matches v2b.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not localized in thunderbird 68
To manage
Created attachment 9102584
1575512-glue.patch
OK, here comes the (hopefully) final solution. It features:
- Using the existing observer in mailGlue which is guaranteed to fire.
- Suppressing throw-away IMAP NewURI folder processing while strings aren't
ready
- No starting up with wrong folder
Created attachment 9102073
1575512-jit-strings.patch (v3c)
Thinking about it, the JIT approach also has its merits. Aceman was
concerned that the SetPrettyName() would happen while we don't have the
strings, so I fixed this in this version. I'll attach a matching debug
patch in a minute.
--
You
Comment on attachment 9102584
1575512-glue.patch
Review of attachment 9102584:
-
It's a pity we have to add these hacks for the current localization
infrastructure. But it is maybe also a bit unusual we cache strings in the
Created attachment 9101999
folder-debug.patch
Here's a debug patch.
Aceman observed correctly, that without a faulty permissions.sqlite the
observer never fires. Looking at the debug, it is is attached after the
system has already fired the event. Whether it fires or not is
irrelevant, it will
Comment on attachment 9101968
1575512-mail-startup-done.patch (v2b)
OK, I think this works well enough. DiscoveryDone() will always run and
if there's a short delay, so be it. We'd have to try this on an opt
build.
--
You received this bug notification because you are a member of Ubuntu
Bugs,
You can see the simplification in the interdiff:
https://bugzilla.mozilla.org/attachment.cgi?oldid=9102584=interdiff=9102588=1
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail
Created attachment 9101968
1575512-mail-startup-done.patch (v2b)
Even better, we attach the observer only to the very first folder.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
Hi Ehsan, thanks for your continued interest and comments. I'll have the
final patch ready in the next hour according to my idea in comment #78.
I think the right solution is not to do the "damaging operations" in the
IMAP code why the system hasn't fully started up.
--
You received this bug
(In reply to Jorg K (GMT+2) from comment #61)
> Hey Ehsan, thanks for your further comment. Let's face it: SeaMonkey is dead
> beyond the equivalent of mozilla60 (sixty, no typo), which they haven't even
> released yet. TB with about 10 staff has replaced all overlays, XBL bindings
> and are
** Changed in: apt-offline (Debian)
Status: Unknown => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848755
Title:
xubuntu and ubuntustudio should not depend on apt-offline (or
*** This bug is a duplicate of bug 1847896 ***
https://bugs.launchpad.net/bugs/1847896
This issue was noted in the Release notes:
https://wiki.ubuntu.com/EoanErmine/ReleaseNotes#Unable_to_shutdown_or_restart_from_the_log_in_screen
** This bug has been marked a duplicate of bug 1847896
I have the same issue after upgrading to Kubuntu 19.10. I worked around
it by disabling secure boot.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848892
Title:
"error: Unknown TPM error." after
** Package changed: unity-settings-daemon (Ubuntu) => lightdm (Ubuntu)
** Package changed: lightdm (Ubuntu) => lightdm
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848849
Title:
Lightdm fails to
Public bug reported:
My current system is Ubuntu 19.04. I run the following command to
upgrade to Ubuntu 19.10
sudo apt update && sudo apt full-upgrade
sudo apt dist-upgrade
sudo do-release-upgrade -d
I got the following error when do-release-upgrade was running.
Invalid package information
501 - 530 of 530 matches
Mail list logo
