[Bug 1959027]

2022-02-10 Thread B-emilio
Thanks all! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959027 Title: [snap] Various UI and theming issues when running in Plasma Wayland session To manage notifications about this bug go to:

[Bug 1959027]

2022-02-06 Thread B-emilio
I see. In that case, I think the remaining issues should be reported to KDE or Canonical (not sure where does the culprit live). Might be worth starting with canonical since it seems snap-specific, but on the other hand this seems specific to snap-on-plasma-on-wayland... Vlad, Olivier, do you

[Bug 1959027]

2022-02-06 Thread B-emilio
Does that happen with other GTK apps ran via snap? I don't think we have control about the GTK theme in use. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959027 Title: [snap] Various UI and

[Bug 1959027]

2022-02-06 Thread B-emilio
Does this work on the nightly? I would expect bug 1734934 to have fixed this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959027 Title: [snap] Various UI and theming issues when running in

[Bug 1922047]

2022-02-05 Thread B-emilio
Bug 1752862 adds prefs to tweak this more precisely. Bug 1753033 tracks potentially switching the default. *** This bug has been marked as a duplicate of bug 1752862 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1871644]

2021-12-16 Thread B-emilio
Bug 1745419 will fix that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications

[Bug 1936647]

2021-12-13 Thread B-emilio
*** Bug 1721154 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1936647 Title: right-click popups transparent after upgrade to Firefox 90 To manage

[Bug 1871644]

2021-12-02 Thread B-emilio
(In reply to gschram from comment #47) > I understand that this is an edge case currently (with the patched mutter) > but I foresee this becoming a "problem" when in a year or two all other apps > also have rounded bottom corners and Firefox is the odd one out, I think > fixing this now is a

[Bug 1871644]

2021-10-21 Thread B-emilio
Oh, great, let me know if I can help. Probably a static atomic integer in nsLookAndFeelGtk is slightly easier to invalidate in practice. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title:

[Bug 1871644]

2021-10-21 Thread B-emilio
Yeah, so `nsWindow::GetTitlebarRadius` can be called off the main thread which seems unfortunate. We can fix this easily by moving the titlebar radius to a member or such. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1871644]

2021-10-21 Thread B-emilio
So, querying the individual border-radius properties doesn't work. I get: > (firefox:17330): Gtk-WARNING **: 00:39:54.651: Style property "border- top-left-radius" is not gettable And same for the other corners of course. However, my patch works, because of [this

[Bug 1871644]

2021-10-21 Thread B-emilio
Well, perhaps, but that seems tangential to this bug, isn't it? We don't use XShapeCombineMask for the titlebar and this patch stack doesn't start doing that. If we do want to do the cleanup described above, we might need a new media query which determines this (but it should definitely not have

[Bug 1871644]

2021-10-21 Thread B-emilio
I fixed the wayland overdraw and the X11 artifacts, so I think this is ready to go. I've tested this stack on KWin and GNOME, both X11 and Wayland. Will test i3 and such asap. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1871644]

2021-10-21 Thread B-emilio
Created attachment 9246314 Bug 1509931 - Use a more precise toolbar radius. r=stransky This seemed possible/maybe worth doing, but let me know if you'd rather keep the 10 hard-coded. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1871644]

2021-10-21 Thread B-emilio
Ah, I think I know why that might be... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage

[Bug 1871644]

2021-10-21 Thread B-emilio
(In reply to Darkspirit from comment #19) > KDE with disabled compositor, i3, etc. use alpha visual, but it's not > transparent. WDYM, just that the background wouldn't be transparent? > Could -moz-gtk-csd-transparent-background be defined with > gdk_screen_is_composited() > and be used to

[Bug 1871644]

2021-10-21 Thread B-emilio
Created attachment 9246291 Bug 1509931 - Simplify titlebar buttons CSS. r=stransky There's no need to use the media query to set the default styles of the buttons, we only need to hide them if appropriate. Depends on D128682 -- You received this bug notification because you are a member of

[Bug 1871644]

2021-10-21 Thread B-emilio
Created attachment 9246289 Bug 1509931 - Use titlebar radius on Linux and make titlebar set-up work for lightweight themes. r=stransky!,dao! Depends on D128680 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1871644]

2021-10-21 Thread B-emilio
Created attachment 9246290 Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky We always use alpha visual for WebRender, and appearance: none is unnecessary (root element has no intrinsic appearance). Depends on D128681 -- You received this bug notification because you are a

[Bug 1871644]

2021-10-21 Thread B-emilio
Created attachment 9246288 Bug 1509931 - Expose titlebar radius as a chrome-only CSS environment variable. r=stransky Mostly plumbing. Depends on D128679 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1871644]

2021-10-21 Thread B-emilio
Created attachment 9246287 Bug 1509931 - Add support for chrome-only environment variables. r=stransky This bit is taken straight from D73454 (I reviewed it but I guess another pair of eyes is ok, it's really straight-forward). Co-authored-by: Nicklas Boman -- You received this bug

[Bug 1871644]

2021-10-21 Thread B-emilio
(In reply to Martin Stránský [:stransky] (ni? me) from comment #11) > Emilio, how is the best way how to do it? We can introduce a new appearance > (-moz-window-titlebar-alpha for instance) which contains only alpha component > from titlebar and paint it over theme color or use existing one >

[Bug 1871644]

2021-10-06 Thread B-emilio
I'm not quite familiar with how this works, I think Martin is the right person to ask about it. I can dig if you want but I'd guess that this kind of stuff (the `:not(:-moz-lwtheme)` bits and such) is related: https://searchfox.org/mozilla-

[Bug 1850529]

2019-12-19 Thread B-emilio
Maybe even tier 2 / running on m-c only, or something? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications

[Bug 1850529]

2019-12-19 Thread B-emilio
(In reply to Mike Hommey [:glandium] (high latency) from comment #24) > That specific comment explicitly says current GCC doesn't implement it. Are > we going to require clang only now? Well GCC just fixed it in fairness: https://gcc.gnu.org/viewcvs/gcc?view=revision=279069 I think they

[Bug 1850529]

2019-12-19 Thread B-emilio
Someone on #introduction mentioned that https://phabricator.services.mozilla.com/D56873 did fix the problem for them. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update

[Bug 1850529]

2019-12-19 Thread B-emilio
(In reply to Nathan Froyd [:froydnj] from comment #19) > (In reply to Mike Hommey [:glandium] (high latency) from comment #18) > > It's very possible this is the same as bug 1601707. If it is, we don't need > > to exclude clang 6. > > OTOH, I don't want to be rediscovering that people are using

[Bug 1850529]

2019-12-19 Thread B-emilio
Ah, thanks for the update Olivier :) I think it'd still be nice to detect this at configure time if possible, but it may be not worth the churn. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529

[Bug 1850529]

2019-12-01 Thread B-emilio
*** Bug 1600467 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage

[Bug 1850529]

2019-12-01 Thread B-emilio
Can we add a configure check for this somehow? It seems ubuntu almost ships a build with this bug, see bug 1600467... :/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after