[Bug 1820514]

2019-04-08 Thread Bzbarsky
Probably because it's doing a DOM walk and should generally be kept up to date with DOM changes... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820514 Title: Saving a web page from Tom's Hardware

[Bug 1820514]

2019-04-08 Thread Bzbarsky
Gijs, thank you for diagnosing this! I agree, webbrowserpersist should not treat NS_NewURI failures as fatal for anything other than dealing with that URI. We could use a general "not Boris" owner for webbrowserpersist. Hsin- Yi, do you have anyone who could do that? -- You received this bug

[Bug 1638610]

2019-01-12 Thread Bzbarsky
> I assume that the second of these now does mean that we can avoid navigation from within beforeunload itself, right? Yes, and we do. See nsDocShell::IsNavigationAllowed. > we don't unload the current document (ie we don't hit the first cited condition) until we start getting a response for

[Bug 1401454]

2015-02-07 Thread Bzbarsky
I don't think you should pay so much attention to the assignee field or the status. Both are often bogus. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1401454 Title: Thunderbird writes

[Bug 1401454]

2015-02-03 Thread Bzbarsky
The patch is not approved because the patch author doesn't think it's ready. See comment 40, which I assume you _did_ read before commenting? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1401454

[Bug 306017]

2014-09-17 Thread Bzbarsky
Just to make it clear, comment 65 is NOT an acceptable mode of interaction in this bug database. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/306017 Title: Firefox search box should be tab

[Bug 306017]

2014-09-17 Thread Bzbarsky
Guys are we using the same browser or different ones ? Same one. Since Find in page search box acts exactly how this [elided] Please watch your language. Otherwise I will disable this account as well. This sort of thing is NOT acceptable. And again, you're addressing your invective to the

[Bug 306017]

2014-09-17 Thread Bzbarsky
macster_sm...@yahoo.com, I've disabled your account due to the abusive comments you're posting after being warned not to do so. I've tagged said comments as spam. I have _not_ thus tagged your comments that contain something useful other than invective. Please feel free to contact me to

[Bug 303269]

2014-08-26 Thread Bzbarsky
This bug is about the page language only. Please file a separate bug on using different spellchecking dictionaries for different parts of the page. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 303269]

2014-08-26 Thread Bzbarsky
Yes, but this bug was then morphed into just following the general-page- specified language, and fixed in that form. Which is why followup work should happen in a separate bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1201954]

2013-12-10 Thread Bzbarsky
Mike? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1201954 Title: Firefox 22+ protocol handler doesn't work properly To manage notifications about this bug go to:

[Bug 259783]

2013-06-06 Thread Bzbarsky
It wasn't applied, correct. It failed to pass the code review process... If you're interested in this, I suggest driving bug 482874 in. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/259783 Title:

[Bug 209509]

2013-02-10 Thread Bzbarsky
Comment on attachment 710783 Patch // Mark the element to be native anonymous before setting any attributes. mTextContent-SetNativeAnonymous(); That part really needs to be before the SetAttr! r=me with that fixed -- You received this bug notification because you are a member of Ubuntu

[Bug 833952]

2012-12-22 Thread Bzbarsky
See comment 19. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/833952 Title: cookie dialogues can pile up out of order, but must still be clicked in order To manage notifications about this bug

[Bug 306017]

2012-06-07 Thread Bzbarsky
How is this new flag different from LOAD_LINK exactly? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/306017 Title: Firefox search box should be tab specific To manage notifications about this bug

[Bug 306017]

2012-06-07 Thread Bzbarsky
And in particular, so far this is a pretty automatic r-, document, but I'd like to understand what problem that flag is actually trying to solve -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 50254]

2012-05-24 Thread Bzbarsky
This bug is about general selection behavior. Comment 89 and following is about urlbar selection, which explicitly overrides the default selection behavior. So they have nothing to do with this bug, which is in fact RESOLVED FIXED. You can test it by double-clicking foo in this text:

[Bug 161961]

2012-05-18 Thread Bzbarsky
Comment on attachment 624229 Patch v1 r=me, but wouldn't the original patch look like your additional test diff if the new file were created with hg cp? If you did _not_ create it that way, I recommend copying your changed version out of the way, hg removing the file, doing the hg cp, then

[Bug 303269]

2012-03-15 Thread Bzbarsky
Michael, this was fixed as of Firefox 8. If you have a testcase that shows it not working in Firefox 11, please file a bug and cc me? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/303269 Title:

[Bug 294712]

2011-09-08 Thread Bzbarsky
There are content policies that implement security checks, last I checked, so we can't just skip calling into content policy code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/294712 Title:

[Bug 223238]

2011-09-05 Thread Bzbarsky
Tyler, I'm not sure there's a firm timeline for it yet certainly order of months, not weeks, at best. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/223238 Title: Extremely slow

[Bug 223238]

2011-09-05 Thread Bzbarsky
Tyler, thanks. That's very useful information! Chances are, not much will happen here until we move to doing our own hardware-accelerated rendering on Linux, which will automatically mean pixmap sizes that the GPU can deal with... -- You received this bug notification because you are a member

[Bug 294712]

2011-08-30 Thread Bzbarsky
Casting from a contact-gotten interface pointer to a concrete class is not ok. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/294712 Title: Firefox does not display images when Show image is

[Bug 294712]

2011-08-30 Thread Bzbarsky
Can you propose something else? Use the classid? Aside from that, is including nsContentBlocker.h in nsContentUtils an issue? I'd suspect yes, but worth checking with bsmedberg... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 303269]

2011-07-27 Thread Bzbarsky
We don't have an existing notification system that would work for that. We'd need to add something. That said, you only care about this for things that have frames, no? Is there a reason that GetStyleVisibility()-mLanguage (which is somewhat different, in that I think it ignores Content-Language

[Bug 303269]

2011-07-27 Thread Bzbarsky
Right; if the style property is good enough we could easily add a notification when it changes. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/303269 Title: Automatically select language for spell

[Bug 303269]

2011-07-27 Thread Bzbarsky
The hard part there is xml:lang, since it needs to apply to all elements and not just the ones that do attribute mapping... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/303269 Title: Automatically

[Bug 303269]

2011-07-27 Thread Bzbarsky
Well, yes, but if that'll just never work we might as well not even start down this route. David, what do you think of the above bits about making the style system's concept of language take into account xml:lang? -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 303269]

2011-07-26 Thread Bzbarsky
For dynamic changes, let's see if bz has any ideas how to handle them efficiently So the goal here is that you want to be notified when the language of some particular content node changes, right? -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 259783]

2011-04-26 Thread Bzbarsky
Comment on attachment 480930 Patch to show internal error pages for HTTP error in the 400/500 range Per comment 8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/259783 Title: firefox does not

[Bug 209509]

2011-04-08 Thread Bzbarsky
I fail to see why you would suggest that. Because multiple people literally spent years looking for a way to prevent the feature from being exploited by a malicious website. They failed to find one. Which is very, had you bothered to read the bug I cited. -- You received this bug

[Bug 677551]

2011-01-28 Thread Bzbarsky
Comment on attachment 507698 Patch v5 This looks fine if we document that parent frame type check. Have roc look at this too? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/677551 Title: pressing

[Bug 176902]

2011-01-10 Thread Bzbarsky
We do need to fix this, but we're not going to hold Gecko 2 for it. Moving to the 2.x list, pending Karl actually having time... -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to kdegraphics in ubuntu. https://bugs.launchpad.net/bugs/176902

[Bug 102408]

2011-01-10 Thread Bzbarsky
We do need to fix this, but we're not going to hold Gecko 2 for it. Moving to the 2.x list, pending Karl actually having time... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/102408 Title: Helper

[Bug 585061]

2011-01-10 Thread Bzbarsky
Pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/17e93767af48 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/585061 Title: Segfaults in nsUrlClassifierDBService.cpp when homedir is

[Bug 159258]

2011-01-09 Thread Bzbarsky
We do need to fix this, but we're not going to hold Gecko 2 for it. Moving to the 2.x list, pending Karl actually having time... -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper

[Bug 585061]

2010-11-19 Thread Bzbarsky
Pushed http://hg.mozilla.org/mozilla-central/rev/ee499eb8ad11 -- Segfaults in nsUrlClassifierDBService.cpp when homedir is inaccessible https://bugs.launchpad.net/bugs/585061 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. --

[Bug 239952]

2010-11-10 Thread Bzbarsky
Sid, if you open Preferences, go to the Applications pane, and type doc in the search field, what do you see? -- firefox - the associated helper application does not exist https://bugs.launchpad.net/bugs/239952 You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 239952]

2010-11-10 Thread Bzbarsky
Sid, I suggest trying support.mozilla.org It doesn't sound like your problem is this bug (which is mostly a linux/mac issue, since they do their helper app mappings by MIME type)... -- firefox - the associated helper application does not exist https://bugs.launchpad.net/bugs/239952 You