(In reply to :Gijs Kruitbosch from comment #74)
> Meh. r+ I guess? I'm not sure why this is "simpler", but obviously it works,
> so whatever.
Mostly because it avoids this blob of spaghetti code:
+let sourceNotKeyEvent = !event.sourceEvent ||
event.sourceEvent.target.localName != "key";
+
Created attachment 8782846
patch v4
Your patch still hurts my brain and I couldn't help thinking this could
be simplified further, so I took a shot at rewriting it myself. I
realize this changes behavior for the "window" case.
--
You received this bug notification because you are a member of Ubu
Comment on attachment 8781962
middlemouse on new tab button should create a new tab related to current,
> function BrowserOpenNewTabOrWindow(event) {
>- if (event.shiftKey) {
>+ let where = whereToOpenLink(event);
>+ if (where == "window") {
> OpenBrowserWindow();
> } else {
>-Browser
Comment on attachment 8642998
middlemouse on new tab button creates a new tab related to current
>+ // Make new tab related to current except for key commands
>+ if (((where == "tab") || (where == "tabshifted")) &&
>+ (!event.sourceEvent || event.sourceEvent.target.localName != "key")) {
>+
Comment on attachment 8642998
middlemouse on new tab button creates a new tab related to current
Let's get ui-review first
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/572074
Title:
New tabs open
*** Bug 1288978 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/263435
Title:
Cannot use firefox keyboard shortcuts when flash object is selected
To ma
Comment on attachment 8902388
Bug 450915 - Increase the drag space of the TabsToolbar by 15px on the bottom
to improve the tab reordering experience.
https://reviewboard.mozilla.org/r/173956/#review179384
::: browser/base/content/browser.css:189
(Diff revision 1)
> + padding-bottom: 20px;
> +}
