[Bug 263661]

2014-02-21 Thread Joe-drew
Created attachment 497112 Use EXTEND_PAD on X This patch is built on my patch in bug 566283, but the merge is pretty trivial. Zack, can you take a look and see if this works? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 263661]

2014-02-21 Thread Joe-drew
Yes, we're listening. This blocks 1.9.3 final, which means it'll be fixed for Firefox 4 final. A plan Jeff and I sketched out involves (IIRC): - Turning on EXTEND_PAD unconditionally, and - using and/or extending the Cairo X version checking code to sniff for the versions of X that EXTEND_PAD

[Bug 263661]

2014-02-21 Thread Joe-drew
Bug 422179 uses EXTEND_PAD if EXTEND_PAD is fast and good - but only for upscales. I suspect we should use EXTEND_PAD for downscales too, which will fix this bug once and for all. I have a patch which I think will do this. -- You received this bug notification because you are a member of Ubuntu

[Bug 263661]

2014-02-21 Thread Joe-drew
Comment on attachment 497112 Use EXTEND_PAD on X It needs review first, and maybe some rebasing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/263661 Title: Black Line appears next to gif and png

[Bug 263661]

2014-02-21 Thread Joe-drew
Comment on attachment 499238 alternative patch: unconditional EXTEND_PAD I can't see myself being OK with this any time soon - there are too many people with old-enough X that unconditional EXTEND_PAD will hurt. -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 263661]

2014-02-21 Thread Joe-drew
Comment on attachment 532740 use RepeatPad on newer X servers even when downscaling Review of attachment 532740: - ::: gfx/thebes/gfxDrawable.cpp @@ +78,5 @@ +case gfxASurface::SurfaceTypeQuartz: +case

[Bug 703191]

2013-03-12 Thread Joe-drew
Jeff says not to bother, since this is actually stealing a patch from upstream. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/703191 Title: BGR-ordered subpixel font rendering appears

[Bug 1134409]

2013-02-28 Thread Joe-drew
CancelAndForgetObserver should be used from the destructor or similar places (i.e. omg I'm going away right now); ideally it wouldn't be necessary at all, but due to the way imagelib delivers notifications, that can't be guaranteed. -- You received this bug notification because you are a member

[Bug 42683]

2011-10-11 Thread Joe-drew
I imagine this was fixed way back when we started using Cairo. Please reopen if that's not the case. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/42683 Title: Reproducable firefox crash

[Bug 374524]

2011-10-11 Thread Joe-drew
I imagine this was fixed way back when we started using Cairo. Please reopen if that's not the case. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/374524 Title: Firefox crashes upon loading

[Bug 744580]

2011-07-18 Thread Joe-drew
http://hg.mozilla.org/mozilla-central/rev/42e432ef2bc4 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/744580 Title: Firefox doesn't auto scroll when selecting content downwards To manage

[Bug 744580]

2011-07-17 Thread Joe-drew
This (along with most things committed on Friday afternoon) was backed out of mozilla-inbound in order to clear up orange. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/744580 Title: Firefox