[Bug 1902801]

2021-01-17 Thread Kai Engert
Everyone, please use bug 1663169 to track the fix of the remaining bug. Marking this one fixed again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1902801 Title: Encrypted attachments cannot be

[Bug 1902801]

2021-01-17 Thread Kai Engert
You're right, I'll file a separate bug, and move the patch over there. Also, I'm working on a test. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1902801 Title: Encrypted attachments cannot be

[Bug 1902801]

2021-01-17 Thread Kai Engert
Sorry for the delays, I was out sick. I can confirm the bug. When recently re-enabling this feature, I had tested only using encrypted attachments which decrypt to plain text. The bug occurs if the attachment decrypts to binary data. I have a fix that I will send for review. -- You received

[Bug 1902801]

2021-01-17 Thread Kai Engert
Created attachment 9196379 Bug 1663169 - Fix decrypting of attachments containing binary data. r=mkmelin -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1902801 Title: Encrypted attachments cannot be

[Bug 1902801]

2020-12-13 Thread Kai Engert
78.6.0 https://hg.mozilla.org/releases/comm-esr78/rev/9e1c528c3a548d27251664c93c94620940672ed2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1902801 Title: Encrypted attachments cannot be opened or

[Bug 1902801]

2020-12-07 Thread Kai Engert
Comment on attachment 9191067 Bug 1663169 - Restore decrypt and save/open right click action for attachments. r=PatrickBrunschwig [Approval Request Comment] Regression caused by (bug #): none User impact if declined: nonworking decrypt feature that's offered in UI Testing completed (on c-c,

[Bug 1902801]

2020-12-07 Thread Kai Engert
(In reply to Magnus Melin [:mkmelin] from comment #15) > Kai, should we just hide this menu until it's working? Or you you have code > pointers to how to fix it? Looks like I restored the functionality with the attached patch. -- You received this bug notification because you are a member of

[Bug 1902801]

2020-12-07 Thread Kai Engert
Created attachment 9191067 Bug 1663169 - Restore decrypt and save/open right click action for attachments. r=PatrickBrunschwig -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1902801 Title:

[Bug 940631]

2020-09-22 Thread Kai Engert
If you're on macOS, our workaround from bug 1610390 is not enabled because of bug 1612456. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/940631 Title: Thunderbird asks three times for my master

[Bug 940631]

2020-01-28 Thread Kai Engert
(In reply to Kai Engert (:KaiE:) from comment #59) > That code would have to prevent the race, by detecting if the first prompt > has already been opened, and all consecutive requests would have to be put on > hold, as long as the first prompt is shown or retrying. After the prompt ha

[Bug 940631]

2020-01-28 Thread Kai Engert
(In reply to Matt from comment #61) > I was reading in Bug 1361838#c2 that .uiBusy == true might be suitable for > mitigating the issue As I understand it, that's simply a flag that can be queried, whether the MP dialog is currently shown. Detecting this state is only part of the problem. You

[Bug 940631]

2019-10-25 Thread Kai Engert
When starting multiple network actions in parallel, more than one might require access to the saved logins. And if the secure password store hasn't yet been unlocked with the master password, then each of those parallel actions might trigger a request to unlock it. The only way to fix this

[Bug 741528]

2011-04-07 Thread Kai Engert
Testing is tricky. Do you want to test the blacklist mechanism? The test cert on kuix.de:9449 will expire soon. I'm not sure what will happen then. You might get EITHER error expired OR error revoked. Only if the error REVOKED then you can continue to use this blacklist test. If EXPIRED has

[Bug 310999]

2011-03-27 Thread Kai Engert
(In reply to comment #89) those 9 certs are now publicly available, so I see no reason to keep that bug private any longer. No, I think the 9 certs are NOT publicly available. In fact, the attacker might not have received the certs, according to Comodo's blog. So, for the time being, it