[Bug 635026] Re: Okular Trim margins doesn't work if paper colour is changed

2012-09-09 Thread Lauri Lyly
Still, if you use page up and page down aggressively, it'll randomly not trim the pages. But I suspect this has nothing to do with this specific bug, unless it's applying settings in a delayed way. You can cause trimming then by zooming in and out randomly. I don't know what triggers it, but it doe

[Bug 635026] Re: Okular Trim margins doesn't work if paper colour is changed

2012-09-09 Thread Lauri Lyly
I confirmed this is the case, so ... there's this function "isWhite" in utils.cpp which isn't used anywhere else than in Utils::imageBoundingBox. I modified it from inline static bool isWhite( QRgb argb ) { return ( argb & 0xFF ) == 0xFF; // ignore alpha } to inline static bool isP

[Bug 635026] Re: Okular Trim margins doesn't work if paper colour is changed

2012-09-09 Thread Lauri Lyly
I looked at the code and the reason for this is probably obvious (can't be totally sure since I don't know in which order things are done here). The imageBoundingBox function is checking whether the pixels to become cropped from the margins are white. So, if you set your paper color to something e

[Bug 635026] Re: Okular Trim margins doesn't work if paper colour is changed

2012-09-09 Thread Lauri Lyly
And my Okular version is like 0.14.3, so it's apparently been there for a while. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to okular in Ubuntu. https://bugs.launchpad.net/bugs/635026 Title: Okular Trim margins doesn't work if paper colo

[Bug 635026] Re: Okular Trim margins doesn't work if paper colour is changed

2012-09-09 Thread Lauri Lyly
Oh yeah... and if the trimming was set before I enable this setting, it stays on for a while until I switch to a new page or so. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to okular in Ubuntu. https://bugs.launchpad.net/bugs/635026 Title:

[Bug 635026] Re: Okular Trim margins doesn't work if paper colour is changed

2012-09-09 Thread Lauri Lyly
Also affects me. As a side-note, for me the trimming only starts working again for the same document if I restart Okular after I disable the paper colour setting. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to okular in Ubuntu. https://bugs.