[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Daniel Holbach
You might have to add XS-Testsuite: autopkgtest to debian/control. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1073346 Title: alsa-lib package needs a compile/link/run test To manage

Re: [Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Luke Yelavich
I must admit I do not see the point of this test. If the package fails to build, this will be known before the autopkg tests are run. The building of the package could also be a test in of itself. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed

Re: [Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Luke Yelavich
Oh sorry, I misread the patch, thats probably not a bad start for such a test, and can be further expanded in the future. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1073346 Title:

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Martin Pitt
Luke, we don't always rebuild packages if any of their dependencies, tool chain, multi-arch configuration etc. change, and tests during the package build won't help you to verify that your debian/ bits install all the required header, pkg-config etc. files. -- You received this bug notification

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Martin Pitt
Confirmed to work with: $ run-adt-test -r quantal -a amd64 -b lp:~rafalcieslak256/ubuntu/quantal /alsa-lib/build-test alsa-lib But please commit the XS-Testsuite: autopkgtest header (or whoever merges this), as otherwise we can't run it automatically. ** Tags added: qa-verified -- You

Re: [Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Luke Yelavich
On Wed, Oct 31, 2012 at 09:24:09AM CET, Martin Pitt wrote: Luke, we don't always rebuild packages if any of their dependencies, tool chain, multi-arch configuration etc. change, and tests during the package build won't help you to verify that your debian/ bits install all the required header,

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Rafal Cieślak
Thanks for verifying that. I have added XS-Testsuite entries and committed changes to lp:~rafalcieslak256/ubuntu/quantal/alsa-lib/build-test I am unsure if this is correct though, requesting merge back to the branch I started with results in a diff of lots of changes, apparently including

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread David Henningsson
The branch you're looking for is probably https://code.launchpad.net /~ubuntu-audio-dev/alsa-lib/ubuntu.quantal - as we also advertise when running apt-get source alsa-lib However I guess Luke or Martin will pick it up anyway. Thanks for your contribution! -- You received this bug notification

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Launchpad Bug Tracker
** Branch linked: lp:~ubuntu-audio-dev/alsa-lib/ubuntu -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1073346 Title: alsa-lib package needs a compile/link/run test To manage notifications about

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/raring-proposed/alsa-lib -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1073346 Title: alsa-lib package needs a compile/link/run test To manage notifications about this

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-31 Thread Launchpad Bug Tracker
This bug was fixed in the package alsa-lib - 1.0.25-3ubuntu5 --- alsa-lib (1.0.25-3ubuntu5) raring-proposed; urgency=low * Add a compile/run autopkg test, thanks to Rafał Cieślak. (LP: #1073346) -- Luke Yelavich them...@ubuntu.com Wed, 31 Oct 2012 13:49:43 +0100 ** Changed in:

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-30 Thread Rafal Cieślak
I cannot manage to make a correct MP, looks like I am picking wrong branches to work on. Attaching a patch instead. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1073346 Title: alsa-lib package

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-30 Thread Rafal Cieślak
** Patch added: build_test.patch https://bugs.launchpad.net/ubuntu/+source/alsa-lib/+bug/1073346/+attachment/3419134/+files/build_test.patch ** Changed in: alsa-lib (Ubuntu) Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1073346] Re: alsa-lib package needs a compile/link/run test

2012-10-30 Thread Ubuntu Foundation's Bug Bot
The attachment build_test.patch of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch'