[Bug 1108518] Re: lightdm should not rename() .xsession-errors, as it may be a symlink

2013-02-01 Thread Alec Warner
I took a stab at this in the noted branch. my glib is terrible and It looks like we need to do this twice in session-child.c? ** Branch linked: lp:~antarus/lightdm/bug1108518 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bug

[Bug 1108518] Re: lightdm should not rename() .xsession-errors, as it may be a symlink

2013-01-31 Thread Alec Warner
My point isn't so much that there is a race, or a sec vuln or something. My point is that on my systems: $HOME may be on NFS. $HOME/.xsession-errors is a symlink to /usr/local/home/$USER/.xsession-errors $HOME/.xsession-errors.old is a symlink to /usr/local/home/$USER/.xsession-errors.old The ob

[Bug 1108518] Re: lightdm should not rename() .xsession-errors, as it may be a symlink

2013-01-29 Thread Robert Ancell
Is there an atomic way of doing this? Otherwise the file could be replaced with a symlink between the lstat and the copy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1108518 Title: lightdm should

[Bug 1108518] Re: lightdm should not rename() .xsession-errors, as it may be a symlink

2013-01-29 Thread Sebastien Bacher
Thank you for your bug report, the people working on lightdm are pretty busy with other projects as well, having a patch up for review would be very welcome if you want to work on one ;-) Note that the best to submit one for review is through a merge request, you can do one following those steps: